admin
658401c36d
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Vvz1NCu22p8dGkRCpeX9re
84 lines
7.1 KiB
Markdown
84 lines
7.1 KiB
Markdown
# felhom.eu — task reports
|
||
|
||
> **Overwrite** this file with a summary of the most recent task only (uniform with the other repos; not cumulative). The cumulative hub history lives in [hub/CHANGELOG.md](hub/CHANGELOG.md); the scripts history lives in [scripts/CHANGELOG.md](scripts/CHANGELOG.md).
|
||
|
||
## Hub v0.47.0 — UI reorganization (customer tabs, Host tab, stale-host removal, offsite multi-endpoint UI, button contrast) — 2026-07-11
|
||
|
||
### 1. Baseline
|
||
|
||
felhom.eu `main` @ `8e1a3f0d82b62ac84835ddf0aa5a6fd523afb034`, hub v0.46.0 (CHANGELOG top +
|
||
running footer + `manifests/hub.yaml` all agreed). Spec: the "Hub UI reorganization" TASK.
|
||
|
||
### 2. Files created / modified
|
||
|
||
- `hub/internal/web/templates/style.css` — `.data-table td a:not(.btn)` contrast fix + tab/summary-strip/badge CSS
|
||
- `hub/internal/web/templates/customer_unified.html` — 8 hash-tab panels + sticky summary strip + Events badge + Host tab (all sections preserved; hiding = JS-added body class only)
|
||
- `hub/internal/web/templates/host_detail_body.html` — NEW: shared `{{define "host_detail_body"}}` (identity/vitals/guests/storage/diagnostics/DR + the Deletable-gated danger zone)
|
||
- `hub/internal/web/templates/host_detail.html` — reduced to chrome + sub-template call
|
||
- `hub/internal/web/templates/offsite.html` — endpoint cards + add/edit/delete forms + Endpoint peer column + deferral note
|
||
- `hub/internal/web/hosts.go` — `hostDetailData` builder; `handleHostDeleteImpact` + `handleHostDelete`
|
||
- `hub/internal/web/configs.go` — `Hosts` view models on the customer page (via `ListHostsByCustomer`)
|
||
- `hub/internal/web/offsite.go` — multi-endpoint render + save/delete handlers + subnet/peer guards
|
||
- `hub/internal/web/server.go` — routes: `/hosts/{id}/delete-impact|/delete` (above the catch-all), `/offsite/endpoints[...]`
|
||
- `hub/internal/store/store.go` — `ListHostsByCustomer`, `HostArtifacts`/`CountHostArtifacts`, `DeleteHost` (one-tx cascade), `ErrHostEscrowPresent`
|
||
- `hub/internal/store/wg.go` — `ListWGEndpoints`, `DeleteWGEndpoint`; `SetWGEndpoint` comment updated (behavior untouched)
|
||
- Tests: `hub/internal/web/customer_tabs_test.go` (new), `hosts_delete_test.go` (new), `offsite_test.go` (amended deliberately), `hosts_test.go` (pin comment), `hub/internal/store/host_delete_test.go` (new), `wg_endpoints_test.go` (new), `host_test.go` (+`TestListHostsByCustomer`)
|
||
- Docs: `hub/CHANGELOG.md` (v0.47.0), `hub/README.md` (tab map, host lifecycle, offsite mgmt), `CONTEXT.md`, `REUSE.md` (new §2 table), `manifests/hub.yaml` (tag 0.47.0)
|
||
|
||
### 3. Commits on `main`
|
||
|
||
| Commit | Content |
|
||
|---|---|
|
||
| `9f29bf3` | Part 1+2: CSS contrast fix + customer hash tabs + tab render tests |
|
||
| `ae950e5` | Part 3: `host_detail_body` sub-template + Host tab + `ListHostsByCustomer` |
|
||
| `146d165` | ⚠ NOT mine — the parallel NFS session's docs commit whose `git add -A` swept my Part-4 WIP **mid-red-proof** (hosts.go landed with the RED-PROOF-2 mutation, escrow ack bypassed; everything else was in final correct state) |
|
||
| `068427a` | Part 4 completion: restored the escrow-ack gate line (the only delta vs. the intended state) |
|
||
| `0daddcd` | Part 5: offsite multi-endpoint UI + guards + tests |
|
||
| `95d71fe` | Part 6: CHANGELOG/README/CONTEXT/REUSE docs + `manifests/hub.yaml` → 0.47.0 |
|
||
| `77247f9` | this REPORT.md |
|
||
|
||
### 4. Red-proofs (all five ran: mutation → FAIL with the wrong value visible → revert → green)
|
||
|
||
1. **Online gate removed** (`handleHostDelete`) → `TestHostDelete_OnlineRefused` FAILED: `online delete = 303, want 409` (live host deleted). Reverted.
|
||
2. **Escrow-ack check dropped** (`deleteEscrow := true`) → `TestHostDelete_EscrowAckRequired` FAILED: `escrow-unacked delete = 303, want 409`. Reverted. (This exact mutation is what `146d165` accidentally shipped; `068427a` is the revert on main.)
|
||
3. **Endpoint-delete peers-in-subnet guard removed** → `TestOffsiteEndpointDelete_Guard` FAILED: `delete with peers = 303, want 409`. Reverted.
|
||
4. **Subnet-change guard removed** → `TestOffsiteEndpointSave_SubnetChangeGuard` FAILED: `subnet change with peers = 303, want 409`. Reverted.
|
||
5. **log_bundles scope widened** (`WHERE scope_id = ? OR 1=1`) → `TestDeleteHost_CascadeAndIsolation` FAILED: `customer-scoped log bundle count = 0, want 1` + unrelated-host rows deleted. Reverted.
|
||
|
||
### 5. Tests
|
||
|
||
`cd hub && go build ./... && go vet ./... && go test ./...` — **all green** at every commit.
|
||
Test functions in `hub/`: **259 → 280** (+21). Pinned invariants kept green UNMODIFIED:
|
||
hosts-list zero-`<button>`, host-detail exactly-2-buttons (now doubles as the delete-hidden-
|
||
for-online proof, comment added), SECRET-LEAK assertions, pubkey-title + empty-href offsite pins.
|
||
|
||
### 6. Deploy (GitOps — no `kubectl set image` used)
|
||
|
||
- Image built + pushed on 180: `gitea.dooplex.hu/admin/felhom-hub:0.47.0` (25M).
|
||
- Deploy = the `manifests/hub.yaml` bump in `95d71fe`; ArgoCD hard-refresh → deliberate sync (Application CR patch).
|
||
- Verify: `sync=Synced health=Healthy`; `deployment "hub" successfully rolled out`; deploy image `gitea.dooplex.hu/admin/felhom-hub:0.47.0`; startup log clean (all checkers initialized, `Listening on :8080`, 2026-07-11 21:41 CEST).
|
||
|
||
### 7. Live validation (method: claude-in-chrome against hub.felhom.eu)
|
||
|
||
- Serving confirmed: hub.felhom.eu responds post-rollout (login page renders; pod log + image verified via kubectl as above).
|
||
- **BLOCKED — operator login required:** hub web sessions are in-memory, so the 0.47.0 rollout
|
||
invalidated every session; the operator password gate is CC-uncrossable by policy. Pending items
|
||
(exact spec §13 list) once a logged-in Chrome session exists:
|
||
1. `/hosts/demo-felhom-01` Diagnostics View/Download button contrast screenshot (Scenario F);
|
||
2. `/customers/demo-felhom` tabs + `#tab=events` deep-link + auto-refresh tab persistence + Host tab + sticky strip + narrow viewport;
|
||
3. delete `dr-drill-host` and `dr-drill-host3` end-to-end (impact preview → type-to-confirm → escrow checkbox if flagged) + wg-peer convergence on `/offsite` within one reconciler tick — do NOT touch `demo-felhom-01` / `peti-felhom-86d37d`;
|
||
4. `/offsite` ep0 card + bad-CIDR edit probe (expect 400; no real value changed, no second real endpoint).
|
||
- The same flows are covered by unit/render tests (Scenarios A–E); the live pass is confirmatory.
|
||
|
||
### 8. NOT live-validated (by design)
|
||
|
||
- Multi-endpoint allocation/reconciler/desired-state — deferred arc, deliberately untouched (`GetWGEndpoint` semantics pinned by test).
|
||
- Host deletion of a once-online host WITH escrow on the live hub — no such junk host exists; covered by unit tests only.
|
||
|
||
### 9. Observations (documented, not acted on)
|
||
|
||
- `146d165` (parallel session) demonstrates that `git add -A` doc commits in a shared repo can ship another session's mid-mutation WIP — worth a convention note (stage explicit paths).
|
||
- `hostInstallVersion` in `web/configs.go` still says `1.12.0` while host-install is at v1.13.0 (display-only constant; out of scope here).
|
||
- Hub web sessions live in process memory — every deploy logs every operator out; a persisted session store would remove the "revalidate after each rollout" friction.
|
||
- The workspace-root CLAUDE.md hub-deploy wording predates GitOps (noted in CONTEXT.md).
|