hub (unreleased): the System page shows the kernel clean-up and the security-profile refresh; a clean-up no longer hides a kernel step (R-1383)
gates / gates (push) Successful in 2m20s
gates / gates (push) Successful in 2m20s
Claude-Session: https://claude.ai/code/session_0159rPz1ZhFKsS53msqPYxtS
This commit is contained in:
1 parent
e5c643d73d
commit
68292e40f6
14 files changed
+452
-13
No files matched your search
@@ -670,8 +670,19 @@ until a later step ends `good`.
|
||||
kernel-layer report with outcome `cleaned`; the System page's „Kernel step" cell then reads „cleaned <time ago>", and
|
||||
the report's text (what was removed, kept and gained) is stored but shown nowhere. A refusal or a failure raises the
|
||||
existing operator event „Kernel step on <box> refused/failed: …". „Nothing to remove" and „not run" are log lines
|
||||
on the box only. The report carries no kernel version on purpose: the hub reads that as a kernel step. What is missing
|
||||
is in R-1383 (release 3).
|
||||
on the box only. The report carries no kernel version on purpose: the hub reads that as a kernel step. **Corrected
|
||||
2026-11-14 (night):** the text was shown — as the cell's hover title — and the cell had a defect: a clean-up and a
|
||||
kernel step are both kernel-layer reports, and the cell showed the NEWEST of the two, so a clean-up the night after a
|
||||
kernel fell back replaced the amber „fell_back” line with „cleaned”.
|
||||
- **`[FACT — built, not released: agent `main` after 0.174.0 and hub `main` after v0.181.0, 2026-11-14; R-1383,
|
||||
release 3]`** The clean-up's report carries its own object `kernel_cleanup` (`removed` — package names, `kept` —
|
||||
kernel versions, `bytes_gained`, `leftovers` — a count). It is NOT the `kernel` view: the report still has no `kernel`
|
||||
key and its `release_id` is `kernel-cleanup`, and the hub's `kernelOf` reads only those two — so the names in the new
|
||||
object cannot be read as a step (tested on both sides). The hub keeps the object in the stored report, reads the newest
|
||||
STEP and the newest CLEAN-UP each from its own report (`KernelLineFor`), and the System page has a cell of its own,
|
||||
**„Kernel clean-up”**: „removed 6, kept 2 · 6.0 GiB gained · 3 h ago”, the names in the title; amber when it was
|
||||
refused or failed, or left paths behind. An agent of 0.174.0 sends no object: the cell then reads „cleaned <time
|
||||
ago>” with the report's text as its title. Not seen on a box or a deployed hub.
|
||||
|
||||
**Proven on boxes with the program** (2026-11-14, `audits/release-2a-2026-11-14/D/`): Tester 1 — 3 kernels → 2
|
||||
(`proxmox-kernel-7.0.14-20-pve-signed`), 1.12 GB gained, 8.5 s, nothing else changed, no left-over, the second call
|
||||
@@ -712,8 +723,19 @@ takes nothing from the plan but `dry_run`, F1):
|
||||
4. A parser failure writes no record; the next start tries again.
|
||||
|
||||
**The agent** asks at every start and after a config bundle was installed (a new wrapper may know the mode the old one
|
||||
refused), under the heavy-op gate (up to 12 tries, 5 minutes apart) and never beside an OS-update pass. Nothing goes to
|
||||
the hub (no field exists for it; R-1383).
|
||||
refused), under the heavy-op gate (up to 12 tries, 5 minutes apart) and never beside an OS-update pass. In agent
|
||||
0.174.0 nothing goes to the hub.
|
||||
|
||||
**`[FACT — built, not released: agent `main` after 0.174.0 and hub `main` after v0.181.0, 2026-11-14; R-1383,
|
||||
release 3]` What the hub is told.** Not an OS report: the hub reads a report of a layer it does not know as a GUEST
|
||||
step. The result rides the host report as the stanza `profile_refresh`: `kernel`, `at`, `rewritten` (a count) and
|
||||
`restarted` (unit names) from the ROOT wrapper's own record (`/var/lib/felhom-os-apply/profile-refresh.json`, 0644 —
|
||||
so the box's last refresh is still told after an agent restart), and `last_ask` / `last_ask_at` — how the last ask of
|
||||
this agent process ended (refreshed · not_needed · failed · refused · no_answer). The agent reads one small file and
|
||||
does not call the wrapper for it; a name that is not a plain unit name is dropped. The System page's cell
|
||||
**„Security profiles”** reads „7.0.14-28-pve · 2 rewritten · 18 h ago · restarted chrony.service”; amber, and under
|
||||
„Needs attention”, when the last ask failed or got no answer. A refused ask (an older wrapper, a BYO host) is not a
|
||||
fault. No alarm is raised for a restart: it is shown, not mailed. Not seen on a box or a deployed hub.
|
||||
|
||||
**Measured on demo-hp, both guests running** (`audits/profile-refresh-spike-2026-11-14/`): the fault was reproduced
|
||||
with one planted stale profile (chrony failed with the N100's own error); the refresh took 0.51 s; the same 119
|
||||
|
||||
@@ -0,0 +1,44 @@
|
||||
== MUTATION: the clean-up's detail is not sent (the hub shows only „cleaned”)
|
||||
RED on the mutant, GREEN on the real file
|
||||
--- FAIL: TestKernelCleanup_NightOrderOnceAndNoNames (0.00s)
|
||||
kernel_test.go:408: the clean-up's detail did not reach the hub: <nil>
|
||||
== MUTATION: the clean-up report names a kernel as its release (the hub reads a kernel STEP)
|
||||
RED on the mutant, GREEN on the real file
|
||||
--- FAIL: TestKernelCleanup_NightOrderOnceAndNoNames (0.00s)
|
||||
kernel_test.go:401: the clean-up's report names a kernel (the hub reads that as a kernel step): {RunID:20261004T040000Z Layer:kernel Trigger:night Mode:kernel-cleanup Ring:0 ReleaseID:7.0.14-22-pve Outcome:cleaned Healthy:true Hea
|
||||
== MUTATION: the clean-up report carries a kernel view
|
||||
RED on the mutant, GREEN on the real file
|
||||
--- FAIL: TestKernelCleanup_NightOrderOnceAndNoNames (0.00s)
|
||||
kernel_test.go:401: the clean-up's report names a kernel (the hub reads that as a kernel step): {RunID:20261004T040000Z Layer:kernel Trigger:night Mode:kernel-cleanup Ring:0 ReleaseID:kernel-cleanup Outcome:cleaned Healthy:true He
|
||||
|
||||
3 mutations, 0 not a red-proof
|
||||
== MUTATION: the stanza is built only from memory (an agent restart forgets the box's last refresh)
|
||||
RED on the mutant, GREEN on the real file
|
||||
--- FAIL: TestProfileRefreshStanza_RecordAndLastAsk (0.00s)
|
||||
profilerefresh_test.go:126: stanza after a refresh = {"rewritten":0,"last_ask":"refreshed","last_ask_at":"2026-11-14T11:30:11Z"}
|
||||
== MUTATION: a failed ask is not remembered
|
||||
RED on the mutant, GREEN on the real file
|
||||
--- FAIL: TestProfileRefreshStanza_RecordAndLastAsk (0.00s)
|
||||
profilerefresh_test.go:143: stanza after a failed ask = {"kernel":"7.0.14-28-pve","at":"2026-11-14T11:30:11Z","rewritten":2,"restarted":["chrony.service"]}
|
||||
== MUTATION: nothing to say is sent as an empty stanza, not omitted
|
||||
*** NOT A RED-PROOF *** (mutant rc=1 built=False real rc=0)
|
||||
FAIL gitea.dooplex.hu/admin/felhom-agent/internal/osupdate [build failed]
|
||||
internal/osupdate/profilerefresh.go:62:2: declared and not used: have
|
||||
== MUTATION: a unit name is passed on unchecked
|
||||
RED on the mutant, GREEN on the real file
|
||||
--- FAIL: TestProfileRefreshStanza_RecordAndLastAsk (0.00s)
|
||||
profilerefresh_test.go:126: stanza after a refresh = {"kernel":"7.0.14-28-pve","at":"2026-11-14T11:30:11Z","rewritten":2,"restarted":["chrony.service","bad name; rm -rf"],"last_ask":"refreshed","last_ask_at":"2026-11-14T11:30:11Z"
|
||||
|
||||
4 mutations, 1 not a red-proof
|
||||
== MUTATION: main does not wire the profile stanza into the report
|
||||
RED on the mutant, GREEN on the real file
|
||||
--- FAIL: TestMainWiresPVETrust (0.02s)
|
||||
pvetrust_wiring_test.go:68: main.go wires "profile refresh → report" 0 time(s), want at least 1 (the two-call ones: at start and after a bundle install)
|
||||
|
||||
1 mutations, 0 not a red-proof
|
||||
== MUTATION: nothing to say is sent as an empty stanza, not omitted — done again: the first mutant did not compile
|
||||
RED on the mutant, GREEN on the real file
|
||||
--- FAIL: TestProfileRefreshStanza_RecordAndLastAsk (0.00s)
|
||||
profilerefresh_test.go:114: before any refresh the stanza is osupdate.ProfileRefreshStatus{Kernel:"", At:"", Rewritten:0, Restarted:[]string(nil), LastAsk:"", LastAskAt:""}, want an untyped nil
|
||||
|
||||
1 mutations, 0 not a red-proof
|
||||
@@ -0,0 +1,66 @@
|
||||
== MUTATION: the newest kernel-layer report is the step (a clean-up hides a kernel that fell back — the old behaviour)
|
||||
RED on the mutant, GREEN on the real file
|
||||
--- FAIL: TestKernelLine_CleanupBesideTheStep (0.05s)
|
||||
kernel_cleanup_line_test.go:41: the clean-up HID the step: the step line reads "cleaned" for "", want fell_back for 7.0.14-22-pve
|
||||
== MUTATION: the clean-up line has no detail
|
||||
RED on the mutant, GREEN on the real file
|
||||
--- FAIL: TestKernelLine_CleanupBesideTheStep (0.04s)
|
||||
kernel_cleanup_line_test.go:45: the clean-up's own fields: outcome "cleaned" detail <nil>
|
||||
(the third mutation of this group matched two places in the file and did not run; it is done again at the end)
|
||||
== MUTATION: the hub's report struct does not keep kernel_cleanup (lost at ingest)
|
||||
RED on the mutant, GREEN on the real file
|
||||
--- FAIL: TestKernelLine_CleanupBesideTheStep (0.05s)
|
||||
kernel_cleanup_line_test.go:45: the clean-up's own fields: outcome "cleaned" detail <nil>
|
||||
|
||||
1 mutations, 0 not a red-proof
|
||||
== MUTATION: left-over paths are not amber
|
||||
RED on the mutant, GREEN on the real file
|
||||
--- FAIL: TestSystemCells_KernelCleanupAndSecurityProfiles (0.00s)
|
||||
system_b3_test.go:35: left-over paths must be amber and named: {Text:removed 6, kept 2 · 6.0 GiB gained · 3 h ago · 2 left-over path(s) Class: Title:removed: proxmox-kernel-7.0.2-6-pve-signed, b, c, d, e, f — kept: 7.0.14-26-pve,
|
||||
== MUTATION: a refused or failed clean-up is not amber
|
||||
RED on the mutant, GREEN on the real file
|
||||
--- FAIL: TestSystemCells_KernelCleanupAndSecurityProfiles (0.00s)
|
||||
system_b3_test.go:43: refused clean-up: {Text:refused 1 h ago Class: Title:K4: the phase is judging}, want amber with the reason
|
||||
system_b3_test.go:43: failed clean-up: {Text:failed 1 h ago Class: Title:K4: the phase is judging}, want amber with the reason
|
||||
== MUTATION: a failed ask of the profile refresh is not amber
|
||||
RED on the mutant, GREEN on the real file
|
||||
--- FAIL: TestSystemCells_KernelCleanupAndSecurityProfiles (0.00s)
|
||||
system_b3_test.go:63: last ask failed: {Text:7.0.14-28-pve · 2 rewritten · 18 h ago · last ask FAILED 1 h ago Class: Title:last ask: failed}, want amber, the failed ask AND the older record
|
||||
system_b3_test.go:63: last ask no_answer: {Text:7.0.14-28-pve · 2 rewritten · 18 h ago · last ask NO_ANSWER 1 h ago Class: Title:last ask: no_answer}, want amber, the failed ask AND the older record
|
||||
--- FAIL: TestSystemPage_ShowsCleanupAndProfiles (0.05s)
|
||||
== MUTATION: the restarted services are not shown
|
||||
RED on the mutant, GREEN on the real file
|
||||
--- FAIL: TestSystemCells_KernelCleanupAndSecurityProfiles (0.00s)
|
||||
system_b3_test.go:54: profile cell "7.0.14-28-pve · 2 rewritten · 18 h ago" lacks "restarted chrony.service"
|
||||
== MUTATION: a refused ask (an older wrapper) is amber
|
||||
RED on the mutant, GREEN on the real file
|
||||
--- FAIL: TestSystemCells_KernelCleanupAndSecurityProfiles (0.00s)
|
||||
system_b3_test.go:68: a refused ask (an older wrapper) is not a fault: {Text:no refresh yet Class:warn Title:last ask: refused (an older root wrapper that does not know the mode, or a BYO host)}
|
||||
|
||||
5 mutations, 0 not a red-proof
|
||||
== MUTATION: the two cells are built and never put on the row
|
||||
RED on the mutant, GREEN on the real file
|
||||
--- FAIL: TestSystemPage_ShowsCleanupAndProfiles (0.06s)
|
||||
system_b3_test.go:86: the System page lacks "removed 1, kept 1"
|
||||
system_b3_test.go:86: the System page lacks "1.0 GiB gained"
|
||||
system_b3_test.go:86: the System page lacks "restarted chrony.service"
|
||||
== MUTATION: the profile cell is not in the needs-attention list
|
||||
RED on the mutant, GREEN on the real file
|
||||
--- FAIL: TestSystemPage_ShowsCleanupAndProfiles (0.05s)
|
||||
system_b3_test.go:90: a failed ask of the profile refresh is not under „Needs attention”
|
||||
|
||||
2 mutations, 0 not a red-proof
|
||||
== MUTATION: the hub does not read the profile_refresh stanza
|
||||
RED on the mutant, GREEN on the real file
|
||||
--- FAIL: TestSystemCells_KernelCleanupAndSecurityProfiles (0.00s)
|
||||
system_b3_test.go:54: profile cell "—" lacks "7.0.14-28-pve"
|
||||
system_b3_test.go:54: profile cell "—" lacks "2 rewritten"
|
||||
system_b3_test.go:54: profile cell "—" lacks "restarted chrony.service"
|
||||
|
||||
1 mutations, 0 not a red-proof
|
||||
== MUTATION: only the newest report is read (a later step drops the clean-up line) — done again: the first spec matched two places and did not run
|
||||
RED on the mutant, GREEN on the real file
|
||||
--- FAIL: TestKernelLine_CleanupBesideTheStep (0.04s)
|
||||
kernel_cleanup_line_test.go:41: the clean-up HID the step: the step line reads "" for "", want fell_back for 7.0.14-22-pve
|
||||
|
||||
1 mutations, 0 not a red-proof
|
||||
@@ -332,7 +332,7 @@ stopping line that lies.
|
||||
| **R-1365** | Monitoring & notifications | P3 | **A security-watch source that stays down mails once and never again; after that only one line of the Monday summary says so.** An open advisory reminds every 7 days, a failed source does not (`08` §11 [DESIGN], „once per streak"). The cost was seen 2026-10-28 → 11-02: one mail, then a week of silence. With the seven pins that can never be read now a stated GAP (R-1334), a streak means a real outage. | WAITING-ON-OPERATOR — D66 | D66 | on yes: `plan()` mails a streak again every 7 days, with a test seen failing; `08` §11's line changes | operator (decision), CC (build) |
|
||||
| **R-1371** | Monitoring & notifications | P3 | **Seven places have no space alarm, and the host-disk alarm that does exist goes to the household.** Found 2026-11-10 (the space list, `documentation/audits/space-list-2026-11-10/TABLE.md`, question 6). (1) **The guest root disk has no watcher.** The controller watches `/` and the system data path, but inside its container both are the data volume (measured on all three boxes, `evidence/extra/controller-fs-view.txt`); the 32 GiB guest root disk, which holds `/opt/docker/stacks`, is not a target. Closed row R-521 says it is — true only before the two volumes were merged; capability-map row C13 („warned before a filesystem fills — per filesystem”) does not hold for this one filesystem (the map's status is not changed here). (2) **The same filesystem is two targets**, and warnings are de-duplicated by path, so two warnings for one full disk are expected (read from source, not proved live; the comment at `cmd/controller/main.go:2694-2707` says the opposite). (3) **`host_disk_critical` and `storage_fill_critical` are mailed to the household by default** (`hub/internal/claim/engine.go:229-243`), but only the operator can free a host disk; the seed list was chosen as „critical only” and the question „can this reader act on it” was not asked. No architecture document names the host-disk event (search S4; `08-alarm-ladder.md` names the thin-pool one). (4) Small places with no alarm: EFI partition, temp folders, guest system log, guest package cache. **Members (answers marked N):** H10-6, H15-6, G1-6, G13-6, G15-6, G16-6, G17-6. | OPEN — filed 2026-11-10 (space list) **2026-11-10 12:22 — RULED (D68 = operator only; `09` §3 decision 287):** the household is not mailed about a host disk it cannot free. **2026-11-10 — parts (2) and (3) FIXED IN SOURCE, NOT RELEASED.** (2) felhom-controller `844f19f1`: one fill target per filesystem (`system.FilesystemKey`; the container's `/` is an overlay with its own device number, so the identity is taken from a Docker-kept file — `documentation/audits/space-list-2026-11-10/evidence/extra/fs-identity.txt`); `TestR1371_*`, red seen three times; not proven on a box. (3) hub source, no build: `host_disk_warning` / `host_disk_critical` are operator-only and the critical is not seeded; `storage_fill_*` reaches a household only for `usb`, `local-dir`, `nfs`, `cifs` (`notify.operatorOnlyFor`; `08-alarm-ladder.md`); `TestD68_*`, red seen three times. Parts (1) and (4) stay open: who watches the guest root disk is a design point in `16-storage-physical-identity.md`. **2026-11-10 (afternoon) — two design points added** (`16-storage-physical-identity.md` §14.4): a drive in the backup role reports as `usb` or `local-dir`, so the household gets the `storage_fill` mail for a drive it must not clean by hand; the hub's first list for a household still holds `storage_fill_critical` until the box sends its own list (not measured on the running hub). Also noted: the closed row R-521 and `felhom-controller/controller/cmd/controller/r521_f7_rootfs_test.go:29,36` call the watched path „the guest's root filesystem”; it is the container's `/`, an overlay on the data volume. The guest's real root disk is the one part (1) says nobody watches. **2026-11-10 (release run) — parts (2) and (3) RELEASED** (`documentation/audits/release-space-fixes-2026-11-10/`). (2) controller 0.352.0, global floor 15:31 UTC: on scratch guest 9202 one fill sent TWO warnings on the version before and ONE on the new one (so the double warning is now seen on a box, not only read from source); Tester 1, demo-hp and demo-felhom each check 2 filesystems where they checked 3. (3) hub 0.180.0 live since 15:12 UTC, Synced/Healthy; proof = the `TestD68_*` tests and the deployed commit. **Not proven on the running hub:** that a household which saved its own alarm list before no longer gets the host-disk type — the pages that show a household's list refuse a token (by design, `05` §17) and no test alarm was made (`16` §14.4). **Still open:** (1) the guest root disk has no watcher (design point); (4) the small places; a real fill on a household's box. | — | Controller: add the guest root disk as a fill-watch target, de-duplicate targets by filesystem, correct the comment; red-proof with two paths on one filesystem. Hub: after the pick, route the two host-disk events. Docs: name the host-disk alarm and its reader in `08-alarm-ladder.md`. | CC |
|
||||
| **R-1379** | Monitoring & notifications | P3 | **An end date exists and nobody is warned before it (18 answers).** Found 2026-11-11 (the End-dates list, class T1, `documentation/audits/end-dates-list-2026-11-11/TABLE.md`; dates measured read-only on three boxes and from public certificates). No alarm fires before any of these ends: the box's web certificate (DB01-5, DB01-7: Traefik renews by itself; a renewal that fails is silent until the day), the hub address certificate (DH20-5), the operator tokens with a 90-day life (DH22-5), a node's Tailscale key (DH30-5), Debian's package keys (DB16-5), the 30-day restore copy (DB24-5), the end of OS security support (DB17-5), app and tunnel-client images (DB18-5, DB19-5), the local-API certificate (DB03-5), and the outside accounts: mail key, domains, Cloudflare, Hetzner, GitHub and Gitea tokens (DH23-5, DH24-5, DH27-5, DH28-5, DH29-5, DH31-5, DH32-5). Decision D77 in `STATUS.md` asks if the product warns 14 days before. **Ruled 2026-11-11 13:17: yes, D77 (`09` §3 decision 298). Not built.** | OPEN — filed 2026-11-11 (end-dates list) | — | Fix shape (ruled, not built): the box reads its web certificate's date, the hub reads its tokens' dates, one operator alarm 14 days before. The outside accounts stay a list the operator reads (`documentation/audits/end-dates-list-2026-11-11/README.md`). | CC |
|
||||
| **R-1383** | Monitoring & notifications | P3 | **A job on a timer does not run, gives up, or loses its state at a restart, and nobody is told (23 answers).** Found 2026-11-11 (the Clock list, class W1, `documentation/audits/clock-list-2026-11-11/TABLE.md`; read in source, times measured read-only on three boxes). The four worst: the guest-power watchdog gives up with one journal line (CA07-7, CA07-8); a signed job that is refused or runs out stays silent, so an agent update never arrives (CA09-4, CA09-7); the hub's daily checks are skipped with no trace when the hub is down at their minute (CH02-4, CH02-8, CH11-4, CH16-4); an operator mail waiting for a retry is lost at a hub restart, and a household mail is never retried (CH04-4, CH04-7, CH04-8, CH03-7). The others: CA13-7, CC07-7, CC12-4, CC19-7, CC20-4, CH07-4, CH09-4, CH14-4, CH26-7, CH27-4, CH27-8. Beside R-1361 (a lost event) and R-1186 (the silent off-site skip); not the same gaps. **Ruled 2026-11-11 13:17: yes (`09` §3 decision 299). Not built.** | NARROWED — the four worst cases are built, not released. **2026-11-14 (night build):** the operator is told when a hub daily check's slot passed while the hub was down, when an operator mail was never sent, when a box did not take a signed job in two hours, when a box refused a signed job (with the cause), and when the guest-power watchdog gave up (`05` §16.6, `08-alarm-ladder.md`). Tests only; not deployed, not seen on a box. LEFT: the other 15 answers of the class; a household mail is still never retried (R-1361); the kernel clean-up and profile-refresh detail (next part of release 3). OPEN — **2026-11-14 (release 2a), two more things the hub does not tell:** (1) a kernel clean-up that removed kernels shows only as „cleaned <time ago>” in the System page's „Kernel step” cell — what was removed, kept and gained is stored and shown nowhere; (2) the security-profile refresh sends nothing to the hub at all, also when it restarted a failed service (it did on the N100). Both for release 3. Earlier: OPEN — filed 2026-11-11 (clock list) | — | Fix shape (ruled, not built): one hub alarm for the four worst cases (agent: watchdog give-up and refused job as events; hub: a start-up check „did my daily jobs run”, and the mail retry kept across a restart). | CC |
|
||||
| **R-1383** | Monitoring & notifications | P3 | **A job on a timer does not run, gives up, or loses its state at a restart, and nobody is told (23 answers).** Found 2026-11-11 (the Clock list, class W1, `documentation/audits/clock-list-2026-11-11/TABLE.md`; read in source, times measured read-only on three boxes). The four worst: the guest-power watchdog gives up with one journal line (CA07-7, CA07-8); a signed job that is refused or runs out stays silent, so an agent update never arrives (CA09-4, CA09-7); the hub's daily checks are skipped with no trace when the hub is down at their minute (CH02-4, CH02-8, CH11-4, CH16-4); an operator mail waiting for a retry is lost at a hub restart, and a household mail is never retried (CH04-4, CH04-7, CH04-8, CH03-7). The others: CA13-7, CC07-7, CC12-4, CC19-7, CC20-4, CH07-4, CH09-4, CH14-4, CH26-7, CH27-4, CH27-8. Beside R-1361 (a lost event) and R-1186 (the silent off-site skip); not the same gaps. **Ruled 2026-11-11 13:17: yes (`09` §3 decision 299). Not built.** | NARROWED — **2026-11-14 (night build, second part):** the two things release 2a did not tell are built, not released: the System page has a cell for the kernel clean-up (removed, kept, space gained) and one for the security-profile refresh (the kernel, how many profiles changed, any failed service it restarted) — `11` §5.11.1, §5.12. On the way a display defect was fixed: a clean-up hid a kernel that fell back the night before in the „Kernel step” cell. NARROWED — the four worst cases are built, not released. **2026-11-14 (night build):** the operator is told when a hub daily check's slot passed while the hub was down, when an operator mail was never sent, when a box did not take a signed job in two hours, when a box refused a signed job (with the cause), and when the guest-power watchdog gave up (`05` §16.6, `08-alarm-ladder.md`). Tests only; not deployed, not seen on a box. LEFT: the other 15 answers of the class; a household mail is still never retried (R-1361); the kernel clean-up and profile-refresh detail (next part of release 3). OPEN — **2026-11-14 (release 2a), two more things the hub does not tell:** (1) a kernel clean-up that removed kernels shows only as „cleaned <time ago>” in the System page's „Kernel step” cell — what was removed, kept and gained is stored and shown nowhere; (2) the security-profile refresh sends nothing to the hub at all, also when it restarted a failed service (it did on the N100). Both for release 3. Earlier: OPEN — filed 2026-11-11 (clock list) | — | Fix shape (ruled, not built): one hub alarm for the four worst cases (agent: watchdog give-up and refused job as events; hub: a start-up check „did my daily jobs run”, and the mail retry kept across a restart). | CC |
|
||||
| **R-1396** | Monitoring & notifications | P3 | **The agent now names WHY its trust in Proxmox is wrong, and the hub does not tell the operator yet.** Found 2026-11-14 night (release 2b, built). The agent's host report carries a `proxmox_trust` stanza (`mode`, `problem`, `detail`, the CA copy's end date; `03-host-agent.md` §12a). Two gaps: (1) the hub does not read the stanza — a box whose CA copy does not verify, ends within 30 days, or whose move failed is said only in the box's journal; (2) a box that is fully blind (neither the pinned certificate nor the CA copy works) sends NO host report, because the report starts with a call to Proxmox — that case reaches the operator only as „host stale” after 45 minutes, with no cause. With release 2b a pinned box heals itself at the first failed call, so (2) needs both ways to fail at once. | NARROWED — **2026-11-14 night: gap (1) is BUILT, not deployed** — the hub reads `proxmox_trust` and raises one operator-only `proxmox_trust_problem` per (box, cause), and `proxmox_trust_ok` at the recovery (hub `main` after v0.181.0; the wire-contract gate asked for the receiver in the same push as the sender). **LEFT: gap (2), the fully blind box.** Earlier: OPEN — filed 2026-11-14 | — | hub: an operator-only event from `proxmox_trust.problem` (raise once per cause, clear when it is empty), and the mode on the System page; agent: send a report without the Proxmox part when the failure is one of trust (a design choice: what the hub does with a report that has no guests) | CC |
|
||||
| **R-1377** | Monitoring & notifications | P4 | **Two endings tell nobody outside the page.** Found 2026-11-10 (the endings list, `documentation/audits/endings-list-2026-11-10/TABLE.md` endings EC03, EC15; read in source). **Orphan delete** of an app sends the hub a fresh report and no 'app removed' event (`internal/api/router.go:1150-1178`); the normal remove sends one. **Wipe of a drive** sends no event to the hub (`internal/web/storage_handlers.go:911-1000`). Not a member: retiring a drive — the hub does not read that field by ruling (decision 130, closed R-888). **Members (answers marked N):** EC03-6, EC15-6. | OPEN — filed 2026-11-10 (endings list) | — | Controller: send the 'app removed' event from orphan delete; decide in `08-alarm-ladder.md` whether a wipe is an operator event. | CC |
|
||||
|
||||
|
||||
@@ -3,6 +3,16 @@
|
||||
- `bundlefiles`: the line „bundle X holds the same files as the vouched Y” is logged once per pair (INFO), not at
|
||||
every view of the System page (it was 6 DEBUG lines per view, seen at the 0.181.0 deploy). No behaviour change.
|
||||
- **Release 3 („the hub tells you”), built 2026-11-14 night, NOT deployed. Every new alarm is operator-only.**
|
||||
- **The System page shows the kernel clean-up and the security-profile refresh (R-1383; `11` §5.11.1, §5.12).**
|
||||
Two new cells per box. „Kernel clean-up”: from the clean-up report's new `kernel_cleanup` object (kept in the stored
|
||||
report: `osupdates.Report.KernelCleanup`) — removed, kept, space gained, the names in the title; amber on
|
||||
refused / failed / left-over paths. „Security profiles”: from the host report's new `profile_refresh` stanza
|
||||
(`sysfacts.ProfileRefresh`) — kernel, how many profiles changed, any failed service it restarted; amber when the
|
||||
agent's last ask failed. **A defect fixed on the way:** the „Kernel step” cell showed the newest kernel-layer report,
|
||||
so a clean-up hid a kernel that fell back the night before; `KernelLineFor` now reads the newest step and the newest
|
||||
clean-up each from its own report. No new table, no new event. Tests `TestKernelLine_CleanupBesideTheStep`,
|
||||
`TestSystemCells_KernelCleanupAndSecurityProfiles`, `TestSystemPage_ShowsCleanupAndProfiles`; 13 mutations seen red
|
||||
(one did not run at first and was done again).
|
||||
- **The record of an off-site account outlives an untick (R-1375 part 1, D71, `09` §3 decision 291; `05` §14.1).**
|
||||
The config form rebuilds the whole config at a save, so unticking the off-site tier dropped the `offsite` block and
|
||||
the hub forgot the account; a later RESET or delete skipped it. Now `offsite.KeepAccountRecord` leaves
|
||||
|
||||
@@ -480,6 +480,12 @@ type KernelLine struct {
|
||||
NoticeAt time.Time // the newest day-before mail (any kernel)
|
||||
NoticeKver string
|
||||
Tonight bool
|
||||
// The newest clean-up of old kernels (R-1383, release 3), kept APART from the step: both are kernel-layer
|
||||
// reports, and before this the newest of the two was shown as „the step” — a clean-up hid a kernel that fell back.
|
||||
CleanupOutcome string // cleaned | refused | failed; "" = none reported
|
||||
CleanupAt time.Time
|
||||
CleanupReason string
|
||||
Cleanup *CleanupDetail // nil = an agent older than release 3 (the reason text carries the names)
|
||||
}
|
||||
|
||||
// KernelLineFor reads one box's kernel line.
|
||||
@@ -489,12 +495,33 @@ func (s *Service) KernelLineFor(hostID string) KernelLine {
|
||||
if b := s.KernelBlockFor(hostID); b != nil {
|
||||
l.Tonight = b.Tonight
|
||||
}
|
||||
if rep, _ := s.Store.LatestOSReport(hostID, LayerKernel); rep != nil {
|
||||
// The newest STEP and the newest CLEAN-UP, each from its own report (newest first; 100 covers months).
|
||||
reps, _ := s.Store.OSReportsDesc(hostID, LayerKernel, 100)
|
||||
haveStep, haveCleanup := false, false
|
||||
for _, rep := range reps {
|
||||
if haveStep && haveCleanup {
|
||||
break
|
||||
}
|
||||
var kr Report
|
||||
_ = json.Unmarshal([]byte(rep.ReportJSON), &kr)
|
||||
l.LastOutcome, l.LastKernel, l.LastAt, l.LastReason = rep.Outcome, kernelOf(kr), rep.ReceivedAt, kr.HealthReason
|
||||
if l.LastReason == "" && len(kr.Refused) > 0 {
|
||||
l.LastReason = string(kr.Refused)
|
||||
reason := kr.HealthReason
|
||||
if reason == "" && len(kr.Refused) > 0 {
|
||||
reason = string(kr.Refused)
|
||||
}
|
||||
if rep.Mode == ModeKernelCleanup {
|
||||
if !haveCleanup {
|
||||
haveCleanup = true
|
||||
l.CleanupOutcome, l.CleanupAt, l.CleanupReason = rep.Outcome, rep.ReceivedAt, reason
|
||||
var d CleanupDetail
|
||||
if len(kr.KernelCleanup) > 0 && json.Unmarshal(kr.KernelCleanup, &d) == nil {
|
||||
l.Cleanup = &d
|
||||
}
|
||||
}
|
||||
continue
|
||||
}
|
||||
if !haveStep {
|
||||
haveStep = true
|
||||
l.LastOutcome, l.LastKernel, l.LastAt, l.LastReason = rep.Outcome, kernelOf(kr), rep.ReceivedAt, reason
|
||||
}
|
||||
}
|
||||
if n, _ := s.Store.LatestKernelNotice(hostID); n != nil {
|
||||
|
||||
@@ -0,0 +1,77 @@
|
||||
package osupdates
|
||||
|
||||
import (
|
||||
"encoding/json"
|
||||
"strings"
|
||||
"testing"
|
||||
)
|
||||
|
||||
func cleanupReport(detail string) Report {
|
||||
r := Report{Layer: LayerKernel, Trigger: "night", Mode: ModeKernelCleanup, Outcome: "cleaned", Healthy: true,
|
||||
ReleaseID: "kernel-cleanup", HealthReason: "removed 2 old kernel package(s): …"}
|
||||
if detail != "" {
|
||||
r.KernelCleanup = json.RawMessage(detail)
|
||||
}
|
||||
return r
|
||||
}
|
||||
|
||||
// R-1383 (release 3). A clean-up and a kernel step are both kernel-layer reports. Before this the System page showed
|
||||
// the NEWEST of the two as „the step”: a clean-up the night after a kernel fell back replaced the amber „fell_back”
|
||||
// line with „cleaned”. The stored effect asserted: the step line still reads the step; the clean-up has its own
|
||||
// fields with what it removed, kept and gained; the detail survives the hub's re-marshal of the report; and the
|
||||
// clean-up changes nothing the kernel lane decides on (it names no kernel).
|
||||
// COMPANION RED-PROOFS (observed, audits/night-build-2026-11-14/B/redproof-hub-b3.txt).
|
||||
func TestKernelLine_CleanupBesideTheStep(t *testing.T) {
|
||||
f := newFix(t)
|
||||
f.hostWithPendingKernel(t, "hp")
|
||||
f.laneFacts(t, "hp", "c-hp", kOld, "fell_back", kNew)
|
||||
f.ingest(t, "hp", kreport("fell_back", "boot", false))
|
||||
dueBefore, whyBefore := f.s.KernelDue("hp")
|
||||
if l := f.s.KernelLineFor("hp"); l.CleanupOutcome != "" || l.LastOutcome != "fell_back" {
|
||||
t.Fatalf("before any clean-up: %+v", l)
|
||||
}
|
||||
const detail = `{"removed":["proxmox-kernel-7.0.14-20-pve-signed","proxmox-kernel-7.0.2-6-pve-signed"],"kept":["7.0.14-22-pve","7.0.14-26-pve"],"bytes_gained":2147483648,"leftovers":0}`
|
||||
f.now = f.now.Add(24 * 60 * 60 * 1e9)
|
||||
rep := cleanupReport(detail)
|
||||
rep.RunID = "cleanup-1"
|
||||
f.ingest(t, "hp", rep)
|
||||
|
||||
l := f.s.KernelLineFor("hp")
|
||||
if l.LastOutcome != "fell_back" || l.LastKernel != kNew {
|
||||
t.Fatalf("the clean-up HID the step: the step line reads %q for %q, want fell_back for %s", l.LastOutcome, l.LastKernel, kNew)
|
||||
}
|
||||
if l.CleanupOutcome != "cleaned" || l.Cleanup == nil || len(l.Cleanup.Removed) != 2 || len(l.Cleanup.Kept) != 2 ||
|
||||
l.Cleanup.BytesGained == nil || *l.Cleanup.BytesGained != 2147483648 || l.Cleanup.Removed[0] != "proxmox-kernel-7.0.14-20-pve-signed" {
|
||||
t.Fatalf("the clean-up's own fields: outcome %q detail %+v", l.CleanupOutcome, l.Cleanup)
|
||||
}
|
||||
// the detail is in the STORED report (Ingest re-marshals the struct: a field the struct lacks is lost)
|
||||
stored, _ := f.s.Store.LatestOSReport("hp", LayerKernel)
|
||||
if stored == nil || stored.Mode != ModeKernelCleanup || !strings.Contains(stored.ReportJSON, `"kernel_cleanup":{"removed":["proxmox-kernel-7.0.14-20-pve-signed"`) {
|
||||
t.Fatalf("the stored report lost the detail: %+v", stored)
|
||||
}
|
||||
// and it is not a step for any kernel: the lane's verdict did not move
|
||||
var kr Report
|
||||
_ = json.Unmarshal([]byte(stored.ReportJSON), &kr)
|
||||
if k := kernelOf(kr); k != "" {
|
||||
t.Fatalf("the clean-up report reads as a step for kernel %q", k)
|
||||
}
|
||||
if due, why := f.s.KernelDue("hp"); due != dueBefore || why != whyBefore {
|
||||
t.Fatalf("the clean-up moved the kernel lane: due %q→%q, why %q→%q", dueBefore, due, whyBefore, why)
|
||||
}
|
||||
// a later step is the step line again, and the clean-up line stays
|
||||
f.now = f.now.Add(24 * 60 * 60 * 1e9)
|
||||
st := kreport("applied", "boot", true)
|
||||
st.RunID = "step-2"
|
||||
f.ingest(t, "hp", st)
|
||||
if l := f.s.KernelLineFor("hp"); l.LastOutcome != "applied" || l.CleanupOutcome != "cleaned" || l.Cleanup == nil {
|
||||
t.Fatalf("after a later step: %+v", l)
|
||||
}
|
||||
// an agent of release 2a sends no detail: the outcome and the reason text are still shown, the detail is nil
|
||||
f2 := newFix(t)
|
||||
old := cleanupReport("")
|
||||
old.RunID = "cleanup-old"
|
||||
f2.ingest(t, "hp", old)
|
||||
if l := f2.s.KernelLineFor("hp"); l.CleanupOutcome != "cleaned" || l.Cleanup != nil || !strings.Contains(l.CleanupReason, "removed 2 old kernel") || l.LastOutcome != "" {
|
||||
t.Fatalf("a clean-up without detail (agent 0.174.0): %+v", l)
|
||||
}
|
||||
}
|
||||
@@ -119,8 +119,23 @@ type Report struct {
|
||||
OOMCheck json.RawMessage `json:"oom_check,omitempty"`
|
||||
// Kernel (agent v0.152.0, R-836): the kernel layer's view {running, default, flag, phase, from, to, …}, kept verbatim.
|
||||
Kernel json.RawMessage `json:"kernel,omitempty"`
|
||||
// KernelCleanup (agents of release 3, R-1383): ONLY on a mode kernel-cleanup report — what the clean-up removed,
|
||||
// kept and gained. Kept verbatim (Ingest re-marshals this struct: a field that is not here is lost). It is NOT read
|
||||
// by kernelOf: a clean-up is not a step for any kernel. Pinned by TestKernelLine_CleanupBesideTheStep.
|
||||
KernelCleanup json.RawMessage `json:"kernel_cleanup,omitempty"`
|
||||
}
|
||||
|
||||
// CleanupDetail is the clean-up's result (felhom-agent osupdate.CleanupDetail, field-exact).
|
||||
type CleanupDetail struct {
|
||||
Removed []string `json:"removed"`
|
||||
Kept []string `json:"kept"`
|
||||
BytesGained *int64 `json:"bytes_gained"`
|
||||
Leftovers int `json:"leftovers"`
|
||||
}
|
||||
|
||||
// ModeKernelCleanup is the mode of the kernel-layer report that is NOT a kernel step.
|
||||
const ModeKernelCleanup = "kernel-cleanup"
|
||||
|
||||
// PendingPkg is one update the sources offer.
|
||||
type PendingPkg struct {
|
||||
Name string `json:"name"`
|
||||
|
||||
@@ -129,11 +129,26 @@ type System struct {
|
||||
DiskTrim *DiskTrim
|
||||
// LineTest is the top-level `line_test` stanza (R-1247), read like DiskTrim. nil = the agent sent none.
|
||||
LineTest *LineTest
|
||||
// ProfileRefresh is the top-level `profile_refresh` stanza (R-1383, agents of release 3), read like DiskTrim.
|
||||
// nil = the agent sent none (an older agent, a BYO host, or a box that never refreshed).
|
||||
ProfileRefresh *ProfileRefresh
|
||||
}
|
||||
|
||||
// ProfileRefresh is the box's last security-profile refresh (`11` §5.12; felhom-agent osupdate.ProfileRefreshStatus,
|
||||
// field-exact): from the root wrapper's own record, plus how the agent's last ask ended.
|
||||
type ProfileRefresh struct {
|
||||
Kernel string `json:"kernel"`
|
||||
At string `json:"at"`
|
||||
Rewritten int `json:"rewritten"`
|
||||
Restarted []string `json:"restarted"`
|
||||
LastAsk string `json:"last_ask"` // refreshed | not_needed | failed | refused | no_answer
|
||||
LastAskAt string `json:"last_ask_at"`
|
||||
}
|
||||
|
||||
type wire struct {
|
||||
DiskTrim *DiskTrim `json:"guest_disk_trim"`
|
||||
LineTest *LineTest `json:"line_test"`
|
||||
DiskTrim *DiskTrim `json:"guest_disk_trim"`
|
||||
LineTest *LineTest `json:"line_test"`
|
||||
Profile *ProfileRefresh `json:"profile_refresh"`
|
||||
System *struct {
|
||||
PVEVersion string `json:"pve_version"`
|
||||
KernelVersion string `json:"kernel_version"`
|
||||
@@ -162,6 +177,7 @@ func Parse(reportJSON string) System {
|
||||
return out
|
||||
}
|
||||
out.DiskTrim, out.LineTest = w.DiskTrim, w.LineTest
|
||||
out.ProfileRefresh = w.Profile
|
||||
if w.System == nil {
|
||||
return out
|
||||
}
|
||||
|
||||
@@ -38,6 +38,7 @@ type systemRow struct {
|
||||
Held, RebootSince, KernelPanic, Oops cell
|
||||
CrashRestarts24h, Guard cell
|
||||
KernelDefault, KernelStep cell // R-836: the GRUB default kernel; the kernel lane's step
|
||||
KernelCleanup, Profiles cell // R-1383: the clean-up of old kernels; the security-profile refresh
|
||||
Bundle cell // R-840: the root-owned config bundle
|
||||
Agent cell // R-530: the box's agent against the vouched one
|
||||
// guest
|
||||
@@ -115,6 +116,71 @@ func kernelCells(f sysfacts.System, kl osupdates.KernelLine, now time.Time) (dfl
|
||||
return dflt, step
|
||||
}
|
||||
|
||||
// cleanupCell is the System page's „Kernel clean-up” cell (R-1383, release 3; `11` §5.11.1): the newest clean-up of
|
||||
// old kernels — how many it removed and kept and how much space it gained, the names in the title. Amber when it was
|
||||
// refused or failed, or left paths of a removed kernel behind. A box tells the hub only when a clean-up removed
|
||||
// something, was refused, or failed — so „—” is the normal reading for a box with nothing to remove.
|
||||
func cleanupCell(kl osupdates.KernelLine, now time.Time) cell {
|
||||
if kl.CleanupOutcome == "" {
|
||||
return cell{Text: "—", Title: "no clean-up of old kernels reported (a box reports one only when it removed kernels, was refused, or failed)"}
|
||||
}
|
||||
when := ago(kl.CleanupAt, now)
|
||||
switch kl.CleanupOutcome {
|
||||
case "cleaned":
|
||||
d := kl.Cleanup
|
||||
if d == nil {
|
||||
return cell{Text: "cleaned " + when, Title: kl.CleanupReason}
|
||||
}
|
||||
gained := "space gained unknown"
|
||||
if d.BytesGained != nil {
|
||||
gained = fmt.Sprintf("%.1f GiB gained", float64(*d.BytesGained)/(1<<30))
|
||||
}
|
||||
c := cell{Text: fmt.Sprintf("removed %d, kept %d · %s · %s", len(d.Removed), len(d.Kept), gained, when),
|
||||
Title: "removed: " + strings.Join(d.Removed, ", ") + " — kept: " + strings.Join(d.Kept, ", ")}
|
||||
if d.Leftovers > 0 {
|
||||
c.Class = "warn"
|
||||
c.Text += fmt.Sprintf(" · %d left-over path(s)", d.Leftovers)
|
||||
}
|
||||
return c
|
||||
}
|
||||
return cell{Text: kl.CleanupOutcome + " " + when, Class: "warn", Title: kl.CleanupReason}
|
||||
}
|
||||
|
||||
// profileCell is the „Security profiles” cell (R-1383, release 3; `11` §5.12): the box's last refresh of its compiled
|
||||
// AppArmor profiles — the kernel it ran on, how many compiled profiles changed, and any FAILED service it restarted
|
||||
// (on the N100 that was the time service). Amber when the agent's last ask failed or got no answer.
|
||||
func profileCell(f sysfacts.System, now time.Time) cell {
|
||||
p := f.ProfileRefresh
|
||||
if p == nil {
|
||||
return cell{Text: "—", Title: "the box reports no security-profile refresh (an agent older than release 3, a BYO host, or no refresh yet)"}
|
||||
}
|
||||
var parts []string
|
||||
if p.At != "" {
|
||||
at, _ := time.Parse(time.RFC3339, p.At)
|
||||
parts = append(parts, strings.TrimSpace(p.Kernel+" · "+fmt.Sprintf("%d rewritten", p.Rewritten)+" · "+ago(at, now)))
|
||||
if len(p.Restarted) > 0 {
|
||||
parts = append(parts, "restarted "+strings.Join(p.Restarted, ", "))
|
||||
}
|
||||
}
|
||||
c := cell{Title: "last ask: " + p.LastAsk}
|
||||
if p.LastAsk == "" {
|
||||
c.Title = "from the box's own record (the agent has not asked since it started)"
|
||||
}
|
||||
switch p.LastAsk {
|
||||
case "failed", "no_answer":
|
||||
askAt, _ := time.Parse(time.RFC3339, p.LastAskAt)
|
||||
parts = append(parts, "last ask "+strings.ToUpper(p.LastAsk)+" "+ago(askAt, now))
|
||||
c.Class = "warn"
|
||||
case "refused":
|
||||
c.Title = "last ask: refused (an older root wrapper that does not know the mode, or a BYO host)"
|
||||
}
|
||||
if len(parts) == 0 {
|
||||
parts = append(parts, "no refresh yet")
|
||||
}
|
||||
c.Text = strings.Join(parts, " · ")
|
||||
return c
|
||||
}
|
||||
|
||||
// agentCell is the "Agent" cell (R-530, hub v0.135.0): the box's agent against the vouched one, how far behind and
|
||||
// since when. Amber while behind; red from the alarm's wait on (the operator alarm fires then). An unreadable
|
||||
// version is "unknown", never a guess; nothing vouched → the version alone.
|
||||
|
||||
@@ -0,0 +1,92 @@
|
||||
package web
|
||||
|
||||
import (
|
||||
"strings"
|
||||
"testing"
|
||||
"time"
|
||||
|
||||
"gitea.dooplex.hu/admin/felhom-hub/internal/osupdates"
|
||||
"gitea.dooplex.hu/admin/felhom-hub/internal/sysfacts"
|
||||
)
|
||||
|
||||
// R-1383 (release 3): the two new cells of the System page, from what a box really sends.
|
||||
// COMPANION RED-PROOFS (observed, audits/night-build-2026-11-14/B/redproof-hub-b3.txt).
|
||||
func TestSystemCells_KernelCleanupAndSecurityProfiles(t *testing.T) {
|
||||
now := time.Date(2026, 11, 15, 6, 0, 0, 0, time.UTC)
|
||||
gained := int64(6442450944)
|
||||
// --- the clean-up ---
|
||||
if c := cleanupCell(osupdates.KernelLine{}, now); c.Text != "—" || c.Class != "" {
|
||||
t.Errorf("no clean-up reported: %+v (a box with nothing to remove reports none — not a fault)", c)
|
||||
}
|
||||
kl := osupdates.KernelLine{CleanupOutcome: "cleaned", CleanupAt: now.Add(-3 * time.Hour), CleanupReason: "removed 6 …",
|
||||
Cleanup: &osupdates.CleanupDetail{Removed: []string{"proxmox-kernel-7.0.2-6-pve-signed", "b", "c", "d", "e", "f"},
|
||||
Kept: []string{"7.0.14-26-pve", "7.0.14-28-pve"}, BytesGained: &gained}}
|
||||
c := cleanupCell(kl, now)
|
||||
for _, want := range []string{"removed 6, kept 2", "6.0 GiB gained", "3"} {
|
||||
if !strings.Contains(c.Text, want) {
|
||||
t.Errorf("clean-up cell %q lacks %q", c.Text, want)
|
||||
}
|
||||
}
|
||||
if c.Class != "" || !strings.Contains(c.Title, "proxmox-kernel-7.0.2-6-pve-signed") || !strings.Contains(c.Title, "kept: 7.0.14-26-pve, 7.0.14-28-pve") {
|
||||
t.Errorf("clean-up cell = %+v, want no colour and the names in the title", c)
|
||||
}
|
||||
kl.Cleanup.Leftovers = 2
|
||||
if c := cleanupCell(kl, now); c.Class != "warn" || !strings.Contains(c.Text, "2 left-over path(s)") {
|
||||
t.Errorf("left-over paths must be amber and named: %+v", c)
|
||||
}
|
||||
kl.Cleanup = nil // an agent of release 2a
|
||||
if c := cleanupCell(kl, now); !strings.HasPrefix(c.Text, "cleaned ") || c.Title != "removed 6 …" {
|
||||
t.Errorf("a clean-up without detail: %+v", c)
|
||||
}
|
||||
for _, bad := range []string{"refused", "failed"} {
|
||||
if c := cleanupCell(osupdates.KernelLine{CleanupOutcome: bad, CleanupAt: now.Add(-time.Hour), CleanupReason: "K4: the phase is judging"}, now); c.Class != "warn" || !strings.HasPrefix(c.Text, bad) || c.Title != "K4: the phase is judging" {
|
||||
t.Errorf("%s clean-up: %+v, want amber with the reason", bad, c)
|
||||
}
|
||||
}
|
||||
// --- the security profiles: parsed from a host report, as the page gets it ---
|
||||
if c := profileCell(sysfacts.Parse(`{"host_id":"x"}`), now); c.Text != "—" || c.Class != "" {
|
||||
t.Errorf("no stanza: %+v", c)
|
||||
}
|
||||
f := sysfacts.Parse(`{"profile_refresh":{"kernel":"7.0.14-28-pve","at":"2026-11-14T11:30:11Z","rewritten":2,"restarted":["chrony.service"],"last_ask":"refreshed","last_ask_at":"2026-11-14T11:30:11Z"}}`)
|
||||
c = profileCell(f, now)
|
||||
for _, want := range []string{"7.0.14-28-pve", "2 rewritten", "restarted chrony.service"} {
|
||||
if !strings.Contains(c.Text, want) {
|
||||
t.Errorf("profile cell %q lacks %q", c.Text, want)
|
||||
}
|
||||
}
|
||||
if c.Class != "" {
|
||||
t.Errorf("a good refresh must have no colour: %+v", c)
|
||||
}
|
||||
for _, ask := range []string{"failed", "no_answer"} {
|
||||
f = sysfacts.Parse(`{"profile_refresh":{"kernel":"7.0.14-28-pve","at":"2026-11-14T11:30:11Z","rewritten":2,"last_ask":"` + ask + `","last_ask_at":"2026-11-15T05:00:00Z"}}`)
|
||||
if c := profileCell(f, now); c.Class != "warn" || !strings.Contains(c.Text, "last ask "+strings.ToUpper(ask)) || !strings.Contains(c.Text, "2 rewritten") {
|
||||
t.Errorf("last ask %s: %+v, want amber, the failed ask AND the older record", ask, c)
|
||||
}
|
||||
}
|
||||
f = sysfacts.Parse(`{"profile_refresh":{"last_ask":"refused","last_ask_at":"2026-11-15T05:00:00Z"}}`)
|
||||
if c := profileCell(f, now); c.Class != "" || c.Text != "no refresh yet" || !strings.Contains(c.Title, "older root wrapper") {
|
||||
t.Errorf("a refused ask (an older wrapper) is not a fault: %+v", c)
|
||||
}
|
||||
}
|
||||
|
||||
// Both cells are on the rendered page, under their names, and a failed ask reaches „Needs attention”.
|
||||
func TestSystemPage_ShowsCleanupAndProfiles(t *testing.T) {
|
||||
in := fixtureInput(true)
|
||||
gained := int64(1073741824)
|
||||
in.KernelLines = map[string]osupdates.KernelLine{"demo-hp-d4e5f6": {CleanupOutcome: "cleaned", CleanupAt: in.Now.Add(-2 * time.Hour),
|
||||
Cleanup: &osupdates.CleanupDetail{Removed: []string{"proxmox-kernel-7.0.14-20-pve-signed"}, Kept: []string{"7.0.14-23-pve"}, BytesGained: &gained}}}
|
||||
f := in.Facts["demo-hp-d4e5f6"]
|
||||
f.ProfileRefresh = &sysfacts.ProfileRefresh{Kernel: "7.0.14-23-pve", At: in.Now.Add(-5 * time.Hour).UTC().Format(time.RFC3339), Rewritten: 1,
|
||||
Restarted: []string{"chrony.service"}, LastAsk: "failed", LastAskAt: in.Now.Add(-time.Hour).UTC().Format(time.RFC3339)}
|
||||
in.Facts["demo-hp-d4e5f6"] = f
|
||||
page := renderSystem(t, in)
|
||||
for _, want := range []string{">Kernel clean-up</dt>", ">Security profiles</dt>", "removed 1, kept 1", "1.0 GiB gained",
|
||||
"restarted chrony.service", "last ask FAILED"} {
|
||||
if !strings.Contains(page, want) {
|
||||
t.Errorf("the System page lacks %q", want)
|
||||
}
|
||||
}
|
||||
if att := sysSection(page, "attention"); !strings.Contains(att, "security profiles") {
|
||||
t.Errorf("a failed ask of the profile refresh is not under „Needs attention”")
|
||||
}
|
||||
}
|
||||
@@ -144,7 +144,7 @@ func TestSystemPage_EveryItemStillOnThePage(t *testing.T) {
|
||||
// per box, in the box panel (every column of the old wide table)
|
||||
`href="/hosts/demo-hp-d4e5f6"`, "Demo HP", `action="/os/ring/demo-hp-d4e5f6"`, `action="/os/enabled/tester1-0f1e2d"`,
|
||||
">Tunnel</dt>", ">Proxmox</dt>", ">Kernel (running)</dt>", ">Kernel (next boot)</dt>", ">Kernel (default)</dt>",
|
||||
">Kernel step</dt>", ">Debian</dt>", ">Felhom release</dt>", ">Pending</dt>", ">Not covered</dt>", ">Held</dt>",
|
||||
">Kernel step</dt>", ">Kernel clean-up</dt>", ">Security profiles</dt>", ">Debian</dt>", ">Felhom release</dt>", ">Pending</dt>", ">Not covered</dt>", ">Held</dt>",
|
||||
">Reboot needed</dt>", ">kernel.panic</dt>", ">Oops</dt>", ">Crash restarts 24 h</dt>", ">Crash guard</dt>",
|
||||
">Root files</dt>", ">Agent</dt>", ">Guest Debian</dt>", ">Restart needed</dt>", ">Last disk trim</dt>",
|
||||
">Docker</dt>", ">containerd</dt>", ">live-restore</dt>", ">Docker release</dt>", ">Last OS leg</dt>",
|
||||
|
||||
@@ -52,6 +52,7 @@ func buildSystemPage(in systemInput) map[string]interface{} {
|
||||
for i := range rows {
|
||||
id := rows[i].HostID
|
||||
rows[i].KernelDefault, rows[i].KernelStep = kernelCells(in.Facts[id], in.KernelLines[id], in.Now)
|
||||
rows[i].KernelCleanup, rows[i].Profiles = cleanupCell(in.KernelLines[id], in.Now), profileCell(in.Facts[id], in.Now)
|
||||
rows[i].Bundle = bundleCell(in.Facts[id], in.VouchedAgent, in.VouchedBundle, in.BundleSame[id], in.BundleSince[id], in.BundleAfter, in.Now)
|
||||
rows[i].Agent = agentCell(in.Agents[id], in.VouchedAgent, in.AgentSince[id], in.AgentAfter, in.Now)
|
||||
rows[i].Controller = unknownCell(in.Controllers[id])
|
||||
@@ -94,7 +95,8 @@ func (r *systemRow) labelled() []struct {
|
||||
}
|
||||
return []lc{
|
||||
{"tunnel", r.Tunnel}, {"Proxmox version", r.PVE}, {"running kernel", r.KernelRunning}, {"next-boot kernel", r.KernelNextBoot},
|
||||
{"default kernel", r.KernelDefault}, {"kernel step", r.KernelStep}, {"host Debian", r.HostDebian},
|
||||
{"default kernel", r.KernelDefault}, {"kernel step", r.KernelStep}, {"kernel clean-up", r.KernelCleanup},
|
||||
{"security profiles", r.Profiles}, {"host Debian", r.HostDebian},
|
||||
{"host updates not covered", r.HostNotCovered}, {"held packages", r.Held}, {"host restart", r.RebootSince},
|
||||
{"kernel.panic", r.KernelPanic}, {"kernel oops", r.Oops}, {"crash restarts", r.CrashRestarts24h}, {"crash guard", r.Guard},
|
||||
{"root files", r.Bundle}, {"agent", r.Agent}, {"controller", r.Controller}, {"guest Debian", r.GuestDebian},
|
||||
|
||||
@@ -185,6 +185,8 @@
|
||||
<dt>Kernel (next boot)</dt>{{template "sys_dd" .KernelNextBoot}}
|
||||
<dt title="The kernel GRUB boots normally (R-836). Amber: a one-shot flag names another kernel for the next boot only.">Kernel (default)</dt>{{template "sys_dd" .KernelDefault}}
|
||||
<dt title="The kernel lane (R-836): the newest step, the kernel the box is due, and whether its household was told for tonight (no mail, no step).">Kernel step</dt>{{template "sys_dd" .KernelStep}}
|
||||
<dt title="The newest clean-up of old kernels (R-1368): how many it removed and kept, and the space gained. A box reports one only when it removed kernels, was refused, or failed.">Kernel clean-up</dt>{{template "sys_dd" .KernelCleanup}}
|
||||
<dt title="The box's last refresh of its compiled security (AppArmor) profiles (R-1388): the kernel it ran on, how many changed, and a failed service it restarted.">Security profiles</dt>{{template "sys_dd" .Profiles}}
|
||||
<dt>Debian</dt>{{template "sys_dd" .HostDebian}}
|
||||
<dt>Felhom release</dt>{{template "sys_dd" .HostRelease}}
|
||||
<dt>Pending</dt>{{template "sys_dd" .HostPending}}
|
||||
|
||||
Reference in new issue
Block a user