22 lines
1.7 KiB
Markdown
22 lines
1.7 KiB
Markdown
# REPORT — review round 2 (2026-10-24, unattended): two small fixes, commit only
|
||
|
||
**What:** found by the review round's readers and verified at `file:line` by the main session (felhom.eu
|
||
`documentation/audits/review-round-2-2026-10-24/`). No release; both ride the next normal train (next v0.343.0).
|
||
|
||
1. **A media restart no longer starts an app the household stopped (R-721).** `restartMediaApps` and
|
||
`mediaSafeRemoval` recreated every media app (`RestartStack` = `up -d --force-recreate`), skipping only held ones.
|
||
Now both take `stacks.MediaAppsToRecreate`, which leaves out an app whose recorded intent is „stopped" (logged). Its
|
||
override is already written, so its next start sees the drives. Tests: `TestMediaAppsToRecreate_SkipsAppsTheHouseholdStopped`
|
||
(red with the rule off) and `TestR2_MediaRecreateLoopsSkipStoppedApps` (source pin of the two loops; red with
|
||
`s.mediaApps()` back in the safe removal).
|
||
2. **The file manager's header name file appears whole (R-1100).** `LoadOrCreateFileBrowserSSOHeader` created the file
|
||
empty and wrote it after; a parallel caller read "" and got an error. Measured on clean `main` `321df1f`: 44 of 300
|
||
runs of the existing parallel-writers check failed (4 of 50 under `-race`). Now: temp file, sync, hard link into place
|
||
— 0 of 300, 0 of 50 under `-race`.
|
||
|
||
`go vet ./...` and `go test ./...` green. Design docs read: `15-media-library.md` §10–11 (the restart), `01` §5 / `02`
|
||
(the file manager sign-in).
|
||
|
||
**Docs (same session):** `REUSE.md` — D22 released in v0.338.0; the `recordInstalledImages` callers; a row for the
|
||
stray-copy seams. felhom.eu `documentation/audits/review-round-2-2026-10-24/EDITS.md` lists every edit.
|