fix(R-1187 b): refuse a link whose parent path passes through a link; born keys listed; psql --set
gates / gates (push) Successful in 1m7s
gates / gates (push) Successful in 1m7s
Second automated security review finding, red-proved. The go-parity and docker -v gates that refused the push are green.
This commit is contained in:
1 parent
106325de43
commit
f24233c829
4 files changed
+70
-3
No files matched your search
@@ -37,6 +37,10 @@ hub answers 400 to both and nothing else changes.
|
||||
**Follow-up (the automated security review, same night):** the import writes only through `os.Root`, so no entry is
|
||||
written through a link already in the folder that points outside; such an entry is refused and listed. Test
|
||||
`TestR1187b_NoWriteThroughALinkThatLeavesTheFolder`, red-proved (the file landed outside with plain `os.Create`).
|
||||
A second review finding: a link entry whose parent path passes through a link („a" → „.", then „a/b/l" → „../..")
|
||||
passed the path-text check while really pointing above the folder — now refused and listed
|
||||
(`TestR1187b_NoLinkThroughALinkedParent`, red-proved). psql takes `--set=ON_ERROR_STOP=1` (the `-v` short form tripped
|
||||
the docker `-v` gate); the four new message keys are listed in `scripts/i18n_go_keys.json` as born keys.
|
||||
- **R-1298:** the hold report skips an install's hold (`unhealthy_stop`, `update_failed`, `putback_pending`) of an app that
|
||||
is not installed (`holdreport.Reporter.SetInstalled`: the app's `app.yaml` exists — an unreadable one still counts,
|
||||
R-1220) and reports it cleared if it was reported; a restore hold is always reported (R-379). 9202's four orphan holds
|
||||
|
||||
Reference in new issue
Block a user