R-130: the local-lvm minimum is named as what it does — a recommendation that warns
HARD_MIN_LVM_GIB -> RECOMMENDED_MIN_LVM_GIB; the warning says the install continues and to proceed only with deliberately sized grows (the day0-install runbook's wording). Behaviour unchanged. scripts/test_hostinstall.py: test_lvm_minimum_is_named_as_what_it_does. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0159rPz1ZhFKsS53msqPYxtS
This commit is contained in:
@@ -345,7 +345,11 @@ PVE_SCRATCH_VMID_MAX=990009
|
||||
STATE_DIR="${FELHOM_INSTALL_STATE_DIR:-/var/lib/felhom-install}"
|
||||
STATE_FILE="${STATE_DIR}/state.json"
|
||||
AGENT_CONFIG="" # resolved in preflight
|
||||
HARD_MIN_LVM_GIB=120 # a useful appliance won't fit below this on local-lvm
|
||||
# R-130: a RECOMMENDATION, not a floor — the install proceeds below it (runbooks/day0-install.md:
|
||||
# "proceed only if you sized the grows deliberately"; a 75 GiB box installed fully, 2026-07-03). The
|
||||
# old name called it a hard floor while the check only warned. No measured floor exists. Pinned by
|
||||
# scripts/test_hostinstall.py (test_lvm_minimum_is_named_as_what_it_does).
|
||||
RECOMMENDED_MIN_LVM_GIB=120
|
||||
|
||||
# Runtime carriers (never logged)
|
||||
PASSPHRASE=""
|
||||
@@ -1877,7 +1881,7 @@ step_preflight() {
|
||||
free_gib=$(lvs --noheadings --units g -o lv_size,data_percent /dev/pve/data 2>/dev/null | awk '{gsub(/[^0-9.]/,"",$1); used=$2; print int($1*(100-used)/100)}' 2>/dev/null || echo 0)
|
||||
if [[ "${free_gib:-0}" -gt 0 ]]; then
|
||||
log_info " local-lvm free: ~${free_gib} GiB"
|
||||
[[ "$free_gib" -ge "$HARD_MIN_LVM_GIB" ]] || log_warn "local-lvm free ~${free_gib} GiB < hard min ${HARD_MIN_LVM_GIB} GiB"
|
||||
[[ "$free_gib" -ge "$RECOMMENDED_MIN_LVM_GIB" ]] || log_warn "local-lvm free ~${free_gib} GiB is below the recommended ${RECOMMENDED_MIN_LVM_GIB} GiB — the install continues; proceed only if you sized the grows deliberately"
|
||||
else
|
||||
log_warn " could not read local-lvm free space (continuing)"
|
||||
fi
|
||||
|
||||
Reference in New Issue
Block a user