hub (unreleased): a give-up mark keeps its slot for a week after the box stops listing the guest (the commit's security review); docs for the CA copy's changeover
gates / gates (push) Successful in 2m10s

Claude-Session: https://claude.ai/code/session_0159rPz1ZhFKsS53msqPYxtS
This commit is contained in:
admin committed 2026-11-14 19:20:46 +01:00
1 parent 78c08dc909
commit d2683b28d3
7 files changed
+82 -12

No files matched your search

+5 -1
View File
@@ -1007,7 +1007,11 @@ a config that holds both is a pinned box — the agent treats it as „not moved
certificates.** The root step writes the new root FIRST and keeps the copy's previous first certificate behind it:
the copy is replaced before anything can be proven with the new root, and Proxmox serves its old certificate until
pveproxy is reloaded — without the old root, an agent that restarted in that window had no root that verified the
served certificate and no fingerprint. Never more than two; an ended one verifies nothing. (b) **One run at a time**
served certificate and no fingerprint. **Only for the changeover:** at every later run the step makes one handshake to
the local Proxmox (`127.0.0.1:8006`) with the new root alone and drops the previous root as soon as that verifies, or
when the previous root is no longer a CA that has not ended. The copy is compared exactly, never by its start. By
hand, to drop an old root at once (a root that was changed because it leaked): delete the copy; the next run writes
the new root alone. Checked with the real openssl and a real TLS server in the wrapper's tests. (b) **One run at a time**
(`Ensure` is called from the start, the timer, a failed collect and a bundle install), and the root step has a
90-second deadline — it runs on the daemon's start path and inside the report loop. (c) **One lock for every writer
of `agent.json`** in the process (`config.FileMu`: the trust move, the PBS seed, the backup-target move): each reads
@@ -731,7 +731,8 @@ the same report lists (not running), 16 entries at most.
**The mails (after review, 2026-11-14):** each of these events tells one thing once and keeps a mark, so its mail
cooldown is keyed per thing (`notify.perSubjectCooldownEvents`) — with the plain per-type key the second job, guest or
skipped check inside the hour was suppressed and never told. The lost-mail scan tells only mails that failed before
this hub process started (one that failed since still has its retry). One box holds at most 8 give-up marks.
this hub process started (one that failed since still has its retry). One box holds at most 8 give-up marks, and the
mark of a guest the box stops listing keeps its slot for a week.
**Not proven on a box or a deployed hub:** all five. The tests use fakes for the mail service and the real gate
and verifier for the signed jobs (`audits/night-build-2026-11-14/B/`, 43 mutations seen red).