REPORT: hub v0.43.1 deployed (Git Sync optional hint; pairs with controller v0.112.0)
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01PSK5g6qYLknKj8u3QAFEr6
This commit is contained in:
@@ -2,86 +2,22 @@
|
||||
|
||||
> **Overwrite** this file with a summary of the most recent task only (uniform with the other repos; not cumulative). The cumulative hub history lives in [hub/CHANGELOG.md](hub/CHANGELOG.md); the scripts history lives in [scripts/CHANGELOG.md](scripts/CHANGELOG.md).
|
||||
|
||||
## TASK — hub v0.43.0: remote app-log diagnostics (copyable issues + context + on-demand log tails) — 2026-07-10
|
||||
## TASK — hub v0.43.1: Git Sync form hint (credentials optional) — 2026-07-10
|
||||
|
||||
**Pairs with controller v0.111.0.** Deployed via GitOps (image 0.43.0, manifest bump, ArgoCD hard-refresh
|
||||
+ sync): **Synced/Healthy**, rollout complete, clean startup log. Motivated live: Peti's CWA issue was
|
||||
tooltip-only unreadable and context-free, with no remote way to see the app's logs.
|
||||
**Pairs with controller v0.112.0 (anonymous registry self-update — full report in
|
||||
felhom-controller/REPORT.md).** One template string, no behavior change: the config editor's Git Sync
|
||||
section looked load-bearing, but the credentials matter only for a PRIVATE app catalog — since
|
||||
controller v0.112.0 version discovery + self-update work without them (anonymous Docker v2 token flow).
|
||||
|
||||
### What shipped (Parts A, C, D-hub, F, G, H of the spec)
|
||||
- `config_form.html` Git Sync section gains the hint: **"Opcionális — csak privát
|
||||
alkalmazás-katalógushoz. A verziófrissítés enélkül is működik."**
|
||||
- Deployed via GitOps: image `0.43.1`, manifest bump, ArgoCD sync → Synced/Healthy, rollout complete.
|
||||
- Green gate green; render tests cover template parse.
|
||||
|
||||
- **A — readable/copyable issues** (`app_detail.html`): Known Issues rows click-to-expand — full message
|
||||
in a wrapping monospace `<pre>` + Copy button (clipboard API + execCommand fallback); fingerprint,
|
||||
severity, first/last seen, and the explicit affected-customers list (linked) in the body. Tooltip
|
||||
truncation killed.
|
||||
- **C — context store/render** (`store/telemetry.go`): additive `context` + `context_customer` columns;
|
||||
`upsertAppIssue` stores context on INSERT, adopts a later one ONLY while the stored one is empty
|
||||
(**first capture wins**). Rendered as "Context around first occurrence — from <customer>", copyable.
|
||||
Nil-safe with pre-v0.111 reports.
|
||||
- **D — on-demand log tail (pull-based, hub half)**: per-app **Request log tail** button on the customer
|
||||
page (+ "tail pending" badge) → `log_tail_requests` (one per (customer,app), re-click refreshes) + a
|
||||
customer-visible `log_tail_requested` event (transparency). Report ACK advertises
|
||||
`log_tail_requests: [app…]` (same additive omit-when-empty pattern as escrow); the arriving
|
||||
`log_tails` are stored in `app_log_tails` (transient, last 2 per app), request **cleared in the same
|
||||
tx (consume-once)**. Ordered viewer with line numbers (`log_tail.html`) + Download .log; reads are
|
||||
customer-scoped (cross-customer → 404). NO hub→controller push channel.
|
||||
- **F — bug fix**: the 24h/7d/30d selector now filters Known Issues too — `GetAppIssues` gained the same
|
||||
`since` cutoff the Memory Trend uses (it previously had NO time filter at all).
|
||||
- **G — deletion → dismissal.** **Diagnosis recorded (spec asked a/b):** the delete handler was NOT
|
||||
broken — `DeleteAppIssues`/`ByIDs` execute correct SQL. Deletion is futile because the controller
|
||||
re-scans a rolling 15-minute log window every report and re-upserts any still-occurring fingerprint
|
||||
with a fresh scan-time `last_seen` minutes later → cause **(b)**. Implemented `dismissed_at`:
|
||||
Dismiss Selected/All, dismissed rows out of the default view ("Show dismissed" toggle shows them
|
||||
dimmed + badged), and un-dismiss ONLY on `excluded.last_seen > dismissed_at` (a re-sent old window
|
||||
stays hidden; a genuinely new occurrence resurfaces — recurrence is never silently swallowed).
|
||||
- **H — per-customer scoping**: `?customer=<id>` filters Known Issues by `affected_customers`
|
||||
membership (header: "filtered: <customer>"; period links carry the filter); the customer page's App
|
||||
Telemetry rows link to that filtered view (the drill-down). Fleet view unchanged; count column
|
||||
labeled "Occurrences (all customers)" (per-customer counts noted as a future refinement, not built).
|
||||
**Pending operator step (per the controller task spec):** after the floor bump rolls Peti to 0.112.0,
|
||||
delete the temporary Git Sync creds from Peti's hub config → next config pull → Peti's settings page
|
||||
shows "Registry: nyilvános (hitelesítés nélkül)" with zero credentials on the box. (Verified live on
|
||||
the credential-less demo box already: anonymous check OK, latest resolved, mode line renders.)
|
||||
|
||||
### Tests + red-proofs (all four failed exactly as designed; restored green)
|
||||
|
||||
- **G:** dismissal guard replaced with unconditional clear → `old-window re-report RESURRECTED the
|
||||
dismissed issue` → FAIL.
|
||||
- **F:** range predicate neutered → `10d-old issue visible in the 24h view` → FAIL.
|
||||
- **C:** first-capture-wins CASE replaced with overwrite → `empty-context upsert clobbered the stored
|
||||
context: []string(nil)` → FAIL.
|
||||
- **D consume-once:** request-DELETE removed from `SaveAppLogTail` → store test AND the API ACK
|
||||
round-trip both FAILED (`request survived fulfillment — the controller would ship tails every cycle`).
|
||||
- Non-hollow coverage: late-context adoption; warn-no-context; occurrence counting; tail
|
||||
request/refresh/fulfill/prune-to-2/cross-customer-scoping; ACK omit-when-empty baseline + full
|
||||
round-trip; render tests (expanded row incl. full message + context + provenance + dismiss controls +
|
||||
"filtered:" header; customer page request button/pending badge/tails section via the REAL handler;
|
||||
ordered tail view + text/plain attachment download + cross-customer 404).
|
||||
|
||||
### Live validation (demo, operator-free legs)
|
||||
|
||||
Synthetic error injected into the demo controller container's log stream (neighbor lines +
|
||||
`password=hunter2` + an `ERROR: … LC0111 …` line). On the next report cycle (14:22:34Z, 3.7KB vs the
|
||||
2.5KB baseline) the hub DB showed the row in `app_log_issues`: severity `error`,
|
||||
`context_customer=demo-felhom`, and an **exactly-ordered 11-line context** containing
|
||||
`diag: connecting with password=[REDACTED] to fake backend` — **live proof the secret never left the
|
||||
box** and that capture/wire/store all work end-to-end. (Method: report-cycle → `/api/v1/report` ingest →
|
||||
hub DB read via kubectl cp; DB copy deleted after. The UI click-path is render-tested — the hub operator
|
||||
password is Viktor-only, CC cannot log in.)
|
||||
|
||||
### Live tail round-trip — COMPLETED (Viktor logged the browser in; CC drove the UI)
|
||||
|
||||
Full end-to-end, through the real UI + both report cycles:
|
||||
1. **Request log tail** clicked on the `felhom-controller` row (14:35:20Z) → flash + **"tail pending"**
|
||||
badge + the `log_tail_requested` transparency event (severity info, source hub) all rendered.
|
||||
2. 14:37:34Z report (2,545 B): its ACK armed the controller.
|
||||
3. 14:52:34Z report: controller logged `log-tail collected for felhom-controller: 200 lines`, push
|
||||
grew to 18,849 B → the hub stored tail #1.
|
||||
4. UI verified: pending badge GONE (request consumed on fulfillment), **App Log Tails** section with
|
||||
View/Download; `/customers/demo-felhom/log-tail/1` renders "Collected on the box at 2026-07-10
|
||||
14:52:34 UTC · 200 lines, ordered as emitted · redacted controller-side" with numbered,
|
||||
chronologically ordered lines + the **Download .log** button.
|
||||
5. Expanded Known Issues row ALSO verified in the browser: "filtered: demo-felhom" header,
|
||||
"Occurrences (all customers)" column, full message `<pre>` + Copy, ordered 11-line context with
|
||||
`password=[REDACTED]` and "from demo-felhom" provenance link.
|
||||
|
||||
### Notes
|
||||
|
||||
- Per spec: do NOT request tails from Peti's box in this task — Viktor's call from the UI.
|
||||
Peti's CWA issues are now fully readable (full message + context) on the next report cycles.
|
||||
*(Previous report — hub v0.43.0 remote app-log diagnostics incl. the completed live tail round-trip —
|
||||
is recorded in hub/CHANGELOG.md v0.43.0 and the git history of this file.)*
|
||||
|
||||
Reference in New Issue
Block a user