From bb226f2355ba4c911719f89a5f0078a2661f6508 Mon Sep 17 00:00:00 2001 From: kisfenyo Date: Sun, 15 Nov 2026 14:13:30 +0100 Subject: [PATCH] =?UTF-8?q?docs:=20=C2=A78.2f=20as=20built=20=E2=80=94=20t?= =?UTF-8?q?he=20off-site=20copies=20of=20a=20removed=20app=20end=20after?= =?UTF-8?q?=2030=20days=20(D72,=20D84);=20the=20controller's=20red-proofs?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit - 07 §8.2f: [FACT — built, not released]; D84 ruled (decision 309); the five parts as built, the allowance, the audit, the mail; every edge case with the test that pins it; what differs from the design; the limit (the hub cannot read a snapshot's tags); every household text as built, Hungarian and English, with the mail; what a box must show before a release. A household with no notification address gets the page only. - 08 §6.5 and §8.1: the receipt offsite_end_scheduled and the two operator records. - 05: the app record's table in the delete rules; the window API's new fields. - The controller's red-proof outputs (56 mutations). - hub tests: the English fixture sentence uses the box's quote marks. Nothing is released and no box has run it. Claude-Session: https://claude.ai/code/session_0159rPz1ZhFKsS53msqPYxtS --- .../architecture/05-hub-architecture.md | 3 +- .../architecture/07-backup-architecture.md | 165 +++++++++++------- documentation/architecture/08-alarm-ladder.md | 20 +++ .../A/redproof-ctrl-page.txt | 90 ++++++++++ .../A/redproof-ctrl-press.txt | 49 ++++++ .../A/redproof-ctrl-record.txt | 50 ++++++ .../A/redproof-ctrl-window.txt | 122 +++++++++++++ hub/internal/notify/d84_receipt_test.go | 2 +- hub/internal/notify/mail_golden_test.go | 2 +- ...er_shape_offsite_end_scheduled_receipt.txt | 2 +- 10 files changed, 441 insertions(+), 64 deletions(-) create mode 100644 documentation/audits/build-release-4-2026-11-15/A/redproof-ctrl-page.txt create mode 100644 documentation/audits/build-release-4-2026-11-15/A/redproof-ctrl-press.txt create mode 100644 documentation/audits/build-release-4-2026-11-15/A/redproof-ctrl-record.txt create mode 100644 documentation/audits/build-release-4-2026-11-15/A/redproof-ctrl-window.txt diff --git a/documentation/architecture/05-hub-architecture.md b/documentation/architecture/05-hub-architecture.md index d794eaf2..2de101e4 100644 --- a/documentation/architecture/05-hub-architecture.md +++ b/documentation/architecture/05-hub-architecture.md @@ -451,6 +451,7 @@ or a household. The ruling: a delete removes them, with one exception — the de | `os_host_settings`, `os_reports`, `os_kernel_notices` | the box | the box is deleted | `store.DeleteHost`, in its one transaction | | the hub's own alarm marks that name the box (`hub_settings`, `os_alarm::…`) | the box | the box is deleted | the same transaction; matched on the whole id between colons, so a box whose id only starts with this id keeps its marks | | `offsite_keys`, `offsite_windows`, `offsite_abandon_requests` | the household | the household is deleted (the purge leg, after the outside legs) | `store.PurgeCustomerResidue`; counted in the delete dialog's residue | +| `offsite_app_presence` (the hub's own record of which apps a box runs; D72, `07` §8.2f — built, not released) | the household | the household is deleted; the daily orphan sweep takes what an earlier delete left | `store.PurgeCustomerResidue`, `store.PurgeOrphanRows`. At most 400 names per household; no age limit on a row (it would move a real app's 30 days) | | `operator_actions` (the operator's own action log) | the household | **one year after the deletion**, with `events` and `notification_log` | `store.PruneDeletedCustomerAudit`. *Decided by CC unattended on 2026-11-14; accepted by the operator on 2026-11-15 (`09` §3 decision 311):* it is an audit record of the same kind as the other two, and the one-year rule (decision 181) is the design's rule for those; the other option, at once, loses „who did what” on the day of the deletion | | **`host_deletions`, `customer_resets`** — the delete journal | both | **never** | the ruling's one exception: an id and timestamps, no personal data. The privacy text must say so (proposed, not published) | @@ -853,7 +854,7 @@ method (405), so a token gets 403. | `/configs/{id}/edit` | `customers:read` | **session only** | Edit can change the household's e-mail — and a new e-mail auto-mails the self-bind link (ruling 13:20). | | `/offsite/remove-unpinned/{id}` | — | **session only** | | | `/offsite/abandon-cancel/{id}` | — | **session only** | Cancelling a pending set-aside deletion: no group names it; until the operator places it, session only. | -| `/offsite/window-grant/{id}` | — | `offsite:write` | The one-shot clean-up window: the script address AND the customer page's „Backup & DR" card (R-1299, hub v0.174.0): `from=page` + `confirm=1` from the form; `cancel=1` removes a waiting grant; a limit above the store's snapshot count is refused. | +| `/offsite/window-grant/{id}` | — | `offsite:write` | The one-shot clean-up window: the script address AND the customer page's „Backup & DR" card (R-1299, hub v0.174.0): `from=page` + `confirm=1` from the form; `cancel=1` removes a waiting grant; a limit above the store's snapshot count is refused. **Built, not released (D72/D84, `07` §8.2f):** the box-facing `POST /api/v1/offsite/window-open/{id}` also takes the box's due off-site end records (`ended`) and answers `ended_allowed` / `ended_refused` — ids of removed apps' snapshots the hub agrees to from its own records, beside the window's cap; `window-close` takes `removed_for_ended_apps`. The card's „Last window” shows what was agreed, removed and refused. | | `/offsite/windows-enabled` | — | `offsite:write` | | | `/os/{id}` | `os:read` | `os:write` | | | `/offsite/key-audit` | — | `offsite:read` | Runs the daily key check now: it reads keys and reports, it changes none. | diff --git a/documentation/architecture/07-backup-architecture.md b/documentation/architecture/07-backup-architecture.md index 2b41a479..e74fd713 100644 --- a/documentation/architecture/07-backup-architecture.md +++ b/documentation/architecture/07-backup-architecture.md @@ -1835,88 +1835,133 @@ minutes). **[FACT]** 9202 rc.6: an image that exits after 20 s → not started, unit back → success, copy released 3 minutes later. Tester 1 on 0.343.0: a unit restore and a set-aside restore, each „ran stably for 3m0s … the restore copy is released" (`audits/release-2026-10-26/`). -### 8.2f The off-site copies of a removed app end 30 days after „delete backup data” `[DESIGN — proposed, not built]` (D72, `09` §3 decision 292, R-1374 part 1; written 2026-11-14) +### 8.2f The off-site copies of a removed app end 30 days after „delete backup data” `[FACT — built, not released: controller `f628cb5` and hub `01a106b7` + `a63f5b2b` (after v0.182.0), 2026-11-15; NO box has run it]` (D72 and D84, `09` §3 decisions 292 and 309, R-1374 part 1; designed 2026-11-14) **The ruling.** When the household removes an app and presses „delete backup data” (`remove_backups`), that app's off-site copies end 30 days later, at the next clean-up after that day — the number of a restore copy (D62). When the household keeps the app's backups, the off-site copies stay; no end is named for them, by ruling. The page must show -the end date BEFORE anything is deleted. +the end date BEFORE anything is deleted. **D84 (operator, 2026-11-15):** the ended apps' snapshots have their own +allowance, outside the weekly cap, only for ids the hub agreed to; and the household gets one mail at the press. -**Today (read in source, 2026-11-14).** „Delete backup data” deletes the unit, every second-drive mirror and the -app's backup preferences at once, and never touches an off-site snapshot (R-474). The weekly clean-up runs +**Before this (read in source, 2026-11-14).** „Delete backup data” deleted the unit, every second-drive mirror and the +app's backup preferences at once, and never touched an off-site snapshot (R-474). The weekly clean-up runs `forget --group-by host,tags` with keep 7 daily / 4 weekly / 6 monthly per (host, app tag) — and an app that is gone -makes no new snapshots, so its group keeps its last ones for ever (`backup/offbox_window.go:80-82`). Every off-site -snapshot carries the marker tag `felhom-offbox` and one tag per app it belongs to (`offbox_inventory.go:64`). The box -can delete off-site only inside the weekly window the hub opens, by snapshot id, behind the guard and under the -window's cap (decisions 68–69). +makes no new snapshots, so its group kept its last ones for ever. Every off-site snapshot carries the marker tag +`felhom-offbox` and one tag per app it belongs to. The box can delete off-site only inside the weekly window the hub +opens, by snapshot id, behind the guard and under the window's cap (decisions 68–69). All of that still holds; this +section adds one thing to that window. -**The design, in five parts.** +**What is built, in the design's five parts.** Nothing here is proven: no box and no real store has run it. -1. **The record.** At a removal with „delete backup data” the controller writes an *off-site end record* for the app: - `{app, removed_at, ends_at = removed_at + 30 days}`, in its settings (it survives a controller restart). No record - = no deletion, ever. A guest rebuild loses the record: the copies then stay (the safe direction). -2. **The household sees the date before it presses, and can take it back.** The remove dialog names the date under - the tick box. Until the copies are gone, the off-site list on the Backups page (which is keyed on the store, not on - what is installed — R-237) shows the app with „marked for deletion: ” and one button to keep it after all; - the button deletes the record. Nothing else in the product starts or shortens the clock. -3. **The deletion rides the weekly window, nothing else.** At the first window on or after `ends_at`, the box adds to - the window's plan the ids of the snapshots **whose app tags are all ended apps** (a snapshot that also belongs to - a living app stays until that app ends too). The removal is `forget ` and the window's own `prune`, the calls - the window makes today. The window's result names them apart (`removed_for_ended_apps`), so the hub's 07:10 audit - explains the vanished files and raises nothing. -4. **The hub agrees first — the box cannot use this to delete a living app's history.** The box reports its pending - end records. The hub allows an app in a window only when ITS OWN records agree: the app has been absent from that - box's reported app list for 30 days by the hub's clock (not the box's). A box that claims an end the hub cannot - see gets the app refused, and the window says so. This keeps decision 68's custody: a taken-over box gains no new - way to remove copies. -5. **Local copies are unchanged.** They are deleted at once, as today. The text says both. +1. **The record** `[FACT — built, not released]`. At a removal with „delete backup data” the controller writes an + *off-site end record* `{app, removed_at, ends_at = removed_at + 30 days}` into `settings.json` + (`settings/offsite_ends.go`; it survives a restart). **No record = no deletion, ever.** A guest rebuild loses the + record: the copies then stay. One writer (`backup.StartOffsiteEnd`); a second press changes nothing. **Only on a + box with the hub-provisioned off-site tier** — the household's own NAS target has no hub window, so there no + record is written, the dialog says nothing about off-site copies, and a removed app's copies stay as before. +2. **The household sees the date before it presses, and can take it back** `[FACT — built, not released]`. The remove + dialog names the day under the tick box (from `GET /api/stacks//backup-data`, `offsite_end_date`). The + off-site list on the restore page shows the app with „marked for deletion: ” and ONE button, „keep it + after all”, which deletes the record (`POST /backup/offsite-end/keep`). An install of the same app deletes the + record too (`stacks.DeployStack`, at the install's first write). Nothing else starts or shortens the clock. +3. **The deletion rides the weekly window, nothing else** `[FACT — built, not released]`. In the window, after the + guard has passed the policy's own plan under the cap as before, the box adds the ids of the snapshots **whose app + tags are all due records** and that the hub agreed to (`backup/offbox_ended.go`). One `forget --prune`, the + call the window always made. The result names them apart (`removed_for_ended_apps`). A snapshot made under the + app's tag AFTER the removal is never a candidate. +4. **The hub agrees first** `[FACT — built, not released]`. The hub keeps ITS OWN record of when an app left a box's + app list, by its own clock (`offsite_app_presence`, fed by every controller report; `store.NoteAppList`). The box + sends its due records with the window request; the hub agrees to an app only when its record shows the app absent + for 30 days, and to a snapshot id only when the hub's own listing of the repository (the 07:10 audit's stored + names and upload times) holds it, uploaded before that absence (`offsitekeys/ended.go`). A refused app is named, + with the reason, in the answer, on the window's own row and on the customer page's window block; a clear + disagreement raises `offsite_ended_app_refused` to the operator. The box's dates decide nothing on the hub. + For an app the hub never saw installed (removed before the hub kept this record) the hub's clock starts when the + box first names the app in a pending end record (the report's `offsite.ended_apps`). +5. **Local copies are unchanged.** They are deleted at once, as before. The dialog says both. -**Edge cases, each with its rule.** +**The allowance (D84)** `[FACT — built, not released]`. The window's cap (`max_remove`, half the store, at least 5) +and its rule are not touched: the guard still refuses a policy plan above it. The ended apps' ids are BESIDE it — the +hub stores the ids it agreed to on the window's row, keeps from the box's result only those, and allows a fall of the +cap plus those. `store.WindowCreditsBetween` gives the two parts apart. -| Case | Rule | Why | +**The 07:10 audit** `[FACT — built, not released]`. Vanished files that a window removed for ended apps — ids the hub +itself agreed to — are explained by name and raise nothing. Every other vanished file is judged against the cap's +part alone, exactly as before, and still raises `offsite_snapshots_vanished`. + +**The mail (D84)** `[FACT — built, not released]`. At the press the box sends `offsite_end_scheduled`; the hub mails +it to the household's own notification address — once per press, in the household's language, whatever its group +switches say (a receipt: `notify.householdReceiptEvents`), and not to the operator. **A household with no +notification address gets no mail: the page is all it has.** A blocked household gets none either. + +**Edge cases, each with its rule and its test.** + +| Case | Rule | Pinned by | |---|---|---| -| The app is installed again before the date | The install deletes the end record. The old copies are restore sources again („use my kept data”) | the household uses the app; deleting its history a few days later would be a surprise | +| The app is installed again before the date | The install deletes the end record; the hub's record forgets the absence at the next report. The old copies are restore sources again | `TestD72_AnInstallDeletesTheEndRecord`, `TestD72_AnAppInstalledAgainIsNeverDue`, hub `TestD84_AgreeEnded…` | | The app is installed again after the copies are gone | Nothing special: a new history starts | — | -| The household kept the backups at removal | No record. The copies stay with no end | the ruling: it follows the household's own choice | -| The household changes its mind | „Keep it after all” until the window has run; after that the copies are gone and the page says so | a deletion is not undoable off-site | -| The box is off at the date, or the off-site store cannot be reached | The next window that runs does it | the record does not age | -| The off-site tier is switched off before the date | The record stays and does nothing; if the tier comes back, the next window does it | no call to a store that is off | -| The household is deleted or RESET before the date | Nothing to do: the account goes with all copies | `05` §14.1 | -| A snapshot carries two apps' tags | It stays until BOTH have ended | a living app's copy is never removed by another app's end | -| The `_shares` pseudo-app and the infrastructure stacks | Never eligible | they are not apps a household removes | -| The window's cap (half the store; R-1294) | **Open — a decision:** the ended apps' snapshots count toward the cap, or have their own allowance | see below | -| The box's clock is wrong | The hub's clock decides (part 4) | R-1384 | -| An app removed with „delete backup data” BEFORE this is built | No record exists, so nothing is deleted. The off-site list shows the app with a button „delete in 30 days”: the household starts the clock itself | never a deletion the household was not told about | -| The guard refuses the window (a future-dated snapshot, a young removal) | The ended apps wait with everything else | one guard, no second path | -| The app's name is used by another catalog app later | The record is keyed on the app name AND `removed_at`; an install deletes it (first row) | same tag, new owner | +| The household kept the backups at removal | No record. The copies stay with no end. The off-site list offers „delete in 30 days” (the next row) | `TestD72_NoRecordNoDeletion`, `TestD72_RemovalWritesTheEndRecordOnlyWithDeleteBackupData` | +| The household changes its mind | „Keep it after all” until the window has run; after that the page says the copies are not marked or are already deleted | `TestD72_StartAndKeepHandlers`, `TestD72_AfterTheTakeBackTheWindowRemovesNothing` | +| Two presses for the same app | One record, one mail; the date does not move | `TestD72_EndRecord_ASecondPressChangesNothing`, `TestD84_OnePressOneMail`, hub `TestD84_Receipt_OncePerPress` | +| The box is off at the date, or the store cannot be reached | The next window that runs does it: the record does not age | `TestD72_EndRecord_Due` | +| The off-site tier is switched off at the date | No run, no window, no call to the store; the record stays | `TestD72_TierOffAtTheDate_TheRecordWaits` | +| The household is deleted or RESET before the date | Nothing to do: the account goes with all copies; the hub's app record goes with the household | hub `TestD72_AppRecordGoesWithTheHousehold` | +| A snapshot carries two apps' tags | It stays until BOTH have ended — on the box, and again on the hub (an id listed under a refused app is refused) | `TestD72_TheEndedAppsOwnSnapshotsGoAndNothingElse`, `TestD72_ASharedSnapshotGoesWhenBothHaveEnded` | +| The `_shares` pseudo-app and the infrastructure stacks | Never eligible: no record can be written, none is ever due, and the hub refuses the names | `TestD72_SharesAndInfraAreNeverEligible`, hub `TestD84_AgreeEnded…`, `TestD72_AppRecord_OnlyAppNamesAreStored` | +| The window's cap (half the store; R-1294) | **Ruled, D84:** the ended apps' ids have their own allowance, beside the cap, only for ids the hub agreed to | `TestD84_OneGuard_AndTheAllowanceIsBesideTheCap`, hub `TestD84_Window_TheEndedAllowanceIsBesideTheCap` | +| The box's clock is wrong (a month ahead) | The box asks early; the hub's clock decides and refuses; nothing goes | `TestD84_TheBoxRemovesOnlyWhatTheHubAgreedTo`, hub `TestD84_AgreeEnded…` | +| A record with a date in the past, written by a box the hub does not agree with | Refused: the hub never reads the box's dates | hub `TestD84_AgreeEnded…`, `TestD72_ReportFeedsTheHubsOwnAppRecord` | +| An app removed with „delete backup data” BEFORE this is built | No record exists, so nothing is deleted. The off-site list shows the app with „delete in 30 days”: the household starts the clock itself | `TestD72_RestorePageShowsTheEndPerBranch` | +| The guard refuses the window (a future-dated snapshot, a plan above the cap) | The ended apps wait with everything else | `TestD84_OneGuard_AndTheAllowanceIsBesideTheCap` | +| The hub does not know ended apps (an older hub), or the box does not (an older controller) | Nothing of an ended app is removed; each side is releasable alone | `TestD84_TheBoxRemovesOnlyWhatTheHubAgreedTo` | +| The app has no copy in the store at all | The due record is closed with no history line; nothing is asked of the hub | `TestD72_ARecordWithNoCopiesIsClosedQuietly` | +| A box sends invented app names in every report | The hub's app record holds at most 400 names per household; only names shaped like an app name are stored. No age limit on a row, on purpose: it would move a real app's 30 days | hub `TestD72_AppRecord_*` | -**What it costs if nothing is built:** the off-site copies of every removed app stay for ever; the paid space only -grows; the household that pressed „delete backup data” is told a thing that is not true off-site. +**What differs from the 2026-11-14 design, and what is not built.** -**The open decision (for the operator).** Do the ended apps' snapshots count toward the window's weekly cap? -*CC's pick: no — their own allowance, only for ids the hub agreed to (part 4).* Why: the cap exists to stop a -taken-over box from deleting a living history fast; the hub's own 30-day check does that job for this path, and under -the cap a household that removes one big app could stop every clean-up for weeks (R-1294's shape). The other option — -they count — needs no new rule, and costs a refused window, then the operator's one-shot grant, at each large removal. +- *No record on a box whose off-site target is the household's own NAS* (part 1). The design did not name the case. +- *The hub agrees per snapshot id from its own listing*, not only per app — it is how „only ids the hub agreed to” + is made true without the repository password. +- *„Delete in 30 days” is offered for every removed app whose copies are in the store and that has no record* — the + box cannot tell „removed before this was built” from „the household kept the backups”. +- *A record stays pending while a snapshot with the app's tag is left* (one it shares with a living app). The list + then still reads „marked for deletion” with a day that has passed. +- *The per-app operator record (`offsite_ended_app_removed`) has the snapshot count and no bytes* — the hub cannot + see sizes, and the box does not send them. +- *The receipt does not read the household's group switches.* D84's reason is a household whose login someone else + uses; that person could switch a group off first. **The operator may reverse this.** -**The texts — a proposal, NOT published.** No suffix on the date, so one sentence serves every date. +**A limit, said plainly.** The hub cannot read a snapshot's tags (the repository is encrypted; the password never +leaves the box — decision 68). A box that is taken over AND has one honestly ended app can name, under that app, +other snapshots that are older than the app's end. The upload-time rule bounds that to files older than 30 days; it +does not close it. The same box can already remove half the store per week inside the cap. + +**The texts, as built — NOT published; the operator reads them before a release.** The Hungarian date carries its own +final dot (`2026. 12. 15.`), so the Hungarian sentences have no dot after it. | Where | Hungarian | English | |---|---|---| -| The remove dialog, under „Mentési adatok törlése” | „A helyi mentések most törlődnek. A távoli másolatok még 30 napig megmaradnak. Törlésük napja: {dátum}. Addig a Mentések oldalon visszavonhatod.” | "The local backups are deleted now. The off-site copies stay for 30 more days. They are deleted on: {date}. Until then you can take this back on the Backups page." | -| The off-site list, the app's line | „Törlésre kijelölve. Törlés napja: {dátum}.” | "Marked for deletion. Deleted on: {date}." | +| The remove dialog, under „Mentési adatok törlése” | „A helyi mentések most törlődnek. A távoli másolatok még 30 napig megmaradnak. Törlésük napja: {dátum} Addig a Mentések oldalon visszavonhatod.” | "The local backups are deleted now. The off-site copies stay for 30 more days. They are deleted on: {date}. Until then you can take this back on the Backups page." | +| The off-site list, the app's line (also the notice after „delete in 30 days”) | „Törlésre kijelölve. Törlés napja: {dátum}” | "Marked for deletion. Deleted on: {date}." | | The button | „Mégis megtartom” | "Keep it after all" | | After the button | „A távoli másolatok megmaradnak.” | "The off-site copies are kept." | -| After the deletion, in the list's history line | „A távoli másolatok törölve: {dátum}.” | "The off-site copies were deleted on {date}." | -| An app removed before this existed | „Ennek az alkalmazásnak a távoli másolatai megmaradtak.” + button „Törlés 30 nap múlva” | "The off-site copies of this app were kept." + "Delete in 30 days" | +| „Keep it after all” when nothing is marked (the window has run) | „Ennek az alkalmazásnak a távoli másolatai nincsenek törlésre kijelölve, vagy már törlődtek.” | "The off-site copies of this app are not marked for deletion, or are already deleted." | +| After the deletion, the list's history line (after the app's name) | „A távoli másolatok törölve: {dátum}” | "The off-site copies were deleted on {date}." | +| A removed app with no record | „Ennek az alkalmazásnak a távoli másolatai megmaradtak.” + button „Törlés 30 nap múlva” | "The off-site copies of this app were kept." + "Delete in 30 days" | +| A press that is refused (the app is installed; no hub tier) | „Ennek az alkalmazásnak a távoli másolatait most nem lehet törlésre kijelölni.” | "The off-site copies of this app cannot be marked for deletion now." | +| A record that could not be saved | „Nem sikerült elmenteni. Próbáld újra.” | "This could not be saved. Try again." | +| **The mail — subject** | „[Felhom] Információ: {app}: a távoli másolatok törlésre kijelölve” | "[Felhom] Information: {app}: the off-site copies are marked for deletion" | +| **The mail — body** (inside the hub's ordinary household mail frame: greeting, server, time, level, type, sign-off) | „{app}: az alkalmazás távoli másolatai törlésre vannak kijelölve. Törlésük napja: {dátum} Addig a Mentések oldalon a „Mégis megtartom” gombbal visszavonhatod.” | "{app}: the off-site copies of this app are marked for deletion. They are deleted on: {date}. Until then you can take this back on the Backups page with the “Keep it after all” button." | -No mail to the household at the deletion: it can do nothing with it (`08` §8.1). One operator-only event per app -(`offsite_ended_app_removed`: app, snapshots, bytes). +No mail to the household at the deletion: it can do nothing with it (`08` §8.1). The operator's records are +`offsite_ended_app_removed` (info, per app, not mailed) and `offsite_ended_app_refused` (warning) — `08` §6.5. -**Not measured, and what must be measured before a build:** nothing in this design is a new mechanism on the box — -the window removes by id today. To measure in the build: how long `prune` takes after a whole app's history goes -(the largest removal a window has made is 209 snapshots, refused), and that restic 0.19.1 frees the space in the same -window. +**Not measured, and what a box must show before a release:** (1) one whole run on a test box — press, record, +30 days by BOTH clocks (or a hub record back-dated by hand on a test household), window, the files gone from the +provider, the 07:10 audit silent; (2) how long `prune` takes after a whole app's history goes (the largest removal a +window has made is 209 snapshots, refused), and that restic 0.19.1 frees the space in the same window, inside the +window's 20 minutes; (3) the mail in a real inbox, in both languages; (4) the hub's listing times against the +provider's clock for a file older than six months (the listing then shows a date with no time). ### 8.2c Decisions in code that no document recorded [DESIGN — confirmed by the operator 2026-10-25 (D44 = all picks, R-1265)] diff --git a/documentation/architecture/08-alarm-ladder.md b/documentation/architecture/08-alarm-ladder.md index 32c3e73d..4949dae1 100644 --- a/documentation/architecture/08-alarm-ladder.md +++ b/documentation/architecture/08-alarm-ladder.md @@ -463,6 +463,22 @@ caveat holds); it is a NET count — new snapshots between two reports hide the spent" memory is in-process, so after a hub restart one window can explain one more fall. Pinned by `hub/internal/monitor/r435_pinned_drop_test.go` and `hub/internal/store/r435_windows_between_test.go`. +**The off-site copies of a removed app (D72, D84; `07` §8.2f)** `[FACT — built, not released: hub `main` after +v0.182.0 and controller `main`, 2026-11-15; no box has run it]`. A window may also remove, BESIDE its cap, the +snapshots of apps the household removed with „delete backup data” 30 days ago — only ids the hub agreed to from its +own records. What that adds here: + +| Event | Severity | Who | When | +|---|---|---|---| +| `offsite_end_scheduled` (from the box) | info | **the household** — a receipt: one mail per press to its own notification address, whatever its group switches say; never the operator (`notify.householdReceiptEvents`) | the household pressed „delete backup data” at a removal, or „delete in 30 days” on the restore page | +| `offsite_ended_app_removed` (hub) | info | operator-only, recorded, not mailed | a window removed an app's agreed snapshots — one per app, with the count | +| `offsite_ended_app_refused` (hub) | warning | operator-only, once per app (details `subject`) | a box asked for an app the hub's records clearly do not show ended: the app is in its app list, or absent for less than 29 days. A box that asks less than a day early is refused quietly | + +The count detector above and the 07:10 listing check (`offsite_snapshots_vanished`) both know the allowance: a window +explains its cap's part as before, and — by name — the ids the hub agreed to for ended apps. A file that vanished +for any other reason raises exactly as before. The household gets NO mail at the deletion (§8.1: it can act on none). +A household with no notification address gets no receipt: the page is all it has. + ## 7. The intent test [DESIGN, R-386 — CLOSED controller v0.223.0] **"The customer stopped this" is asked of the FIELD THAT RECORDS IT, never inferred from the state.** @@ -549,6 +565,10 @@ app-mail settings).* | **2. „Az alkalmazásaim"** — your apps | `app_stopped_unhealthy`, `app_start_failed`, `app_update_held`, `app_update_undone` | mostly us; the household may want to know an app is down | | **3. „Amit mi intézünk"** — what we handle | `backup_failed`, `db_dump_failed`, `backup_integrity_failed`, `crossdrive_failed`, `expected_backup_missed`, `expected_dbdump_missed`, `node_down`, `health_critical`, `health_recovered` | us (the operator always gets these, with the detail) | +**One mail outside the groups (D84, `09` §3 decision 309)** `[FACT — built, not released]`: the receipt +`offsite_end_scheduled` (§6.5) is not a detector and belongs to no group — it confirms the household's own press, and +a switch must not be able to silence it. It is the only such type; a second one needs its own ruling. + **Options:** - **A — three group switches** (recommended). The page shows the three groups above, each one switch, with one diff --git a/documentation/audits/build-release-4-2026-11-15/A/redproof-ctrl-page.txt b/documentation/audits/build-release-4-2026-11-15/A/redproof-ctrl-page.txt new file mode 100644 index 00000000..8339fe00 --- /dev/null +++ b/documentation/audits/build-release-4-2026-11-15/A/redproof-ctrl-page.txt @@ -0,0 +1,90 @@ +### internal/web/offsite_ends.go +== MUTATION: an INSTALLED app with a stale record reads „marked for deletion” + RED on the mutant, GREEN on the real file + --- FAIL: TestD72_ApplyOffsiteEnds (0.00s) + offsite_ends_test.go:109: an installed app shows an end: {App:immich DisplayName: Slug: InStore:true Installed:true Enabled:false StoreUnknown:false LatestAt:0001-01-01 00:00:00 +0000 UTC SizeBytes:0 EndDate:MARKED immich EndOffer +== MUTATION: „delete in 30 days” is offered for an installed app + RED on the mutant, GREEN on the real file + --- FAIL: TestD72_ApplyOffsiteEnds (0.00s) + offsite_ends_test.go:109: an installed app shows an end: {App:immich DisplayName: Slug: InStore:true Installed:true Enabled:false StoreUnknown:false LatestAt:0001-01-01 00:00:00 +0000 UTC SizeBytes:0 EndDate: EndOffered:true} + offsite_ends_test.go:116: docmost must show nothing: {App:docmost DisplayName: Slug: InStore:true Installed:true Enabled:false StoreUnknown:false LatestAt:0001-01-01 00:00:00 +0000 UTC SizeBytes:0 EndDate: EndOffered:true} +== MUTATION: „delete in 30 days” is offered on a box without the hub's tier + RED on the mutant, GREEN on the real file + --- FAIL: TestD72_ApplyOffsiteEnds (0.00s) + offsite_ends_test.go:126: vikunja: offered on a box without the hub's tier + offsite_ends_test.go:126: kimai: offered on a box without the hub's tier +== MUTATION: „delete in 30 days” is offered for an app with nothing in the store + RED on the mutant, GREEN on the real file + --- FAIL: TestD72_ApplyOffsiteEnds (0.00s) + offsite_ends_test.go:116: empty must show nothing: {App:empty DisplayName: Slug: InStore:false Installed:false Enabled:false StoreUnknown:false LatestAt:0001-01-01 00:00:00 +0000 UTC SizeBytes:0 EndDate: EndOffered:true} +== MUTATION: a record whose app has no row is not shown (no take-back) + RED on the mutant, GREEN on the real file + --- FAIL: TestD72_ApplyOffsiteEnds (0.00s) + offsite_ends_test.go:121: a record with no row is not shown: {App: DisplayName: Slug: InStore:false Installed:false Enabled:false StoreUnknown:false LatestAt:0001-01-01 00:00:00 +0000 UTC SizeBytes:0 EndDate: EndOffered:false} ok= +== MUTATION: „keep it after all” says kept and deletes nothing + RED on the mutant, GREEN on the real file + --- FAIL: TestD72_StartAndKeepHandlers (0.00s) + offsite_ends_test.go:206: „keep it after all” left the record — the window would still delete the copies +== MUTATION: the marked line has no date + RED on the mutant, GREEN on the real file + --- FAIL: TestD72_OffsiteEndDataFromTheRecords (0.00s) + offsite_ends_test.go:239: hu: marked line = "Törlésre kijelölve. Törlés napja: ", want "Törlésre kijelölve. Törlés napja: 2026. 12. 15." + offsite_ends_test.go:239: en: marked line = "Marked for deletion. Deleted on: .", want "Marked for deletion. Deleted on: 2026-12-15." + +7 mutations, 0 not a red-proof + +### internal/web/templates/backups_restore.html +== MUTATION: the marked row has no working take-back button + RED on the mutant, GREEN on the real file + --- FAIL: TestD72_RestorePageShowsTheEndPerBranch (0.19s) + offsite_ends_test.go:51: the restore page lacks "action=\"/backup/offsite-end/keep\"" + offsite_ends_test.go:55: 0 „keep it after all” forms, want one (the marked app's) +== MUTATION: the removed app with kept copies is never offered „delete in 30 days” + RED on the mutant, GREEN on the real file + --- FAIL: TestD72_RestorePageShowsTheEndPerBranch (0.24s) + offsite_ends_test.go:51: the restore page lacks "data-offsite-end=\"kept\">Ennek az alkalmazásnak a távoli másolatai megmaradtak." + offsite_ends_test.go:51: the restore page lacks "action=\"/backup/offsite-end/start\"" + offsite_ends_test.go:51: the restore page lacks "name=\"app\" value=\"kimai\"" +== MUTATION: every row shows „delete in 30 days” + RED on the mutant, GREEN on the real file + --- FAIL: TestD72_RestorePageShowsTheEndPerBranch (0.21s) + offsite_ends_test.go:58: 2 „delete in 30 days” forms, want one (the removed app with kept copies) + offsite_ends_test.go:62: an INSTALLED app is offered an end: "name=\"app\" value=\"immich\"" + offsite_ends_test.go:69: a page with no end record and no removed app shows the end's controls +== MUTATION: the history line is not rendered + RED on the mutant, GREEN on the real file + --- FAIL: TestD72_RestorePageShowsTheEndPerBranch (0.19s) + offsite_ends_test.go:51: the restore page lacks "data-offsite-end=\"done\">docmost: A távoli másolatok törölve: 2026. 11. 08.

" + +4 mutations, 0 not a red-proof + +### internal/web/templates/layout.html +== MUTATION: the dialog shows the sentence without a date from the API + RED on the mutant, GREEN on the real file + --- FAIL: TestD72_TheRemoveDialogNamesTheDate (0.12s) + offsite_ends_test.go:286: [hu] the dialog does not show the sentence only with the API's date + offsite_ends_test.go:286: [en] the dialog does not show the sentence only with the API's date +== MUTATION: the dialog does not put the date into the sentence + RED on the mutant, GREEN on the real file + --- FAIL: TestD72_TheRemoveDialogNamesTheDate (0.12s) + offsite_ends_test.go:286: [hu] the dialog does not show the sentence only with the API's date + offsite_ends_test.go:286: [en] the dialog does not show the sentence only with the API's date + +2 mutations, 0 not a red-proof + +### internal/web/server.go +== MUTATION: the take-back route is not wired + RED on the mutant, GREEN on the real file + --- FAIL: TestD72_TheEndRoutesAreWired (0.00s) + offsite_ends_test.go:262: server.go lacks the route "case path == \"/backup/offsite-end/keep\" && r.Method == http.MethodPost:\n\t\ts.offsiteEndKeepHandler(w, r)" + +1 mutations, 0 not a red-proof + +### internal/web/handlers.go +== MUTATION: the restore page does not read the end records + RED on the mutant, GREEN on the real file + --- FAIL: TestD72_TheEndRoutesAreWired (0.00s) + offsite_ends_test.go:270: the restore page does not put the end records on its rows + +1 mutations, 0 not a red-proof + diff --git a/documentation/audits/build-release-4-2026-11-15/A/redproof-ctrl-press.txt b/documentation/audits/build-release-4-2026-11-15/A/redproof-ctrl-press.txt new file mode 100644 index 00000000..aa376ec7 --- /dev/null +++ b/documentation/audits/build-release-4-2026-11-15/A/redproof-ctrl-press.txt @@ -0,0 +1,49 @@ +### internal/stacks/deploy.go +== MUTATION: an install does not delete the end record + RED on the mutant, GREEN on the real file + --- FAIL: TestD72_AnInstallDeletesTheEndRecord (0.01s) + d72_install_ends_record_test.go:46: the app is installed again and its off-site end record is still there ({App:gapp RemovedAt:2026-10-17T12:59:10Z EndsAt:2026-11-16T12:59:10Z}) — the next window would delete a living app's histor + +1 mutations, 0 not a red-proof + +### internal/notify/notifier.go +== MUTATION: the English sentence carries the Hungarian date form + RED on the mutant, GREEN on the real file + --- FAIL: TestD84_OffsiteEndScheduledEvent (0.01s) + d84_offsite_end_scheduled_test.go:57: the English sentence "vikunja: the off-site copies of this app are marked for deletion. They are deleted on: 2026. 12. 15.. Until then you can take this back on the Backups page with the “Keep + d84_offsite_end_scheduled_test.go:61: the English sentence carries the Hungarian date form or a verb: "vikunja: the off-site copies of this app are marked for deletion. They are deleted on: 2026. 12. 15.. Until then you can take t +== MUTATION: an English household gets no sentence of its own + RED on the mutant, GREEN on the real file + --- FAIL: TestD84_OffsiteEndScheduledEvent (0.01s) + d84_offsite_end_scheduled_test.go:57: the English sentence "" lacks "vikunja" + d84_offsite_end_scheduled_test.go:57: the English sentence "" lacks "2026-12-15" + d84_offsite_end_scheduled_test.go:57: the English sentence "" lacks "Backups page" +== MUTATION: the press's key is the app alone (a second removal of the app is the same press) + RED on the mutant, GREEN on the real file + --- FAIL: TestD84_OffsiteEndScheduledEvent (0.01s) + d84_offsite_end_scheduled_test.go:67: hu: details {"stack_name":"vikunja","removed_at":"2026-11-15T10:30:00Z","ends_at":"2026-12-15T10:30:00Z","subject":"vikunja"} lack "subject":"vikunja|2026-11-15T10:30:00Z" + d84_offsite_end_scheduled_test.go:67: en: details {"stack_name":"vikunja","removed_at":"2026-11-15T10:30:00Z","ends_at":"2026-12-15T10:30:00Z","subject":"vikunja"} lack "subject":"vikunja|2026-11-15T10:30:00Z" +== MUTATION: the event is a warning + RED on the mutant, GREEN on the real file + --- FAIL: TestD84_OffsiteEndScheduledEvent (0.01s) + d84_offsite_end_scheduled_test.go:39: hu: calls=1 type="offsite_end_scheduled" severity="warning" + +4 mutations, 0 not a red-proof + +### internal/api/router.go +== MUTATION: EVERY removal writes the end record, also one that keeps the backups + RED on the mutant, GREEN on the real file + --- FAIL: TestD72_RemovalWritesTheEndRecordOnlyWithDeleteBackupData (0.00s) + d72_offsite_end_test.go:126: removeStack: 1 call(s) of StartOffsiteEnd, 0 inside `if … body.RemoveBackups …` — want exactly one, guarded: a removal that KEEPS the backups must write no end record +== MUTATION: the dialog names a date on a box without the hub's tier + RED on the mutant, GREEN on the real file + --- FAIL: TestD72_BackupDataCarriesTheEndDateBeforeThePress (0.00s) + d72_offsite_end_test.go:75: a box without the hub's tier names an end date: 2026. 12. 15. +== MUTATION: the dialog's date is today + RED on the mutant, GREEN on the real file + --- FAIL: TestD72_BackupDataCarriesTheEndDateBeforeThePress (0.00s) + d72_offsite_end_test.go:65: [hu] offsite_end_date = "2026. 11. 15.", want "2026. 12. 15." (today + 30 days) + d72_offsite_end_test.go:65: [en] offsite_end_date = "2026-11-15", want "2026-12-15" (today + 30 days) + +3 mutations, 0 not a red-proof + diff --git a/documentation/audits/build-release-4-2026-11-15/A/redproof-ctrl-record.txt b/documentation/audits/build-release-4-2026-11-15/A/redproof-ctrl-record.txt new file mode 100644 index 00000000..cee923cc --- /dev/null +++ b/documentation/audits/build-release-4-2026-11-15/A/redproof-ctrl-record.txt @@ -0,0 +1,50 @@ +### internal/settings/offsite_ends.go +== MUTATION: a second press writes a new record (the date moves) + RED on the mutant, GREEN on the real file + --- FAIL: TestD72_EndRecord_ASecondPressChangesNothing (0.00s) + offsite_ends_test.go:57: a second press at 2026-11-05 10:30:00 +0000 UTC: created=true rec={App:vikunja RemovedAt:2026-11-05T10:30:00Z EndsAt:2026-12-05T10:30:00Z} err= — want the first record unchanged ({App:vikunja RemovedA +== MUTATION: the end is 15 days after the press, not 30 + RED on the mutant, GREEN on the real file + --- FAIL: TestD72_EndRecord_IsWrittenAndSurvivesARestart (0.00s) + offsite_ends_test.go:34: record = {App:vikunja RemovedAt:2026-11-15T10:30:00Z EndsAt:2026-11-30T10:30:00Z}, want removed 2026-11-15T10:30:00Z and ends exactly 30 days later +== MUTATION: the record is not written to disk + RED on the mutant, GREEN on the real file + --- FAIL: TestD72_EndRecord_IsWrittenAndSurvivesARestart (0.00s) + offsite_ends_test.go:42: after a restart the record is {App: RemovedAt: EndsAt:} ok=false, want {App:vikunja RemovedAt:2026-11-15T10:30:00Z EndsAt:2026-12-15T10:30:00Z} +== MUTATION: the take-back does not delete the record + RED on the mutant, GREEN on the real file + --- FAIL: TestD72_EndRecord_CancelDeletesIt (0.00s) + offsite_ends_test.go:76: the record is still there after the take-back + --- FAIL: TestD72_EndRecord_CompleteNeedsTheSameRecord (0.00s) + offsite_ends_test.go:95: an old window completed a NEW record: done=true err= +== MUTATION: an old window completes a NEW record + RED on the mutant, GREEN on the real file + --- FAIL: TestD72_EndRecord_CompleteNeedsTheSameRecord (0.00s) + offsite_ends_test.go:95: an old window completed a NEW record: done=true err= +== MUTATION: a short ends_at shortens the 30 days + RED on the mutant, GREEN on the real file + --- FAIL: TestD72_EndRecord_Due (0.00s) + offsite_ends_test.go:139: an ends_at EARLIER than 30 days after the removal does not shorten the wait: Due = true, want false +== MUTATION: a record with an unreadable date is due + RED on the mutant, GREEN on the real file + --- FAIL: TestD72_EndRecord_Due (0.00s) + offsite_ends_test.go:139: no removed_at: Due = true, want false + offsite_ends_test.go:139: an ends_at that cannot be read: Due = true, want false +== MUTATION: a record is due before its day + RED on the mutant, GREEN on the real file + --- FAIL: TestD72_EndRecord_Due (0.00s) + offsite_ends_test.go:139: one second before the end: Due = true, want false + offsite_ends_test.go:139: an ends_at EARLIER than 30 days after the removal does not shorten the wait: Due = true, want false +== MUTATION: _shares may get an end record + RED on the mutant, GREEN on the real file + --- FAIL: TestD72_EndRecord_ReservedNamesGetNone (0.00s) + offsite_ends_test.go:149: "_shares" got an end record (created=true err=) + offsite_ends_test.go:149: "_anything" got an end record (created=true err=) + offsite_ends_test.go:153: 2 record(s) written for reserved names +== MUTATION: an end with no snapshot writes a history line + RED on the mutant, GREEN on the real file + --- FAIL: TestD72_EndRecord_CompleteNeedsTheSameRecord (0.00s) + offsite_ends_test.go:114: an end with no snapshot must close with no history line: [{App:kimai RemovedAt:2026-11-15T12:57:10Z DeletedAt:2026-12-06T03:00:00Z Snapshots:0} {App:vikunja RemovedAt:2026-11-01T00:00:00Z DeletedAt:2026-1 + +10 mutations, 0 not a red-proof + diff --git a/documentation/audits/build-release-4-2026-11-15/A/redproof-ctrl-window.txt b/documentation/audits/build-release-4-2026-11-15/A/redproof-ctrl-window.txt new file mode 100644 index 00000000..60ab26c2 --- /dev/null +++ b/documentation/audits/build-release-4-2026-11-15/A/redproof-ctrl-window.txt @@ -0,0 +1,122 @@ +### internal/backup/offbox_ended.go +== MUTATION: a snapshot that ALSO carries a living app's tag is a candidate + RED on the mutant, GREEN on the real file + --- FAIL: TestD72_NoRecordNoDeletion (0.00s) + offbox_ended_test.go:156: opened=1 claims=[{App:_shares RemovedAt: EndsAt: SnapshotIDs:[s1-full]} {App:immich RemovedAt: EndsAt: SnapshotIDs:[i1-full i2-full vi-full]} {App:kimai RemovedAt: EndsAt: SnapshotIDs:[k1-full]} {App:viku + offbox_ended_test.go:156: opened=1 claims=[{App:_shares RemovedAt: EndsAt: SnapshotIDs:[s1-full]} {App:immich RemovedAt: EndsAt: SnapshotIDs:[i1-full i2-full vi-full]} {App:kimai RemovedAt: EndsAt: SnapshotIDs:[k1-full]} {App:viku + offbox_ended_test.go:156: opened=1 claims=[{App:_shares RemovedAt: EndsAt: SnapshotIDs:[s1-full]} {App:immich RemovedAt: EndsAt: SnapshotIDs:[i1-full i2-full vi-full]} {App:kimai RemovedAt: EndsAt: SnapshotIDs:[k1-full]} {App:viku +== MUTATION: a snapshot made after the removal is a candidate + RED on the mutant, GREEN on the real file + --- FAIL: TestD72_NotDueYet_AndASnapshotYoungerThanTheRemoval (0.00s) + offbox_ended_test.go:412: removed [k1-full k2-full], want k1 only — k2 was made after the removal +== MUTATION: an INSTALLED app's record is due + RED on the mutant, GREEN on the real file + --- FAIL: TestD72_SharesAndInfraAreNeverEligible (0.00s) + offbox_ended_test.go:254: due = map[traefik:{traefik 2026-10-06T14:57:25+02:00 2026-11-05T13:57:25+01:00} vikunja:{vikunja 2026-10-06T14:57:25+02:00 2026-11-05T13:57:25+01:00}], want vikunja only + --- FAIL: TestD72_AnAppInstalledAgainIsNeverDue (0.00s) + offbox_ended_test.go:379: claims=[{App:vikunja RemovedAt:2026-10-15T12:57:25Z EndsAt:2026-11-14T12:57:25Z SnapshotIDs:[v1-full v2-full v3-full]}] removed=[v1-full v2-full v3-full] — an installed app's history must not be touched +== MUTATION: a record is due before its day (29 days) + RED on the mutant, GREEN on the real file + --- FAIL: TestD72_NotDueYet_AndASnapshotYoungerThanTheRemoval (0.00s) + offbox_ended_test.go:404: 29 days: claims=[{App:vikunja RemovedAt:2026-10-17T12:57:30Z EndsAt:2026-11-16T12:57:30Z SnapshotIDs:[v1-full v2-full v3-full]}] removed=[v1-full v2-full v3-full] +== MUTATION: a box that cannot tell what it runs treats every app as removed + RED on the mutant, GREEN on the real file + --- FAIL: TestD72_WithoutTheLivingCheckNothingIsDue (0.00s) + offbox_ended_test.go:390: claims=[{App:vikunja RemovedAt:2026-10-15T12:57:35Z EndsAt:2026-11-14T12:57:35Z SnapshotIDs:[v1-full v2-full v3-full]}] removed=[v1-full v2-full v3-full] +== MUTATION: the box removes an id the hub agreed to but the box never named + RED on the mutant, GREEN on the real file + --- FAIL: TestD72_NoRecordNoDeletion (0.00s) + offbox_ended_test.go:159: with NO end record the window removed [i1-full i2-full k1-full s1-full v1-full v2-full v3-full vi-full] + offbox_ended_test.go:159: with NO end record the window removed [i1-full i2-full k1-full s1-full v1-full v2-full v3-full vi-full] + offbox_ended_test.go:159: with NO end record the window removed [i1-full i2-full k1-full s1-full v1-full v2-full v3-full vi-full] +== MUTATION: an id the policy already removes is named again for ended apps + RED on the mutant, GREEN on the real file + --- FAIL: TestD84_OneGuard_AndTheAllowanceIsBesideTheCap (0.00s) + offbox_ended_test.go:363: removed_for_ended_apps = [v1-full v2-full v3-full], want v2,v3 (v1 went under the cap) +== MUTATION: the record closes while a copy of the app is left + RED on the mutant, GREEN on the real file + --- FAIL: TestD72_TheEndedAppsOwnSnapshotsGoAndNothingElse (0.00s) + offbox_ended_test.go:208: the record was closed although a snapshot with vikunja's tag is still in the store + --- FAIL: TestD84_TheBoxRemovesOnlyWhatTheHubAgreedTo (0.00s) + offbox_ended_test.go:298: the record is gone although copies of the app are left — the next window could not finish the job +== MUTATION: a record with no copy at all is never closed + RED on the mutant, GREEN on the real file + --- FAIL: TestD72_ARecordWithNoCopiesIsClosedQuietly (0.00s) + offbox_ended_test.go:429: want the record closed with no history line; pending=true history=[] +== MUTATION: every due record is closed before the window (nothing is claimed) + RED on the mutant, GREEN on the real file + --- FAIL: TestD72_TheEndedAppsOwnSnapshotsGoAndNothingElse (0.00s) + offbox_ended_test.go:179: the claim sent to the hub = [], want vikunja with v1,v2,v3 only (not the snapshot shared with immich) + --- FAIL: TestD72_ASharedSnapshotGoesWhenBothHaveEnded (0.00s) + offbox_ended_test.go:222: removed [], want both apps' snapshots and the shared one +== MUTATION: a press writes a record on a box without the hub's tier + RED on the mutant, GREEN on the real file + --- FAIL: TestD72_TierOffAtTheDate_TheRecordWaits (0.00s) + offbox_ended_test.go:462: a press on a box without the hub's tier: created=true err=, want ErrOffsiteEndNotOffered and no record +== MUTATION: a press writes a record for an INSTALLED app + RED on the mutant, GREEN on the real file + --- FAIL: TestD72_SharesAndInfraAreNeverEligible (0.00s) + offbox_ended_test.go:265: "traefik" got an end record + offbox_ended_test.go:269: 1 record(s) written + --- FAIL: TestD84_OnePressOneMail (0.00s) +== MUTATION: a second press mails again + RED on the mutant, GREEN on the real file + --- FAIL: TestD84_OnePressOneMail (0.00s) + offbox_ended_test.go:481: second press: created=true rec={App:vikunja RemovedAt:2026-11-15T12:58:17Z EndsAt:2026-12-15T12:58:17Z} err= — want the first record, unchanged +== MUTATION: a press mails nobody + RED on the mutant, GREEN on the real file + --- FAIL: TestD84_OnePressOneMail (0.00s) + offbox_ended_test.go:484: two presses gave 0 mail(s): [] — want ONE, for the record + +14 mutations, 0 not a red-proof + +### internal/backup/offbox.go +== MUTATION: the report does not carry the pending records + RED on the mutant, GREEN on the real file + --- FAIL: TestD72_TheReportCarriesThePendingRecords (0.00s) + offbox_ended_test.go:526: report = &{Enabled:true EscrowState:escrowed State: EndedApps:[] AbandonPurgeRequested:false LastRun: LastStatus: LastSuccess: SnapshotCount:0 RepoSizeBytes:0 QuotaGB:0 StatsKnown:false LastIntegrityCheck + +1 mutations, 0 not a red-proof + +### internal/backup/offbox_window.go +== MUTATION: the agreed ended ids are not removed + RED on the mutant, GREEN on the real file + --- FAIL: TestD72_TheEndedAppsOwnSnapshotsGoAndNothingElse (0.00s) + offbox_ended_test.go:185: removed [], want exactly vikunja's own three + --- FAIL: TestD72_ASharedSnapshotGoesWhenBothHaveEnded (0.00s) + offbox_ended_test.go:222: removed [], want both apps' snapshots and the shared one +== MUTATION: the claims are not sent to the hub + RED on the mutant, GREEN on the real file + --- FAIL: TestD72_TheEndedAppsOwnSnapshotsGoAndNothingElse (0.00s) + offbox_ended_test.go:179: the claim sent to the hub = [], want vikunja with v1,v2,v3 only (not the snapshot shared with immich) +== MUTATION: the result names ended ids that are still in the store + RED on the mutant, GREEN on the real file + --- FAIL: TestD84_TheResultNamesOnlyIdsThatAreReallyGone (0.00s) + offbox_ended_test.go:565: result = {ID:7 CountBefore:8 CountAfter:8 Removed:0 Outcome:error Reason:Fatal: unable to remove RemovedForEndedApps:[k1-full]} — a failed forget removed nothing, so nothing may be named as removed for en +== MUTATION: a carried-out end never becomes history + RED on the mutant, GREEN on the real file + --- FAIL: TestD72_ASharedSnapshotGoesWhenBothHaveEnded (0.00s) + offbox_ended_test.go:228: 2 record(s) still pending after every copy went +== MUTATION: the ended apps' ids are judged under the cap (D84 says beside it) + RED on the mutant, GREEN on the real file + --- FAIL: TestD84_OneGuard_AndTheAllowanceIsBesideTheCap (0.00s) + offbox_ended_test.go:350: removed 0 ([]), want the policy's 5 and vikunja's 3 + +5 mutations, 0 not a red-proof + +### internal/offsiteapply/seams.go +== MUTATION: an agreement is read from an answer that grants NO window + RED on the mutant, GREEN on the real file + --- FAIL: TestD84_WindowClient_SendsTheClaimsAndReadsTheAgreement (0.00s) + d84_window_client_test.go:59: not granted: {Granted:false ID:0 NewestAllowed:0001-01-01 00:00:00 +0000 UTC MaxRemove:0 Reason:not due EndedAllowed:[aa bb] EndedRefused:[]} — an agreement without a window must not reach the b +== MUTATION: the request does not carry the claims + RED on the mutant, GREEN on the real file + --- FAIL: TestD84_WindowClient_SendsTheClaimsAndReadsTheAgreement (0.00s) + d84_window_client_test.go:41: the hub did not receive the claim: null (unexpected end of JSON input) +== MUTATION: the agreement is not read from a granted window + RED on the mutant, GREEN on the real file + --- FAIL: TestD84_WindowClient_SendsTheClaimsAndReadsTheAgreement (0.00s) + d84_window_client_test.go:44: window = {Granted:true ID:9 NewestAllowed:2026-12-20 03:00:00 +0000 UTC MaxRemove:10 Reason: EndedAllowed:[] EndedRefused:[{App:immich Reason:the box's newest report lists the app as installed}]}, wan + +3 mutations, 0 not a red-proof + diff --git a/hub/internal/notify/d84_receipt_test.go b/hub/internal/notify/d84_receipt_test.go index f6af2209..ccd0d6f1 100644 --- a/hub/internal/notify/d84_receipt_test.go +++ b/hub/internal/notify/d84_receipt_test.go @@ -30,7 +30,7 @@ func receiptDispatcher(t *testing.T, prefsEmail string, enabled []string) (*Disp const ( receiptHU = "vikunja: az alkalmazás távoli másolatai törlésre vannak kijelölve. Törlésük napja: 2026. 12. 15. Addig a Mentések oldalon a „Mégis megtartom” gombbal visszavonhatod." - receiptEN = "vikunja: the off-site copies of this app are marked for deletion. They are deleted on: 2026-12-15. Until then you can take this back on the Backups page with the \"Keep it after all\" button." + receiptEN = "vikunja: the off-site copies of this app are marked for deletion. They are deleted on: 2026-12-15. Until then you can take this back on the Backups page with the “Keep it after all” button." receiptDetails = `{"stack_name":"vikunja","removed_at":"2026-11-15T10:00:00Z","ends_at":"2026-12-15T10:00:00Z","subject":"vikunja|2026-11-15T10:00:00Z"}` ) diff --git a/hub/internal/notify/mail_golden_test.go b/hub/internal/notify/mail_golden_test.go index dc9a3627..8439f84c 100644 --- a/hub/internal/notify/mail_golden_test.go +++ b/hub/internal/notify/mail_golden_test.go @@ -101,7 +101,7 @@ func customerMailCases(lang string) []mailCase { box := "vikunja: az alkalmazás távoli másolatai törlésre vannak kijelölve. Törlésük napja: 2026. 12. 15. Addig a Mentések oldalon a „Mégis megtartom” gombbal visszavonhatod." household := "" if lang == "en" { - household = "vikunja: the off-site copies of this app are marked for deletion. They are deleted on: 2026-12-15. Until then you can take this back on the Backups page with the \"Keep it after all\" button." + household = "vikunja: the off-site copies of this app are marked for deletion. They are deleted on: 2026-12-15. Until then you can take this back on the Backups page with the “Keep it after all” button." } return FormatCustomerEmail(lang, "demo-fixture", "offsite_end_scheduled", "info", box, household, `{"stack_name":"vikunja","removed_at":"2026-11-15T10:00:00Z","ends_at":"2026-12-15T10:00:00Z","subject":"vikunja|2026-11-15T10:00:00Z"}`) diff --git a/hub/internal/notify/testdata/mail_goldens/en/customer_shape_offsite_end_scheduled_receipt.txt b/hub/internal/notify/testdata/mail_goldens/en/customer_shape_offsite_end_scheduled_receipt.txt index 2380a448..ab45c02d 100644 --- a/hub/internal/notify/testdata/mail_goldens/en/customer_shape_offsite_end_scheduled_receipt.txt +++ b/hub/internal/notify/testdata/mail_goldens/en/customer_shape_offsite_end_scheduled_receipt.txt @@ -12,7 +12,7 @@ Details: - Time: 2026-01-15 10:30 - Level: Information - Type: offsite_end_scheduled -- Message: vikunja: the off-site copies of this app are marked for deletion. They are deleted on: 2026-12-15. Until then you can take this back on the Backups page with the "Keep it after all" button. +- Message: vikunja: the off-site copies of this app are marked for deletion. They are deleted on: 2026-12-15. Until then you can take this back on the Backups page with the “Keep it after all” button. If you have any questions, contact your operator.