hub (unreleased): review fix 3 — a name that reaches a household's mail is a plain app slug; a link-shaped name gets no notice and is never agreed
Claude-Session: https://claude.ai/code/session_0159rPz1ZhFKsS53msqPYxtS
This commit is contained in:
1 parent
7b46dbcc3e
commit
73a534e753
7 files changed
+131
-3
No files matched your search
@@ -0,0 +1,20 @@
|
||||
# Review finding 3 — a link-shaped name in the household's subject. The test on the code BEFORE the fix (ValidNoticeApp = the app record's rule):
|
||||
--- FAIL: TestReview3_ALinkShapedNameNeverReachesTheHousehold (0.05s)
|
||||
end_notice_review_test.go:24: "www.evil-bank.example.com" reached the household: subject "[Felhom] www.evil-bank.example.com: a távoli másolatok törlésének napja: 2026. 12. 15."
|
||||
FAIL
|
||||
FAIL gitea.dooplex.hu/admin/felhom-hub/internal/api 0.075s
|
||||
FAIL
|
||||
|
||||
# After the fix, by mutation:
|
||||
== MUTATION: a name the household cannot be told about is agreed when a row says told
|
||||
RED on the mutant, GREEN on the real file
|
||||
--- FAIL: TestReview3_ANameThatCannotBeToldIsNeverAgreed (0.00s)
|
||||
notice_lock_test.go:163: "www.evil-bank.example.com": agreed [a1b2c685], refused []
|
||||
|
||||
1 mutations, 0 not a red-proof
|
||||
== MUTATION: a dot is allowed in a notice name again
|
||||
RED on the mutant, GREEN on the real file
|
||||
--- FAIL: TestReview3_ALinkShapedNameNeverReachesTheHousehold (0.05s)
|
||||
end_notice_review_test.go:24: "www.evil-bank.example.com" reached the household: subject "[Felhom] www.evil-bank.example.com: a távoli másolatok törlésének napja: 2026. 12. 15."
|
||||
|
||||
1 mutations, 0 not a red-proof
|
||||
Reference in new issue
Block a user