diff --git a/REPORT.md b/REPORT.md index c8a0cab1..ddcfd6e9 100644 --- a/REPORT.md +++ b/REPORT.md @@ -1,42 +1,41 @@ -# REPORT — health check after a few unattended days (2026-11-14, morning, attended) +# REPORT — Security review, round 2 (2026-11-19) — IN PROGRESS -**Plain words first.** The three test boxes are healthy. Backups ran last night on all three, off-site too, and each -restore proof passed. The night CI mail was red for three nights for one reason: a dated check (R-528) was due. The -check is now read and written down, and CI is green for it. Two new rows are filed. Nothing was changed on any box. +> A second, independent reader of our own code. Find and file; no fixes. This header is Phase 0. +> The plain-language summary is written in Phase 4. -**Method.** Read only. The hub's own pages with CC's token (Dashboard, Hosts, System, Offsite); one copy of the hub -database **with its WAL** (newest host report 7 minutes old, `quick_check` ok; the copy was shredded after the read); -the hub log's deadline lines; the operator mailbox (label Monitoring, last 5 days); the CI run log of run id 2632 -(job 2636) through the Gitea API. +## Baselines (the commits reviewed — every finding is evidence about these commits only) -| | | -|---|---| -| Boxes | demo-felhom, demo-hp, Tester 1: controller 0.352.0, agent 0.173.0, ONLINE, all containers running, crash guard armed, 0 crash restarts | -| Backups last night | DB dumps 03:15–03:17 UTC; off-site `ok` 03:15–03:18 UTC; off-site restore proof `pass` 04:30 UTC (bentopdf, opengist, bookstack); whole-guest backups `success`; host restore tests `pass` (demo-hp from PBS 2026-11-14 02:43 UTC) | -| CI red ×3 nights (runs 2628, 2630, 2632) | only gate `due-checks`: R-528 was due 2026-11-12. Read and recorded (below), date moved to 2026-11-28 with the reason in the row | -| R-528 reading | NOT closed. One failed `oom_check` — demo-felhom 2026-11-11 04:40:30 UTC, Docker 29.9.3 / containerd 2.4.2-3: exit 137, `OOMKilled=false`, no `oom` event. 56 others passed. The four `app_oom` events since 2026-10-12 are all explained (a freeze, a squeeze test, a release proof) | -| Tester4 | Host deleted by the operator 07:54:31 UTC. The pairing-link mail at the same second is by design (a host delete that keeps the customer). The 05:00 `expected_dbdump_missed` came before the delete; the host's reports are gone with it, so the deadline check reads „not judged yet" from tomorrow (as Tester 2 does) | -| demo-hp blips | `agent_channel_unknown` 2026-11-11 13:52 → recovered 14:00 UTC (the certificate-pin spike on demo-hp that afternoon); `health_degraded` 2026-11-12 03:17 → recovered 03:22 UTC (a controller restart in the night step) | -| Security watch | New: 4 FileBrowser notices (one high, arbitrary file write) fixed only on 2.1.0 — belongs to R-1305; Go 1.27.3 GO-2026-6859 had no row → R-1391; cloudflared is R-1358 | -| Register | 248 rows at the start, 250 at the end. Opened R-1391 (Go 1.27.4), R-1392 (root files amber after every agent release). Closed 0. Dated line on R-528 | +| repo | reviewed commit (`main`) | October's commit (for „changed since") | +|---|---|---| +| `felhom.eu` (hub, website, manifests, scripts, installer) | `b7d8f75b` | `0d463a85` (hub 0.147.0); the October fix was `b67b8cea` (hub 0.148.0) | +| `felhom-controller` | `10df99b8` | `dcd89364` | +| `felhom-agent` | `34115920` | `86adbcaf` | +| `app-catalog-felhom.eu` | `b6058150` | `1a642b4` (the head on 2026-10-12 morning; October's report names no catalog commit) | +| `homelab-manifests` | `1908bc68` (clone at `~/git/homelab-manifests`; it is not in the workspace folder) | — | -## Findings +Deployed: hub **0.182.0** (`manifests/hub.yaml:135`). Scratch box `demo-hp`: agent **0.175.1**, controller **0.353.0** +in guests 9201 and 9202 (read on the box, 2026-11-19). -1. **R-1392 — the yellow „root files behind the vouched agent's" on all three boxes is a false amber, and it becomes - three operator alarms around 2026-11-17.** The files on the boxes are the vouched ones (`configs/` did not change - between 0.172.1 and 0.173.0), but the hub compares the whole bundle's sha256, which carries the version. -2. **R-1391 — Go 1.27.3 in hub, controller and agent; fixed in 1.27.4.** Reach not measured. -3. **CI turns red again after 2026-11-15:** R-1050 (HSTS one year) is due that day and needs a controller release. +**The shared clone was not clean at the start.** Another session holds uncommitted hub changes in +`hub/internal/{api,store,web}` and two lines of `OPEN-ITEMS.md`. This review reads an export of the commits above +(`git archive`), not the working tree, and stages only its own files. -## Waiting on the operator +## Repository visibility (anonymous GET, no token, from DooPlex, 2026-11-19 08:40 CET) -- Rotate `GITEA_GIT_TOKEN` (the secret sweep mail of 2026-11-12 found it in 2 session records), then `sec put`. -- Approve the Proxmox set 9.2.26 and kernel 7.0.14-28 on the System page when you want Tester 1 to follow. -- R-1392: A or B (in the row). Sending the 0.173.0 bundle to the three boxes clears today's amber either way. +| repository | page | `info/refs` (clone) | +|---|---|---| +| `admin/felhom.eu` | 200 | 200 | +| `admin/felhom-controller` | 200 | 200 | +| `admin/felhom-agent` | 200 | 200 | +| `admin/app-catalog-felhom.eu` | 200 | 200 | +| `admin/homelab-manifests` | 404 | — | -**Fixed without a row:** the local `instructions` gate (and its decoy test) failed because the memory index was 201 -lines / 25 725 bytes (ceilings 200 / 25 600). Two index lines were merged; now 199 / 25 571. Not a repo file. +The registry answers 401 to an anonymous `/v2/`, `/v2/_catalog` and a hub image manifest. Gitea's anonymous repository +search also lists `admin/misc-scripts`, `admin/recipe-importer`, `admin/revfulop-calendar` (not Felhom). +**So: assume the attacker has read all product source** (accepted, R-925 / `13` §6). +Limit of this measurement: the request left DooPlex; the name resolves to the public address, but no request was made +from outside the LAN. -**Not done:** no box touched, no signed job sent, no hub change, no release. No area CHANGELOG entry: the change is -register-only (`hub/`, `scripts/`, `website/`, `marketing/` untouched). Provisioned nothing; teardown: the hub DB copy -in the scratchpad was shredded. +## Scratch target today + +`demo-hp` (`ssh hp`), guest 9202 (`demo-hp-scratch`) — `documentation/runbooks/target-selection.md`, Tier 0. diff --git a/documentation/audits/security-review-2-2026-11-19/COVERAGE.md b/documentation/audits/security-review-2-2026-11-19/COVERAGE.md new file mode 100644 index 00000000..3f3417a6 --- /dev/null +++ b/documentation/audits/security-review-2-2026-11-19/COVERAGE.md @@ -0,0 +1,14 @@ +# Coverage — security review 2 (2026-11-19) + +Reviewed commits: see `REPORT.md`. An area not yet written here is **not reviewed yet**. + +| area | state | +|---|---| +| C2 hub | not reviewed yet | +| C4 hub → agent jobs | not reviewed yet | +| C5 supply chain | not reviewed yet | +| C1 box from the internet | not reviewed yet | +| C3 controller → agent | not reviewed yet | +| C6 secrets | not reviewed yet | +| C7 host and guest hardening | not reviewed yet | +| C8 public sites | not reviewed yet |