From 1d94b1a9e9c0cf4f369d18b1cd973daf3adfbfef Mon Sep 17 00:00:00 2001 From: kisfenyo Date: Sun, 12 Jul 2026 17:37:04 +0200 Subject: [PATCH] hub: scoped auto-refresh + style.css cache-bust + staging rule (v0.48.0 parts 3-4) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit - Auto-refresh: the 60s reload fires only while a live tab is active (nav data-live-tabs="overview,applications,events,host") AND no form is dirty (delegated input/change listener; never reset — a reload clears it). Skipped ticks reschedule; a muted (paused) hint shows next to the toggle on non-live tabs / dirty forms. Toggle, localStorage key, 60s cadence, and default-on behavior unchanged. The refresh script resolves the legacy settings→edit hash alias like the tabs script. - Rider 4a: every template's stylesheet link is /style.css?v={{hubVersion}} (the v0.47.0 gotcha: max-age=3600 served stale styling for up to an hour after a deploy). Red-proof run: a reverted bare link fails the test. - Rider 4b: CLAUDE.md standing rule — never git add -A in this repo (the 146d165 sweep incident); explicit paths + pull-rebase + one writing session per clone. - Tests: Group C structural pins (attribute read, dirty listeners, alias x2, hint element, cadence/key survivors) + Group D cache-bust over six pages. Co-Authored-By: Claude Fable 5 Claude-Session: https://claude.ai/code/session_01TZc5w5jDhFLv6qDC32KN5v --- CLAUDE.md | 4 + hub/internal/web/refresh_cachebust_test.go | 114 ++++++++++++++++++ hub/internal/web/templates/app_detail.html | 2 +- hub/internal/web/templates/apps.html | 2 +- hub/internal/web/templates/configs.html | 2 +- hub/internal/web/templates/configuration.html | 2 +- .../web/templates/customer_unified.html | 51 ++++++-- hub/internal/web/templates/dashboard.html | 2 +- hub/internal/web/templates/host_detail.html | 2 +- hub/internal/web/templates/hosts.html | 2 +- hub/internal/web/templates/log_tail.html | 2 +- hub/internal/web/templates/offsite.html | 2 +- 12 files changed, 170 insertions(+), 17 deletions(-) create mode 100644 hub/internal/web/refresh_cachebust_test.go diff --git a/CLAUDE.md b/CLAUDE.md index 470ae81..a84d20a 100644 --- a/CLAUDE.md +++ b/CLAUDE.md @@ -77,6 +77,10 @@ pushes; **you (Claude Code) implement**. A file being open in the editor is NOT > **Never write secrets** into any committed file — reference them as "stored out-of-band". - Update `REUSE.md` if you added/changed/deprecated a shared helper or pattern (same commit). +- **Never `git add -A` in this repo** — parallel sessions share the clone and it sweeps foreign + WIP (the v0.47.0 `146d165` incident: a red-proof-mutated guard got swept to `main`). Stage + explicit paths only, `git pull --rebase` before every push, and do not run two writing + sessions on one clone (use `git worktree` if truly needed). ## Tech stack (Hub) diff --git a/hub/internal/web/refresh_cachebust_test.go b/hub/internal/web/refresh_cachebust_test.go new file mode 100644 index 0000000..6729875 --- /dev/null +++ b/hub/internal/web/refresh_cachebust_test.go @@ -0,0 +1,114 @@ +package web + +// v0.48.0 parts 3+4a — scoped auto-refresh (Group C: structural pins; live behavior is validated +// in the browser per the task's §13) and the style.css cache-bust rider (Group D). + +import ( + "net/http/httptest" + "strings" + "testing" + + "gitea.dooplex.hu/admin/felhom-hub/internal/store" +) + +// Group C — the refresh machinery's server-rendered structure: the live-tab list is DATA on the +// nav, the script consumes that attribute (not a hardcoded copy), a delegated dirty listener +// exists, and the legacy #tab=settings hash still lands on the Edit tab. +func TestCustomerRefresh_ScopedStructure(t *testing.T) { + s, st := newTestServer(t) + if err := st.SaveCustomerConfig(&store.CustomerConfig{ + CustomerID: "c1", CustomerName: "Acme", Domain: "acme.hu", + RetrievalPassword: "pw", APIKey: "k", Status: "active", + }); err != nil { + t.Fatal(err) + } + // The toggle + refresh script render only with reports. + if err := st.SaveReport("c1", []byte(tabsTestReportJSON)); err != nil { + t.Fatal(err) + } + html := renderCustomerPage(t, s, "c1") + + // The nav carries the live-tab set (edit/setup/backup/notifications are deliberately absent). + if !strings.Contains(html, `data-live-tabs="overview,applications,events,host"`) { + t.Error("tab nav missing the data-live-tabs attribute") + } + // The script READS the attribute — the literal appears beyond the nav markup itself. + if !strings.Contains(html, `getAttribute('data-live-tabs')`) { + t.Error("refresh script does not read data-live-tabs (hardcoded live set?)") + } + // Delegated dirty listener: any input anywhere pauses the reload. + if !strings.Contains(html, `document.addEventListener('input', markDirty)`) || + !strings.Contains(html, `document.addEventListener('change', markDirty)`) { + t.Error("delegated input/change dirty listeners missing") + } + // Legacy hash alias: #tab=settings activates the Edit tab — in the tabs script AND the + // refresh script's live-tab resolution. + if got := strings.Count(html, `if (t === 'settings') t = 'edit';`); got != 2 { + t.Errorf("settings→edit alias count = %d, want 2 (tabs script + refresh script)", got) + } + // The (paused) hint element next to the toggle. + if !strings.Contains(html, `id="refresh-paused-hint"`) { + t.Error("(paused) hint element missing") + } + // The cadence, key, and toggle survived the rework. + for _, want := range []string{"60000", "hub_auto_refresh", `id="autoRefreshToggle"`} { + if !strings.Contains(html, want) { + t.Errorf("refresh machinery missing %q", want) + } + } +} + +// Group D — every rendered page's stylesheet link carries the version cache-bust (the v0.47.0 +// gotcha: /style.css is served with max-age=3600, so an unversioned link shows stale styling for +// up to an hour after a deploy). RED-PROOF: reverting one template's link to a bare +// href="/style.css" fails that page's negative assertion. +func TestTemplates_StyleCSSCacheBust(t *testing.T) { + s, st := newTestServer(t) // version = "test" → the link must be /style.css?v=test + if err := st.SaveCustomerConfig(&store.CustomerConfig{ + CustomerID: "c1", CustomerName: "Acme", Domain: "acme.hu", + RetrievalPassword: "pw", APIKey: "k", Status: "active", + }); err != nil { + t.Fatal(err) + } + if err := st.UpsertHost(&store.Host{HostID: "h1", CustomerID: "c1", APIKey: "hk"}); err != nil { + t.Fatal(err) + } + + pages := map[string]func() string{ + "dashboard": func() string { + rr := httptest.NewRecorder() + s.handleDashboard(rr, httptest.NewRequest("GET", "/", nil)) + return rr.Body.String() + }, + "customer": func() string { return renderCustomerPage(t, s, "c1") }, + "host detail": func() string { + rr := httptest.NewRecorder() + s.handleHostDetail(rr, httptest.NewRequest("GET", "/hosts/h1", nil), "h1") + return rr.Body.String() + }, + "offsite": func() string { + rr := httptest.NewRecorder() + s.handleOffsite(rr, httptest.NewRequest("GET", "/offsite", nil)) + return rr.Body.String() + }, + "customers list": func() string { + rr := httptest.NewRecorder() + s.handleConfigList(rr, httptest.NewRequest("GET", "/configs", nil)) + return rr.Body.String() + }, + "config form (standalone)": func() string { + rr := httptest.NewRecorder() + s.handleConfigNewForm(rr, httptest.NewRequest("GET", "/configs/new", nil)) + return rr.Body.String() + }, + } + for name, render := range pages { + html := render() + if !strings.Contains(html, `href="/style.css?v=test"`) { + t.Errorf("%s: stylesheet link missing the ?v={{hubVersion}} cache-bust", name) + } + if strings.Contains(html, `href="/style.css"`) { + t.Errorf("%s: bare /style.css link remains", name) + } + } +} diff --git a/hub/internal/web/templates/app_detail.html b/hub/internal/web/templates/app_detail.html index 0fff544..7cda896 100644 --- a/hub/internal/web/templates/app_detail.html +++ b/hub/internal/web/templates/app_detail.html @@ -4,7 +4,7 @@ {{.AppName}} — Felhom Hub - + diff --git a/hub/internal/web/templates/apps.html b/hub/internal/web/templates/apps.html index a492d75..738458b 100644 --- a/hub/internal/web/templates/apps.html +++ b/hub/internal/web/templates/apps.html @@ -4,7 +4,7 @@ Apps — Felhom Hub - + {{template "icon_sprite"}} diff --git a/hub/internal/web/templates/configs.html b/hub/internal/web/templates/configs.html index 8e00693..9d9e75e 100644 --- a/hub/internal/web/templates/configs.html +++ b/hub/internal/web/templates/configs.html @@ -4,7 +4,7 @@ Felhom Hub — Customers - + {{template "icon_sprite"}} diff --git a/hub/internal/web/templates/configuration.html b/hub/internal/web/templates/configuration.html index ec09b5a..a0fc932 100644 --- a/hub/internal/web/templates/configuration.html +++ b/hub/internal/web/templates/configuration.html @@ -4,7 +4,7 @@ Configuration — Felhom Hub - + {{template "icon_sprite"}} diff --git a/hub/internal/web/templates/customer_unified.html b/hub/internal/web/templates/customer_unified.html index 16924b3..0d3b0a6 100644 --- a/hub/internal/web/templates/customer_unified.html +++ b/hub/internal/web/templates/customer_unified.html @@ -4,7 +4,7 @@ {{if .CustomerName}}{{.CustomerName}}{{else}}{{.CustomerID}}{{end}} — Felhom Hub - + @@ -32,6 +32,7 @@ Auto-refresh +

{{else}} @@ -84,8 +85,9 @@ {{end}} -