admin
e66d4669d6
gates / gates (push) Failing after 47s
An app was six pages — details, install/settings, logs, export, the per-app backup panel and a
details card for moving data — and every "Vissza" on them went to the app LIST, so there was no way
back to the app you were looking at. It is now ONE page with four tab URLs under /apps/{slug}/,
one shared header and one set of banners.
settings Mukodes (Start/Restart/Stop, Stop confirms) + the cards that want something from the
household + the install-time and optional settings. The default for an installed app,
RENDERED at the bare URL and never redirected to.
data the data folders, move to another drive, the nightly copy, the 2nd-copy setting, export
guide tagline, screenshots, use cases, first steps, the catalog's guide, the FAQ, the docs
link — and the WHOLE page for an app that is not installed
logs the log, and the only tab whose poller runs
The tabs are links, not panels: a link in an alert has to land ON a tab, and the log poller must not
run on the other three. Start/Restart/Stop left the page header, where they read as menu buttons.
The old /stacks/{name}/{deploy,logs,export,backup} GETs answer 302 — never 301, which a browser
caches beyond anyone's reach — to the tab that now holds them, query string carried through, with
name->slug resolved through the stack list rather than assumed equal. Every POST on those paths is
untouched: the backup form, the app-email toggle and the reveal endpoints keep their URLs.
A value asked AFTER the app starts is now generic (D2). The catalog marks a field `after_start: true`
and supplies its label; the ACTION is Go, in a registry keyed by slug + env var. The catalog can
never declare what runs — a declared field with no registered action renders nothing, POSTs 404 and
logs one WARN with the env var KEY, never the value. A red-proof found the second half of that guard
unpinned: deleting the "the catalog must have DECLARED this field" check left the suite green, and a
POST for an undeclared field then reached Plex and opened the setup gate.
TestAfterStart_RegistryAloneIsNotAnInvitation pins it.
New catalog block app_info.guide (sections + faq + checked_version), parsed, localised field by
field and rendered with the household's own address filled in. It renders only when checked_version
names the image tag its author clicked through. No template carries one yet.
The Pi and "csak x86" badges are gone; PiCompatible and the catalog key stay this release, or a box
on 0.314.0 would read "csak x86" on every app (R-1067).
template_id_gate.py now follows {{template}} includes, with a scope decoy proving the walk did not
become vacuous.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_0117kRTSgs3rJWUFGxyoWN6Y
82 lines
3.2 KiB
Go
82 lines
3.2 KiB
Go
package web
|
|
|
|
import (
|
|
"context"
|
|
"html"
|
|
"net/http/httptest"
|
|
"os"
|
|
"path/filepath"
|
|
"strings"
|
|
"testing"
|
|
"time"
|
|
|
|
"gitea.dooplex.hu/admin/felhom-controller/internal/stacks"
|
|
)
|
|
|
|
// heldGuards holds every app; nothing else is exercised by the page.
|
|
type heldGuards struct{}
|
|
|
|
func (heldGuards) HoldFor(string) (bool, string) { return true, "HOLD SENTENCE" }
|
|
func (heldGuards) Busy(string) (bool, string) { return false, "" }
|
|
func (heldGuards) RestorePoints(context.Context, string, func(stacks.UpdateRestorePoint) bool) (stacks.UpdateRestorePoint, bool, []stacks.UpdateRestorePoint) {
|
|
return stacks.UpdateRestorePoint{}, false, nil
|
|
}
|
|
func (heldGuards) CanBackUp(string) (bool, string) { return false, "" }
|
|
func (heldGuards) BackupNow(context.Context, string) error { return nil }
|
|
func (heldGuards) SafetyDump(context.Context, string) ([]string, error) { return nil, nil }
|
|
func (heldGuards) HoldAfterFailedUpdate(string, time.Time, stacks.UpdateRestorePoint, string) error {
|
|
return nil
|
|
}
|
|
|
|
// R-621 (the last half): the app page's HOLD PANEL points at the log the hold kept. Driven through the
|
|
// REAL handler (appCommonData) and the REAL template, both languages, with the kept-log file present
|
|
// and absent — a render per branch of the gate (seam-wiring rule).
|
|
//
|
|
// COMPANION RED-PROOF: drop the HoldLogKept block from appCommonData — the "kept" branch fails.
|
|
func TestR621_HoldPanelPointsAtTheKeptLog(t *testing.T) {
|
|
s, _ := credsHarness(t)
|
|
s.stackMgr.SetUpdateGuards(heldGuards{})
|
|
s.loadTemplates()
|
|
sd := filepath.Join(s.cfg.Paths.StacksDir, "crafty")
|
|
|
|
render := func(lang string) string {
|
|
rr := httptest.NewRecorder()
|
|
s.appPageHandler(rr, httptest.NewRequest("GET", "/apps/crafty?lang="+lang, nil), "crafty", "")
|
|
return html.UnescapeString(rr.Body.String())
|
|
}
|
|
const link = `<a href="/apps/crafty/logs" class="btn btn-sm btn-outline">`
|
|
const huLine, enLine = "Az alkalmazás saját naplója megmaradt", "The app's own log from before it was stopped was kept"
|
|
|
|
// No kept log: the panel is there (positive control) and says nothing about a log.
|
|
h := render("hu")
|
|
if !strings.Contains(h, `data-held="true"`) {
|
|
t.Fatal("positive control: the held panel must render — nothing below would be judged")
|
|
}
|
|
if strings.Contains(h, `data-hold-log="true"`) {
|
|
t.Error("with no kept log the panel must not claim one")
|
|
}
|
|
|
|
p := filepath.Join(sd, "hold-logs", "20260922T080000Z")
|
|
if err := os.MkdirAll(p, 0o755); err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
if err := os.WriteFile(filepath.Join(p, "compose-logs.txt"), []byte("web-1 | never bound :8000\n"), 0o644); err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
for _, tc := range []struct{ lang, want, notWant string }{{"hu", huLine, enLine}, {"en", enLine, huLine}} {
|
|
h := render(tc.lang)
|
|
i := strings.Index(h, `data-held="true"`)
|
|
if i < 0 {
|
|
t.Fatalf("%s: the held panel is gone", tc.lang)
|
|
}
|
|
panel := h[i:]
|
|
panel = panel[:strings.Index(panel, "</div>")]
|
|
if !strings.Contains(panel, `data-hold-log="true"`) || !strings.Contains(panel, tc.want) || !strings.Contains(panel, link) {
|
|
t.Errorf("%s: the hold panel must say the log was kept and link the logs page; panel=%q", tc.lang, panel)
|
|
}
|
|
if strings.Contains(panel, tc.notWant) {
|
|
t.Errorf("%s: the other language's sentence is on the page", tc.lang)
|
|
}
|
|
}
|
|
}
|