admin
8dbbc98ff2
gates / gates (push) Successful in 18s
R-249. settings_security.html rendered the passphrase into a display:none span behind a Megjelenit button. That toggle stops a browser DRAWING the value and nothing else — the plaintext was in the response body of every render, so a curl of the page returned it. Found by exactly that: it landed in a session transcript while driving the documented rebuild path. The codebase already stated this rule for the recovery code and this page did not follow it (escrow_handlers.go: 'reveal (claim XHR only — R is NEVER templated server-side into HTML)'). The page now carries only HasRetrievalPassword; the value comes from POST /settings/retrieval-password/reveal — CSRF-covered because POST, no-store, and LOGGED as an act, which reading it off the markup never was. The tests assert the RAW RESPONSE BODY. Every test that asked what the customer sees passed while the bytes carried the secret; that is why this survived. Census: the render-then-hide pattern appears twice more — app_info.html (a real per-install app password in a hidden span) and deploy.html. Filed as R-254, NOT fixed here. R-252. A rebuilt box keeps its drives but loses their REGISTRATION. The restore page now states that before the customer presses anything, says the backups and drives are both still there, and links to Tarhely > Meghajtok. Page and resolver ask ONE question — HasRestoreDestination() reads the same GetSchedulableStoragePaths() the scratch resolver reads. R-253. The list promised 'a visszaallitas elobb ujratelepiti' three lines above a refusal that fired BECAUSE the app was not installed. The promise was the wrong half: reconstitution writes to the app's own GetStackHDDPath, which exists only once the CUSTOMER has chosen a drive at deploy time. Auto-reinstalling would mean the product making that choice for them. Copy now says to install first and routes to /stacks/<app>/deploy. Both notices are conditional — a healthy box renders as before, pinned by a test that fails if either becomes unconditional.
47 lines
2.1 KiB
Go
47 lines
2.1 KiB
Go
package backup
|
|
|
|
import (
|
|
"strings"
|
|
"testing"
|
|
|
|
"gitea.dooplex.hu/admin/felhom-controller/internal/settings"
|
|
)
|
|
|
|
// R-252 — THE PAGE'S QUESTION AND THE RESOLVER'S ANSWER ARE THE SAME QUESTION.
|
|
//
|
|
// The restore page renders its "re-attach your drive" notice from HasRestoreDestination(); every
|
|
// restore refuses from offboxRestoreScratchDir(). If those two ever disagree the page either warns a
|
|
// box that would restore fine, or stays silent on one that cannot — and the second is R-252 exactly
|
|
// as the fifth walk met it. So this asserts the CONSEQUENCE (does the resolver refuse?) against the
|
|
// predicate the page renders from, on one fixture.
|
|
//
|
|
// RED-PROOF: make HasRestoreDestination return true unconditionally and the first block fails — the
|
|
// predicate claims a destination while the resolver refuses in the very next assertion.
|
|
func TestHasRestoreDestination_AgreesWithTheResolver(t *testing.T) {
|
|
m, sett := bareManager(t)
|
|
|
|
// No registered storage path: the resolver refuses, and the predicate must say so.
|
|
if m.HasRestoreDestination() {
|
|
t.Error("HasRestoreDestination() is true with no registered storage path — the restore page " +
|
|
"would stay silent while every restore refuses")
|
|
}
|
|
if _, _, err := m.offboxRestoreScratchDir("calibre-web"); err == nil {
|
|
t.Fatal("the resolver found a destination with no registered storage path — fixture is wrong, " +
|
|
"so the agreement below would prove nothing")
|
|
} else if !strings.Contains(err.Error(), "Tárhely") {
|
|
t.Errorf("the refusal names no route: %v", err)
|
|
}
|
|
|
|
// Re-attach a drive, exactly as the customer does from Tárhely → Meghajtók.
|
|
if err := sett.AddStoragePath(settings.StoragePath{Path: "/mnt/felhom-drives/adatok", Label: "Adatok", Schedulable: true}); err != nil {
|
|
t.Fatalf("register storage path: %v", err)
|
|
}
|
|
if !m.HasRestoreDestination() {
|
|
t.Error("HasRestoreDestination() is still false after the drive was re-attached — the notice " +
|
|
"would stay on screen after the customer fixed the thing it asked them to fix")
|
|
}
|
|
if _, _, err := m.offboxRestoreScratchDir("calibre-web"); err != nil {
|
|
t.Errorf("the resolver still refuses after a drive was registered: %v", err)
|
|
}
|
|
}
|