felhom-controller/controller/internal/api/kept_install_test.go

package api

import (
	"context"
	"encoding/json"
	"io"
	"log"
	"net/http"
	"net/http/httptest"
	"os"
	"path/filepath"
	"testing"
	"time"

	"gitea.dooplex.hu/admin/felhom-controller/internal/backup"
	"gitea.dooplex.hu/admin/felhom-controller/internal/config"
	"gitea.dooplex.hu/admin/felhom-controller/internal/settings"
	"gitea.dooplex.hu/admin/felhom-controller/internal/stacks"
)

// `09` §3 decision 36 — the install API answers an install over old data with the CHOICE (409,
// code kept_data_choice, both sentences, "use" OFF when no database copy exists) and installs nothing;
// "use" without a copy is refused; "fresh" is left to DeployStack. Nothing here reaches Docker.
// COMPANION RED-PROOF: make keptDataAtInstall return false at once → the no-choice case writes nothing
// and the first assertion fails (the install would go on to DeployStack).
func TestKept_InstallAPIAsksAndInstallsNothing(t *testing.T) {
	dir := t.TempDir()
	drive := filepath.Join(dir, "drive")
	cfg := &config.Config{}
	cfg.Paths.StacksDir = filepath.Join(dir, "stacks")
	cfg.Stacks.ComposeCommand = "docker compose"
	app := filepath.Join(cfg.Paths.StacksDir, "cloudapp")
	for _, d := range []string{app, filepath.Join(drive, "appdata/cloudapp")} {
		if err := os.MkdirAll(d, 0o755); err != nil {
			t.Fatal(err)
		}
	}
	_ = os.WriteFile(filepath.Join(app, "docker-compose.yml"), []byte("services:\n  cloudapp:\n    image: busybox\n    volumes:\n      - ${HDD_PATH}/appdata/cloudapp:/data\n"), 0o644)
	_ = os.WriteFile(filepath.Join(app, ".felhom.yml"), []byte("display_name: Cloud App\n"), 0o644)
	_ = os.WriteFile(filepath.Join(drive, "appdata/cloudapp/old.txt"), []byte("old"), 0o644)
	m, err := stacks.NewManager(cfg, log.New(io.Discard, "", 0))
	if err != nil {
		t.Fatal(err)
	}
	if err := m.ScanStacks(); err != nil {
		t.Fatal(err)
	}
	r := &Router{stackMgr: m, logger: log.New(io.Discard, "", 0)}

	call := func(choice string) (bool, int, map[string]interface{}) {
		w := httptest.NewRecorder()
		req := httptest.NewRequest(http.MethodPost, "/api/stacks/cloudapp/deploy?lang=en", nil)
		handled := r.keptDataAtInstall(w, req, "cloudapp", drive, choice)
		var body map[string]interface{}
		_ = json.Unmarshal(w.Body.Bytes(), &body)
		return handled, w.Code, body
	}
	handled, code, body := call("")
	data, _ := body["data"].(map[string]interface{})
	if !handled || code != http.StatusConflict || data["code"] != "kept_data_choice" {
		t.Fatalf("no choice: handled=%v code=%d body=%v", handled, code, body)
	}
	if data["title"] != "This app's old data is still here" || data["use_offered"] != false ||
		data["use_off"] != "There is no backup of the database, so the app cannot load the old files. You can look at the files under Kept data." ||
		data["fresh_label"] != "Start fresh" || data["not_backed_up"] != "This is not backed up." {
		t.Fatalf("the choice's sentences: %v", data)
	}
	if handled, code, _ := call("use"); !handled || code != http.StatusConflict {
		t.Fatalf("use with no copy: handled=%v code=%d", handled, code)
	}
	if handled, _, _ := call("fresh"); handled {
		t.Fatal("fresh must be left to DeployStack (which moves the old data aside)")
	}
	if st, _ := m.GetStack("cloudapp"); st.Deployed || st.Deploying {
		t.Fatal("something was installed")
	}
	// No old data → the API does not interfere.
	_ = os.RemoveAll(filepath.Join(drive, "appdata/cloudapp"))
	if handled, _, _ := call(""); handled {
		t.Fatal("an install with no old data was intercepted")
	}
}

// R-691 (2) — when the only database copy of kept files is OFF-SITE, the install choice offers „use" and
// names that copy and its date; before v0.277.0 it said "no backup". The repository is the restic runner
// seam; nothing reaches restic, ssh or Docker.
// COMPANION RED-PROOF: keptDataAtInstall back on KeptDBCopy (0.276.0) → use_offered=false and this fails.
func TestR691_InstallChoiceNamesTheOffsiteCopy(t *testing.T) {
	dir := t.TempDir()
	drive := filepath.Join(dir, "drive")
	cfg := &config.Config{}
	cfg.Paths.StacksDir = filepath.Join(dir, "stacks")
	cfg.Paths.DataDir = filepath.Join(dir, "data")
	cfg.Stacks.ComposeCommand = "docker compose"
	app := filepath.Join(cfg.Paths.StacksDir, "cloudapp")
	for _, d := range []string{app, filepath.Join(drive, "appdata/cloudapp"), cfg.Paths.DataDir} {
		if err := os.MkdirAll(d, 0o755); err != nil {
			t.Fatal(err)
		}
	}
	_ = os.WriteFile(filepath.Join(app, "docker-compose.yml"), []byte("services:\n  cloudapp:\n    image: busybox\n    volumes:\n      - ${HDD_PATH}/appdata/cloudapp:/data\n"), 0o644)
	_ = os.WriteFile(filepath.Join(app, ".felhom.yml"), []byte("display_name: Cloud App\n"), 0o644)
	_ = os.WriteFile(filepath.Join(drive, "appdata/cloudapp/old.txt"), []byte("old"), 0o644)
	m, err := stacks.NewManager(cfg, log.New(io.Discard, "", 0))
	if err != nil {
		t.Fatal(err)
	}
	if err := m.ScanStacks(); err != nil {
		t.Fatal(err)
	}
	sett, err := settings.Load(filepath.Join(cfg.Paths.DataDir, "settings.json"), log.New(io.Discard, "", 0))
	if err != nil {
		t.Fatal(err)
	}
	if err := sett.SetOffboxTarget(&settings.OffboxTarget{Enabled: true, Host: "nas.local", Port: 22, User: "felhom",
		RepoPath: "/srv/repo", Schedule: "daily", EscrowState: "escrowed"}); err != nil {
		t.Fatal(err)
	}
	bm := backup.NewManager(cfg, sett, log.New(io.Discard, "", 0))
	if err := bm.WriteOffboxSecrets("KEY", "nas.local ssh-ed25519 AAAA"); err != nil {
		t.Fatal(err)
	}
	snapAt := time.Date(2026, 9, 28, 2, 15, 0, 0, time.UTC) // 04:15 in Budapest
	bm.SetOffboxRunner(func(_ context.Context, _ []string, args ...string) ([]byte, error) {
		for _, a := range args {
			if a == "snapshots" {
				return json.Marshal([]map[string]interface{}{{"short_id": "ab12cd34", "time": snapAt,
					"tags": []string{"cloudapp"}, "paths": []string{drive + "/backups/primary/cloudapp", drive + "/appdata/cloudapp"}}})
			}
		}
		return nil, nil
	})
	r := &Router{stackMgr: m, backupMgr: bm, logger: log.New(io.Discard, "", 0)}
	for lang, want := range map[string]string{
		"en": "We load the database from the off-site copy, 2026-09-28 04:15 and start the app with the old files. Changes made after that time can be missing.",
		"hu": "Az adatbázist innen töltjük vissza: távoli mentés, 2026-09-28 04:15. A régi fájlokkal indítjuk az alkalmazást. Ami ezután változott, hiányozhat.",
	} {
		w := httptest.NewRecorder()
		req := httptest.NewRequest(http.MethodPost, "/api/stacks/cloudapp/deploy?lang="+lang, nil)
		if !r.keptDataAtInstall(w, req, "cloudapp", drive, "") || w.Code != http.StatusConflict {
			t.Fatalf("%s: the choice was not asked (code %d)", lang, w.Code)
		}
		var body map[string]interface{}
		_ = json.Unmarshal(w.Body.Bytes(), &body)
		data, _ := body["data"].(map[string]interface{})
		if data["use_offered"] != true || data["use_desc"] != want || data["use_off"] != "" {
			t.Fatalf("%s: use_offered=%v use_desc=%q use_off=%q\nwant use_desc=%q", lang, data["use_offered"], data["use_desc"], data["use_off"], want)
		}
	}
	if st, _ := m.GetStack("cloudapp"); st.Deployed || st.Deploying {
		t.Fatal("something was installed")
	}
}