package web import ( "context" "encoding/json" "errors" "net/http" "strings" "gitea.dooplex.hu/admin/felhom-controller/internal/agentapi" ) var ( errAgentUnreadable = errors.New("a meghajtók listája nem olvasható") errDriveNotFound = errors.New("a meghajtó nem található") ) // BackupTargetState is the customer-facing answer to "does the whole-system backup survive a disk // failure?". Derived from the AGENT (the authority), never from our own intent flag alone. type BackupTargetState struct { // Known is false when the agent could not be asked. Everything below is then meaningless, and the // UI must render NOTHING rather than guess — an unreachable agent is not evidence of degradation. Known bool // Degraded is true when the whole-guest backup lands on the SYSTEM drive, so it protects against // corruption but not against drive loss. Degraded bool // TargetID is the agent's primary tier storage id (e.g. "felhom-backup" / "local"). TargetID string // Label is the customer-facing drive name when the target is a real drive. Label string // OfferPath, when non-empty, is a registered drive that COULD become the target — the offer. OfferPath string OfferLabel string } // resolveBackupTargetState asks the agent what the primary tier actually writes to and classifies it. // // DEGRADED means "on the system drive", and it is decided from the agent's own storage view: a tier // whose target has NO mount path of its own (the builtin `local`, i.e. /var/lib/vz on the root fs) // cannot survive the root device dying. A tier on a drive with its own mountpoint can. // // PBS is deliberately NOT counted as the local target here: the offsite tier is separate hardware and // a different question. This state answers only "is there a LOCAL copy that survives a disk failure", // which is matrix row 4. func (s *Server) resolveBackupTargetState(ctx context.Context) BackupTargetState { agent, err := s.agentClient() if err != nil { return BackupTargetState{} } tiers, err := agent.BackupTiers(ctx) if err != nil { // Includes ErrTiersUnsupported (a pre-R-82 agent). Unknown, never "degraded": claiming // degradation because we could not ask would put a permanent warning on a healthy box. return BackupTargetState{} } var primary string for _, t := range tiers.Tiers { if t.Primary { primary = t.Target break } } st := BackupTargetState{Known: true, TargetID: primary} disks, derr := agent.Disks(ctx) if derr != nil { return BackupTargetState{} // could not classify → say nothing } for _, d := range disks.Disks { if d.BackupTarget && d.MountPath != "" { // A real drive with its own mountpoint — healthy. st.Label = s.storageLabelFor(stablePathForName(baseName(d.MountPath))) return st } } // No disk claims the target ⇒ it is the builtin `local` on the system drive, or the tier is // unset. Either way the local backup does not survive drive loss. st.Degraded = true st.OfferPath, st.OfferLabel = s.firstOfferableDrive(disks.Disks) return st } // firstOfferableDrive picks a registered, connected, non-network drive that could hold the backup. // It is a SUGGESTION for the offer — the customer still has to choose (E-2 §3). Nothing here assigns // anything. func (s *Server) firstOfferableDrive(disks []agentapi.DiskInfo) (path, label string) { for _, sp := range s.settings.GetStoragePaths() { if sp.IsNetwork() || sp.Decommissioned || sp.Disconnected { continue } for _, d := range disks { // Only a drive the agent classifies as user-data with its OWN mountpoint can be a target; // the agent refuses anything else anyway, so offering it would be a dead end. if d.GuestPath == sp.Path && d.MountPath != "" && d.Role == "user-data" { return sp.Path, s.storageLabelFor(sp.Path) } } } return "", "" } // baseName is path.Base without importing path into this file's surface. func baseName(p string) string { if i := strings.LastIndex(p, "/"); i >= 0 { return p[i+1:] } return p } // ---- Hungarian customer copy ------------------------------------------------------------------- // // Adult tone, no alarm decoration. It states the FACT, the CONSEQUENCE and the REMEDY, in that order, // because a customer who is told only the fact cannot act on it. // // HEALTHY RENDERS NOTHING. There is deliberately no "your backup is safe" banner: a working // configuration must look normal, or every customer's dashboard grows a permanent notice and the // warning stops meaning anything (E-2 Scenario E). const ( backupTargetDegradedText = "A rendszermentés jelenleg ugyanazon a lemezen van, mint a rendszer — " + "így hibás fájlok ellen véd, lemezhiba ellen nem. Csatlakoztass egy második meghajtót a teljes védelemhez." backupTargetOfferText = "Ezt a meghajtót kijelölheted a rendszermentés helyéül — így egy lemezhiba " + "után is vissza tudod állítani a rendszert." ) // degradedMessageFor is the single decision point for "does the customer see anything?" — extracted // so the render rule is testable without a live agent, and so there is exactly ONE place that can // accidentally start decorating a healthy box. // // Returns "" for BOTH healthy and unknown. They are different states with the same rendering, and // collapsing them here is deliberate: unknown means we could not ask, which is not evidence of // degradation (the absence-read-as-a-value mistake R-88 Part 2 closed). func degradedMessageFor(st BackupTargetState) string { if !st.Known || !st.Degraded { return "" } return backupTargetDegradedText } // handleBackupTargetState serves GET /api/storage/backup-target — the dashboard's source for the degraded // banner and the offer. func (s *Server) handleBackupTargetState(w http.ResponseWriter, r *http.Request) { st := s.resolveBackupTargetState(r.Context()) out := map[string]any{"known": st.Known} if st.Known { out["degraded"] = st.Degraded out["target"] = st.TargetID out["label"] = st.Label if st.Degraded { out["message"] = degradedMessageFor(st) if st.OfferPath != "" { out["offer_path"] = st.OfferPath out["offer_label"] = st.OfferLabel out["offer_message"] = backupTargetOfferText } } } writeDiskJSON(w, http.StatusOK, true, "", out) } // handleBackupTargetAssign is the ACCEPTANCE of the offer — POST /api/storage/backup-target/assign. // // NOTHING calls this except an explicit customer action. Registration does not, the drive-gate does // not, and no scheduler does (E-2 §3: a drive never acquires a role by appearing). Declining is // simply not calling it, and the degraded state stays visible on the next visit rather than going // quiet (Scenario D). func (s *Server) handleBackupTargetAssign(w http.ResponseWriter, r *http.Request) { var req struct { Path string `json:"path"` } if err := json.NewDecoder(r.Body).Decode(&req); err != nil { writeDiskJSON(w, http.StatusBadRequest, false, "érvénytelen kérés", nil) return } stable := strings.TrimSpace(req.Path) if stable == "" { writeDiskJSON(w, http.StatusBadRequest, false, "hiányzó meghajtó", nil) return } agent, err := s.agentClient() if err != nil { writeDiskJSON(w, http.StatusServiceUnavailable, false, "a host-ügynök nem elérhető", nil) return } // The agent operates on the RAW host mount path, not our stable guest path — the same asymmetry // that register/attach already navigate. raw, err := s.rawMountForStable(r.Context(), agent, stable) if err != nil { writeDiskJSON(w, http.StatusBadRequest, false, err.Error(), nil) return } res, err := agent.SetBackupTarget(r.Context(), raw) if err != nil { s.logger.Printf("[WARN] [web] backup-target assign %s (raw %s): %v", stable, raw, err) writeDiskJSON(w, http.StatusBadGateway, false, "a mentési cél beállítása nem sikerült: "+err.Error(), nil) return } // Record the INTENT only after the agent accepted, so our flag can never claim a target the agent // does not have. if err := s.settings.SetBackupTarget(stable); err != nil { s.logger.Printf("[WARN] [web] backup-target intent record %s: %v", stable, err) } s.logger.Printf("[INFO] [web] backup target assigned to %s (raw %s); agent restart_required=%v", stable, raw, res.RestartRequired) writeDiskJSON(w, http.StatusOK, true, "", map[string]any{ "assigned": stable, "restart_required": res.RestartRequired, }) } // rawMountForStable maps our registered stable guest path back to the agent's raw host mount. func (s *Server) rawMountForStable(ctx context.Context, agent *agentapi.Client, stable string) (string, error) { disks, err := agent.Disks(ctx) if err != nil { return "", errAgentUnreadable } for _, d := range disks.Disks { if d.GuestPath == stable && d.MountPath != "" { return d.MountPath, nil } } return "", errDriveNotFound }