Review fix 3: every install deletes the off-site end record — one point, SaveAppConfig (D72)

A `.fab` import installed the app and its end record survived; the restore
that installs from a unit had the same hole. Only DeployStack deleted it.

- stacks.SaveAppConfig, the only writer of an installed app's app.yaml, calls
  noteAppInstalled when the record says deployed (a hook per stacks directory,
  registered by SetMigrationDeps). A source pin lists every place that sets
  Deployed or writes an app.yaml; a new writer fails it.
- The living check is stacks.Manager.IsLivingApp (wired in main.go): the
  protected list, the manager's list (deployed, being deployed, protected) and
  the app's record on disk — an installed app the manager does not list is
  living. Tested by behaviour.

Tests seen red before the fix; 8 mutations seen red (felhom.eu
documentation/audits/build-release-4-2026-11-15/A/redproof-review-3.txt).

Claude-Session: https://claude.ai/code/session_0159rPz1ZhFKsS53msqPYxtS
This commit is contained in:
admin committed 2026-11-15 14:42:07 +01:00
1 parent 3928c3db28
commit c7e4ec9b5e
7 files changed
+312 -14

No files matched your search

+1 -7
View File
@@ -1611,13 +1611,7 @@ func main() {
// D72 / D84 (`07` §8.2f): the off-site copies of a removed app. (1) „Living": installed right now, or one of
// the box's own protected stacks — such an app's end record is never due, and it cannot get one. Without
// this seam nothing is ever due (backup/offbox_ended.go). (2) The household's one mail per press.
backupMgr.SetOffsiteEndLiving(func(app string) bool {
if cfg.IsProtectedStack(app) {
return true
}
st, ok := stackMgr.GetStack(app)
return ok && (st.Deployed || st.Deploying || st.Protected)
})
backupMgr.SetOffsiteEndLiving(stackMgr.IsLivingApp)
backupMgr.SetOffsiteEndNotify(func(rec settings.OffsiteEnd) {
notifier.NotifyOffsiteEndScheduled(rec.App, rec.RemovedAt, rec.EndsAt, rec.Ends().Local())
})