Review fix 5: the box sends its end records only to a hub that says it reads them (version skew)
gates / gates (push) Successful in 32s

A new box with an older hub sent `ended` in the window request; that hub reads
4 KiB of it, decided the window on a wrong count, and the weekly clean-up
stalled.

- The box sends `ended` only when the hub's last window answer said
  accepts_ended (kept in settings, re-read from every answer, so a rolled-back
  hub stops getting them after one answer). Otherwise the request is the one
  every hub always got, and the ordinary clean-up runs.
- One request carries at most 5000 snapshot ids.

Tests seen red before the fix; 6 mutations seen red (felhom.eu
documentation/audits/build-release-4-2026-11-15/A/redproof-review-5.txt).

Claude-Session: https://claude.ai/code/session_0159rPz1ZhFKsS53msqPYxtS
This commit is contained in:
admin committed 2026-11-15 15:05:38 +01:00
1 parent c7e4ec9b5e
commit c5acb91a44
10 files changed
+179 -5

No files matched your search

+4 -1
View File
@@ -1133,7 +1133,10 @@ deletes the record); a removed app with copies and no record shows „Törlés 3
(`POST /backup/offsite-end/start`). An install of the same app deletes the record. The copies are removed only in
the weekly clean-up window, by snapshot id, for ids the hub agreed to — never without a record, never a snapshot
that also belongs to an installed app, never `_shares` or the box's own stacks. A box whose off-site target is the
household's own NAS keeps a removed app's copies as before.
household's own NAS keeps a removed app's copies as before. After the review of 2026-11-15: every install deletes
the record at one point (`stacks.SaveAppConfig`: a deploy, an import, a restore that installs); the window reads the
records again immediately before the forget, so a take-back or an install while it was being prepared keeps the copies;
and the box sends its end records only to a hub whose last window answer said `accepts_ended`.
**Protected stacks** (traefik, cloudflared, felhom-controller) cannot be stopped, removed, or deleted from the UI. Restart is allowed.