Review fix 5: the box sends its end records only to a hub that says it reads them (version skew)
gates / gates (push) Successful in 32s

A new box with an older hub sent `ended` in the window request; that hub reads
4 KiB of it, decided the window on a wrong count, and the weekly clean-up
stalled.

- The box sends `ended` only when the hub's last window answer said
  accepts_ended (kept in settings, re-read from every answer, so a rolled-back
  hub stops getting them after one answer). Otherwise the request is the one
  every hub always got, and the ordinary clean-up runs.
- One request carries at most 5000 snapshot ids.

Tests seen red before the fix; 6 mutations seen red (felhom.eu
documentation/audits/build-release-4-2026-11-15/A/redproof-review-5.txt).

Claude-Session: https://claude.ai/code/session_0159rPz1ZhFKsS53msqPYxtS
This commit is contained in:
admin committed 2026-11-15 15:05:38 +01:00
1 parent c7e4ec9b5e
commit c5acb91a44
10 files changed
+179 -5

No files matched your search

+9
View File
@@ -2,6 +2,15 @@
**MinAgent: 0.158.1** (unchanged — nothing here asks the agent for anything)
- **Review fix 5 (2026-11-15), the box's half — version skew.** A new box with an older hub sent its end records in
the window request; that hub reads 4 KiB of it (about 55 snapshot ids), then decided the window on a wrong count,
and the weekly clean-up stalled. Now the box sends `ended` ONLY to a hub whose last window answer said
`accepts_ended` (kept in `settings.json` → `offsite_hub_accepts_ended`, re-read from every answer, so a rolled-back
hub stops getting them after one answer); otherwise the request is the one every hub always got and the ordinary
clean-up runs. One request carries at most 5000 ids (`boundEndedClaims`). **Cost, said plainly:** after the hub is
updated the box learns it at its next nightly window request and sends from the one after. Tests
`TestD84_ANewBoxWithAnOlderHub_NothingEndedIsSentAndTheCleanUpStillRuns`, `TestD84_OneRequestCarriesABoundedNumberOfIds`
— seen red before the fix; 6 mutations seen red (felhom.eu `…/A/redproof-review-5.txt`).
- **Review fix 3 (2026-11-15): EVERY install deletes the off-site end record, not only a deploy.** A `.fab` import
(`SaveImportedAppConfig`) installed the app and the record survived; the restore that installs from a unit
(`PersistUnitRedeployConfigGate`) had the same hole. The rule now sits at ONE point: `stacks.SaveAppConfig`, the