i18n slice 1 release C: storage, sharing, sign-in, guest, catch-all and debug pages in English
- 11 templates converted (storage, storage_network, storage_init, storage_attach, sharing, login,
claim, launcher_shared, launcher_share_password, catchall, debug); every key translated.
Six ASCII-only Hungarian JS fragments the extractor missed were found by eye and converted by hand
(", majd a(z)", "FIGYELEM:", "jelenlegi:", "mp", "p", " db").
- login, claim, both guest share pages and the catch-all render through executeTemplateLang (the
household language; no session CSRF, no escrow reminder). renderLogin now takes the request.
- Page titles: TitleKey for storage, network storage, the two drive wizards and sharing.
TestHandlerTitleKeysMatchHungarianTitle pins handler literal == hu.json value for every TitleKey.
- Tests: TestDirectRenderHandlersFollowLanguage (real routes, en + hu),
TestI18nDirectRenderPagesHaveNoAdminChrome (escrow reminder due; none on the guest page).
- Fixture correction: the release C cases had invented page titles; the cases now carry the handlers'
real titles (and the wizard pages their real page name), and those 12 fixtures were RE-CAPTURED from
the unconverted templates at 0555091. The diff to the old fixtures is the <title> line (and the nav
highlight on the two wizard pages) only.
- i18n gate: HU_FORMAL_CEILING 12 -> 16 — four more „ön" forms in the converted copy, unchanged by rule (R-516).
Hungarian: byte-identical (TestI18nParity against fixtures from unconverted templates).
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_0159rPz1ZhFKsS53msqPYxtS
This commit is contained in:
@@ -801,7 +801,7 @@ func (s *Server) serveCatchAll(w http.ResponseWriter, r *http.Request, host stri
|
||||
|
||||
w.Header().Set("Content-Type", "text/html; charset=utf-8")
|
||||
w.WriteHeader(http.StatusNotFound)
|
||||
if err := s.tmpl.ExecuteTemplate(w, "catchall", data); err != nil {
|
||||
if err := s.executeTemplateLang(w, r, "catchall", data); err != nil {
|
||||
s.logger.Printf("[ERROR] [web] Catch-all template error: %v", err)
|
||||
http.Error(w, "Internal error", http.StatusInternalServerError)
|
||||
}
|
||||
@@ -854,9 +854,10 @@ func (s *Server) executeTemplate(w http.ResponseWriter, r *http.Request, name st
|
||||
data["CSRFField"] = s.csrfField(r)
|
||||
data["CSRFToken"] = s.csrfToken(r)
|
||||
// R-543 — the escrow reminder hangs HERE, on the single render choke point, so it reaches every
|
||||
// dashboard page instead of the three pages a per-handler call would have covered. The login and
|
||||
// claim pages render through s.tmpl.ExecuteTemplate directly and never pass through here; the
|
||||
// session check inside keeps it off the guest share page, which has no admin session.
|
||||
// dashboard page instead of the three pages a per-handler call would have covered. The login,
|
||||
// claim, recovery, guest-share and catch-all pages render through executeTemplateLang and never pass
|
||||
// through here (TestI18nDirectRenderPagesHaveNoAdminChrome); the session check inside is a second
|
||||
// fence for the guest share page, which has no admin session.
|
||||
s.addEscrowBanner(data, r)
|
||||
lang := s.langFor(r)
|
||||
s.addLanguageData(data, r, lang)
|
||||
|
||||
Reference in New Issue
Block a user