R-1340 second producer: a restore_mixed hold's Why() names the cause from its record (found live on rc.1: the hub's Held apps line said off-site/database for a local restore with no database) — test red first

controller/internal/settings/r1340_why_test.go

@@ -0,0 +1,41 @@
+package settings
+
+import (
+	"strings"
+	"testing"
+)
+
+// R-1340, second producer (found live 2026-10-29 on Tester 1): the hold's Why() — the hub's „Held apps" line and the
+// box's app_held event — still said „held after an off-site restore failed its database replay" for a LOCAL restore of
+// an app with no database whose put-back stop failed. It must name what the hold record carries.
+// RED-PROOF: seen failing on the old fixed sentence.
+func TestR1340_WhyNamesTheMixedCause(t *testing.T) {
+	for _, tc := range []struct {
+		name      string
+		h         RestoreHold
+		want, not []string
+	}{
+		{"local put-back, no database", RestoreHold{Reason: HoldReasonRestoreMixed, At: "T", RestoreKind: RestoreKindLocal, MixedCause: MixedCausePutBack, FailedStep: "stopping the app before the put-back"},
+			[]string{"local restore", "putting the live data back failed", "stopping the app before the put-back"}, []string{"database", "off-site"}},
+		{"off-site database replay", RestoreHold{Reason: HoldReasonRestoreMixed, At: "T", RestoreKind: RestoreKindOffsite, MixedCause: MixedCausePutBack, DBReplay: true},
+			[]string{"off-site restore", "database replay", "putting the live data back failed"}, nil},
+		{"definition write", RestoreHold{Reason: HoldReasonRestoreMixed, At: "T", RestoreKind: RestoreKindOffsite, MixedCause: MixedCauseDefinitionWrite},
+			[]string{"definition"}, []string{"database"}},
+		{"interrupted put-back", RestoreHold{Reason: HoldReasonRestoreMixed, At: "T", MixedCause: MixedCauseInterruptedPutBack},
+			[]string{"interrupted"}, []string{"database"}},
+		{"legacy record", RestoreHold{Reason: HoldReasonRestoreMixed, At: "T"},
+			[]string{"stopped half-way", "clear the hold"}, []string{"database", "off-site"}},
+	} {
+		got := tc.h.Why()
+		for _, w := range tc.want {
+			if !strings.Contains(got, w) {
+				t.Errorf("%s: %q lacks %q", tc.name, got, w)
+			}
+		}
+		for _, n := range tc.not {
+			if strings.Contains(got, n) {
+				t.Errorf("%s: %q says %q", tc.name, got, n)
+			}
+		}
+	}
+}

controller/internal/settings/settings.go

@@ -2051,7 +2051,7 @@ func (h RestoreHold) Why() string {
 		}
 		return "stopped by the box for a " + strings.ReplaceAll(kind, "_", " ") + " (" + h.At + ") — the household's Start gives it one more try"
 	case HoldReasonRestoreMixed:
-		return "held after an off-site restore failed its database replay (" + h.At + ") — clear the hold to start it"
+		return h.mixedWhy() + " (" + h.At + ") — clear the hold to start it"
 	case HoldReasonPutBackPending:
 		return "held until the pre-restore copy is poured back (" + h.At + ") — the put-back starts it"
 	default:
@@ -2059,6 +2059,36 @@ func (h RestoreHold) Why() string {
 	}
 }
 
+// mixedWhy (R-1340) names a restore_mixed hold from what its record carries — never „database" or „off-site" unless the
+// record says so. A record written before these fields („legacy") gets the neutral sentence. Pinned by
+// TestR1340_WhyNamesTheMixedCause.
+func (h RestoreHold) mixedWhy() string {
+	kind := "a restore"
+	switch h.RestoreKind {
+	case RestoreKindOffsite:
+		kind = "an off-site restore"
+	case RestoreKindLocal:
+		kind = "a local restore"
+	}
+	switch h.MixedCause {
+	case MixedCauseDefinitionWrite:
+		return "held after " + kind + " could not write its definition and writing the live definition back failed too"
+	case MixedCauseInterruptedPutBack:
+		return "held after a restore was interrupted and its live data could not be put back at the next start"
+	case MixedCausePutBack:
+		what := "failed"
+		if h.DBReplay {
+			what = "failed its database replay"
+		}
+		s := "held after " + kind + " " + what + " and putting the live data back failed"
+		if h.FailedStep != "" {
+			s += " (" + h.FailedStep + ")"
+		}
+		return s
+	}
+	return "held after a restore stopped half-way"
+}
+
 // SetRestoreHold records a hold. Modelled on SetDisconnected: a condition, plus what it is holding.
 func (s *Settings) SetRestoreHold(h RestoreHold) error {
 	s.mu.Lock()