v0.255.0 — the globe on the sign-in-flow pages: styled, and inside the card
gates / gates (push) Successful in 23s
gates / gates (push) Successful in 23s
Two defects in v0.254.0's globe, both plain on a browser and neither catchable by anything that existed — every test read the MARKUP, and the fault was in which CSS file the browser fetched. The shells requested /static/style.css with NO ?v=, while layout.html has carried one since v0.166.0. A browser holding a copy from before v0.254.0 kept serving CSS with no .lang-globe rules, so the globe came out as a bare unstyled <details> — a stray triangle and two plain words at the edge of the window. It was FIVE shells, not the three named: both guest share pages have the same fault for any CSS change, and their visitor is the likeliest of all to be holding an old copy. And .Version was missing from three of those five data maps, which is exactly how the next one would be forgotten — it is now filled at the one choke point every shell renders through. The globe also floated outside the card, pinned to the corner of the VIEWPORT, reading as part of the browser rather than the page. It now sits inside the card, centred under the footer, with the menu opening upward via the shared rule — so the dashboard and the shells cannot drift. AND A THIRD, caught by a test that already existed: putting the version on the guest share pages would have printed the controller build onto a page a stranger with a capability URL can open. TestShareGuest_HeadersTilesNoAdminChrome refused it. Those two now take an opaque per-build tag — same cache-busting, no disclosure. The fill is ONE function shared with the parity harness, because a fixture rendered through a different data path is a picture of a page nobody serves, which the previous release got wrong twice. 15 shell fixtures re-captured; 91 identical, every dashboard page among them. MinAgent: 0.131.0 (unchanged). No hub release needed. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0159rPz1ZhFKsS53msqPYxtS
This commit is contained in:
@@ -306,6 +306,9 @@ func renderI18nCase(t *testing.T, s *Server, lang string, c i18nCase) string {
|
||||
// is exactly what the first attempt at this release did, and what the diff caught.
|
||||
if i18nDirectTemplates[c.tmpl] {
|
||||
data["Lang"] = lang
|
||||
// The same asset data executeTemplateLang fills — one function, so the fixture cannot be a
|
||||
// picture of a page nobody serves (v0.255.0).
|
||||
s.addShellAssetData(data)
|
||||
// And WITHIN the direct-render set, two shapes again: /recovery is an AUTHENTICATED route, so
|
||||
// its globe writes the household's setting; /login and /claim are met with no session, so
|
||||
// theirs writes the visitor's cookie. The fixture has to be the one the real page serves.
|
||||
|
||||
Reference in New Issue
Block a user