docs: v0.124.0 backups IA restructure — CHANGELOG + REPORT + CONTEXT (decisions 1-3) + README page map + REUSE; records the HIGH containerized-.fab volume-strand finding and the agent SystemDisks legacy-boot finding
Claude-Session: https://claude.ai/code/session_01GzammAMzsJTgpQHqxwM2bC
This commit is contained in:
@@ -1,64 +1,86 @@
|
||||
# REPORT — v0.123.0: polish batch (F-15 instant reset codes, F-11 inline confirms, "Távoli mentés" rename, zero-toggle honesty)
|
||||
# REPORT — v0.124.0: backups IA restructure (four sub-pages, Felhom-offsite status card, .fab browser download)
|
||||
|
||||
**Date:** 2026-07-13 · **Version:** controller v0.123.0 (from v0.122.0) · **MinAgent:** 0.81.0 (UNCHANGED) · **Companion:** hub v0.52.0 (F-15 response; old hub = clean no-op) · **Floor:** 0.122 UNCHANGED (no raise in this task)
|
||||
**Date:** 2026-07-13 · **Version:** controller v0.124.0 (from v0.123.0) · **MinAgent:** 0.81.0 (UNCHANGED) · **Floor:** untouched (rides the next train) · Controller-only.
|
||||
|
||||
## What shipped (commits `b4e0a19`, `40b5304`, `8987ce0`, `a00afcc`, `b482860`)
|
||||
## What shipped (commits `0ece2ba`, `aa967fb`, `753cd83`)
|
||||
|
||||
1. **F-15 — reset code works the moment the email lands** (`internal/web/claim.go`). The
|
||||
reset-request POST now reads the hub's response (`claim {code_hash, generation, issued_at}`,
|
||||
hub ≥0.52.0) and applies it through the SAME generation-guarded consumer as the report ACK
|
||||
(`report.ClaimSync.Reconcile` — one consumer, two feeds). Replayed/older generations can never
|
||||
downgrade the active hash; a legacy hub's bare `{"status":"ok"}` is a no-op.
|
||||
2. **F-11 — inline confirms** (`layout.html` helper + 7 call sites). `felhomConfirm(el, q, onYes)`
|
||||
swaps the trigger IN PLACE to "kérdés + Igen/Mégse"; form buttons opt in with `data-confirm`
|
||||
(delegated listener + `requestSubmit`). Zero native `confirm()`/`prompt()` remain —
|
||||
enforced by the new committed gate `controller/scripts/native_confirm_gate.py`. The deploy
|
||||
stale-data delete keeps its double acknowledgement (two chained inline steps).
|
||||
3. **Tier-3 rename** — customer-facing "NAS-mentés" → **"Távoli mentés"** across `backups.html`,
|
||||
`offbox_handlers.go` flashes, and the `backup/offbox.go` quota copy; the manual-target form is
|
||||
generalized to any SFTP target. Executed as a count-guarded python sweep (multibyte rule);
|
||||
enforced by `controller/scripts/offbox_rename_gate.py`. "Hálózati tárhely" (NAS network
|
||||
storage) is a different feature and was deliberately untouched.
|
||||
4. **Zero-toggle honesty** — configured+escrowed offbox with no app selected: muted hint
|
||||
"Nincs távoli mentésre jelölt alkalmazás — jelölj ki legalább egyet." + the run reports
|
||||
"Sikeres — nincs mentésre jelölt alkalmazás" (LastWarning; status stays ok).
|
||||
5. **Dev-box green-gate fix** (`backup.go` `atomicPromoteTar`): fsync via O_RDWR — read-only
|
||||
fsync is refused on Windows; the two F7 atomic-dump tests were permanently red on the dev box
|
||||
since CAMPAIGN-3 (Linux unchanged).
|
||||
1. **IA split** — `/backups` (Áttekintés), `/backups/remote` (Távoli mentés), `/backups/apps`
|
||||
(Alkalmazások), `/backups/restore` (Visszaállítás), sidebar children (Tárhely pattern).
|
||||
Sections MOVED verbatim from the v0.123.0 page — the committed one-shot
|
||||
`scripts/backups_split_move_check.py` verifies all 15 blocks against baseline `df7ad37`
|
||||
(whitespace-normalized; the two allowed divergences — tier-3 anchor retarget + the
|
||||
restore-to-verify relocation — are encoded explicitly). Shared handler builders extracted
|
||||
(`backupsCommonData`/`backupsOffboxData`); flash redirects, tier-3 anchors and the
|
||||
tier2-config back-link retargeted per page.
|
||||
2. **Felhom-offsite status card** — three honest states from local data, display-only by
|
||||
construction (no form/button inside the card; unit-enforced). Decision 2 honored: the card
|
||||
never changes anything.
|
||||
3. **.fab browser download** — existing export pipeline + staging dest + guarded streaming exit
|
||||
with estimate-first UX, post-stream cleanup and a 1h TTL sweep; per-app sequential batch;
|
||||
portability framing everywhere (decision 3). Import stays drive-scan.
|
||||
|
||||
## Tests + red-proofs (all run → FAIL → restored)
|
||||
## Tests + red-proofs (run → FAIL → restored)
|
||||
|
||||
- `TestResetRequest_ResponseHashAppliedImmediately` (+ generation-guard + legacy-hub no-op
|
||||
tests). **Red-proof:** response handling disabled → FAIL `gen=1 hash-is-new=false`.
|
||||
- `native_confirm_gate.py` **red-proof:** one `onsubmit="return confirm('redproof')"`
|
||||
reintroduced → exit 1; restored → 0.
|
||||
- `offbox_rename_gate.py` **red-proof:** one 'A NAS-mentés…' flash reintroduced → exit 1.
|
||||
- `TestOffbox_ZeroToggledRunReportsEmptiness` (+ covered-run negative). **Red-proof:** emptiness
|
||||
branch disabled → FAIL `LastWarning = ""`.
|
||||
- Full green gate (build+vet+test, all packages) + template_id/emoji/native_confirm/offbox_rename
|
||||
gates green before every commit.
|
||||
- **Move check red-proof:** one moved block reworded → exit 1 ("1 block(s) rewritten"); restored → 0.
|
||||
- **Traversal guard red-proof:** guard loosened to raw prefix-matching → `../decoy.fab` came back
|
||||
**200 serving the decoy** — the test caught it (got 200, want 400). Restored → green.
|
||||
- **Round-trip + corruption (data-mutation red-proof):** real `executeExport` → bundle →
|
||||
real `executeImport` → byte-identical restored content; a mid-file-corrupted copy is REFUSED
|
||||
(job fails, app not started, nothing restored). Integrity = gzip CRC + manifest segment
|
||||
validation — there is NO per-file checksum (documented; the spec's "manifest checksum" wording
|
||||
adapted to reality).
|
||||
- Nav/state tests (marker per section, present on exactly one page; `.Page` ids), status-card
|
||||
state tests, TTL sweep test (fake mtimes/now). Full green gate + all five template gates green
|
||||
per commit.
|
||||
|
||||
## Live validation (drill box qm300/guest 9201 + demo 9201, controller 0.123.0 both, healthy)
|
||||
## §13 live validation
|
||||
|
||||
- **F-15 exact-failure-path re-run:** "Visszaállító kód kérése" on felhom.enkisfelhom.hu/claim →
|
||||
controller log `claim-sync: hub claim code cached (generation 3)` **1 second** after the POST →
|
||||
Viktor entered the emailed code: **accepted immediately, first try** (take-two failure closed).
|
||||
- **F-11 automation-completes proof:** offbox restore-to-verify driven END-TO-END by browser
|
||||
automation — inline strip rendered, Igen → restore ran ("A távoli visszaállítás elindult…",
|
||||
banner "Távoli visszaállítás folyamatban: actualbudget…"), zero freezing.
|
||||
- **Rename:** /backups renders with ZERO 'NAS-mentés' strings (screenshots in session record);
|
||||
only the allowlisted "saját NAS vagy Felhom offsite tárhely" intro mention remains.
|
||||
- **Zero-toggle:** untoggled ActualBudget → hint appeared → run → "Sikeres — nincs mentésre
|
||||
jelölt alkalmazás" + status Rendben → re-toggled (box left as found).
|
||||
- **Deployed:** 0.124.0 on the drill guest (qm300) AND demo 9201, both healthy.
|
||||
- **Four-page walk (drill, screenshots in session record):** every moved control clicked once —
|
||||
tier-2 Beállítás (+ retargeted back-link), tier-3 toggle (off→on), restore-to-verify from its
|
||||
NEW home (`/backups/restore` flash), manual-target form open/close. Old `/backups` bookmark →
|
||||
Áttekintés on both boxes; sidebar active states correct.
|
||||
- **Status card:** state 3 (no card) and state 2 ("Aktív — nincs kijelölt alkalmazás") both
|
||||
live-rendered on the drill box; state 1 by unit render test (demo has a managed target — spec
|
||||
says do NOT unconfigure).
|
||||
- **.fab download:** drill ActualBudget — estimate 3.6 KB shown first, bundle 2102 B streamed,
|
||||
staging bundle removed (server log). Demo ActualBudget — downloaded to the operator machine,
|
||||
sha256-identical after placement on `felhom-usb/exports` (`e2a1233f…` both ends).
|
||||
- **Supervised import (Viktor GO):** ON DEMO (see finding 2 for why not drill): scan found the
|
||||
bundle, manifest read (exported-by 0.124.0), "Importálás kész! Az alkalmazás sikeresen
|
||||
visszaállítva.", ActualBudget Up (healthy). **The round-trip surfaced finding 1.**
|
||||
|
||||
## FINDINGS (both pre-existing, surfaced by this task's first real containerized round-trip)
|
||||
|
||||
1. **(HIGH — data-loss trap) Containerized .fab export ships EMPTY volume data.**
|
||||
`exportVolumeData` runs `docker run -v <volDir>:/out alpine tar …` where `<volDir>` is the
|
||||
controller-CONTAINER's `os.MkdirTemp` path — the guest's docker daemon resolves it against the
|
||||
HOST filesystem, so the tar lands stranded on the guest host (`/tmp/felhom-export-*/…`, found
|
||||
with ActualBudget's 66 KB tar in it) and the bundle's `data/volumes` is empty while the
|
||||
manifest claims volume data and the export reports SUCCESS. Import then wipes the app's
|
||||
volumes and brings it up EMPTY. Affects every golden/bootstrap (containerized) box for
|
||||
volume-backed apps; HDD-data apps are unaffected (direct FS copy). Demo's ActualBudget was
|
||||
repaired from the stranded tar; both temp dir and staged bundle cleaned. **Fix direction:**
|
||||
stage the docker-run output under a host-visible bind (e.g. the controller data volume) or use
|
||||
`docker cp`/stdout streaming; plus a post-export assertion that manifest-claimed volume tars
|
||||
exist in the bundle (fail LOUD).
|
||||
2. **(MEDIUM — agent-side, out of this controller-only task) Drive wizard offers zero candidates
|
||||
on a legacy-boot PVE.** With LVM root and no ESP mount, every system mount resolves to
|
||||
device-mapper, `storage.SystemDisks` finds no raw disk → `sysKnown=false` → `isSystemBacked`
|
||||
fail-safes EVERYTHING to system → `ListCandidateDisks` is always empty (drill box; a hot-added
|
||||
blank 5G disk stayed invisible). The fail-safe is right to exist but overreaches here — needs
|
||||
an agent ruling (e.g. resolve device-mapper parents to their PVs' disks).
|
||||
|
||||
## Observations
|
||||
|
||||
- The queued **customer-target coexistence** task (`managed_by` on OffboxTarget) remains a
|
||||
SEPARATE task with a pending operator fork — not started, per spec.
|
||||
- NAS-string inventory beyond backups.html: the two customer-facing quota strings in
|
||||
`internal/backup/offbox.go` (renamed here); everything else is the distinct "Hálózati tárhely"
|
||||
feature or English comments/tests (untouched by design).
|
||||
- Windows-only pre-existing failure found+fixed: read-only-handle fsync in `atomicPromoteTar`
|
||||
(the F7 tests were red on the dev box, green on Linux — a silent hole in the local green gate).
|
||||
- Browser-automation note: `find`-ref clicks on plain submit buttons focused but did not submit
|
||||
(coordinate clicks did); the data-confirm buttons worked via refs. Cosmetic, tooling-side.
|
||||
- **.fab browser-UPLOAD** remains the noted follow-up (import is drive-scan only — downloaded
|
||||
bundles return via a drive/share, exactly as exercised here).
|
||||
- **Combined mega-zip** stays parked (decision; per-app sequential batch shipped instead).
|
||||
- **appexport packages LIVE state** (fresh config copy + DB dump + live data), NOT the tier-1
|
||||
recovery unit — §8's "stale unit" concern is moot; no "futtass előbb mentést" needed.
|
||||
- The import page's drive-label mojibake ("TÃ˘rhely (felhom-usb)") is the KNOWN open fix-5 item.
|
||||
- `NoUserDataBackupWarning` is referenced by the per-app section but never set by any handler
|
||||
(dead conditional, pre-existing); `DBDumpTotalBytes` was computed but never rendered — dropped
|
||||
in the split.
|
||||
- Drill box left as found: hot-added disk detached + LV removed; ActualBudget re-toggled; demo
|
||||
exports dir + stray export temp cleaned.
|
||||
|
||||
Reference in New Issue
Block a user