v0.315.0 worked and looked, in the operator's words, messy: boxes of different widths stacked down
the page, with the same card shape around things you act on and things you only read. The mockup
approved on 2026-10-15 replaces it, and each of its three rules has a reason:
ONE COLUMN OF ONE WIDTH (820px). Differing widths read as a page assembled by accident.
SECTIONS ARE HAIRLINES, NOT CARDS. A card says "this is a thing you act on"; most of an app page
is a thing you READ, so a card there is a promise the content cannot keep.
A BOX MEANS SOMETHING. Exactly two remain: blue when the app is waiting for the household,
amber when something is risky. The exception-colour principle applied to shape as well.
What moved:
- the hero loses its box: a 64px logo tile, the name at 26px, the tagline, then hairline chips
(state, lifecycle, update) and meta text (the address, the last automatic update);
- the tabs are links with a 2px blue underline under the open one — no pills, no fills;
- sections are `padding: 28px 0` with a bottom hairline; rows are a 200px label column so every
value on the page starts at the same x, and stack under 720px;
- the after-start callout is now the FIRST thing on Beallitasok. A household opening a Plex that
wants its claim code should meet the code box, not a Restart button;
- "2. mentes beallitasa — <app>" and "<app> — Exportalas" are gone: they were the headings of
pages that no longer exist, on a tab that already says which app this is;
- the settings tab gains "Cim es kulcsok" with one address row, and the disabled subdomain input
that said the same thing is skipped for an installed app (the install wizard still asks);
- the "this app is already installed, the settings are read-only" BANNER becomes the hint under
the fields it is about;
- the install wizard gets the same back link, hero and column, so pressing Telepites does not
land the household on a page that looks like a different product.
THE AUTO-UPDATE SUCCESS BANNER IS GONE. It was a full-width blue box above the tabs, level with
"the update failed" and "your files are missing". A success that asked nothing of the household is
a date, and it is now meta text in the hero. Every banner that DOES need a decision — a failed
update, a hold, lost files, a missing drive, an interrupted install — is untouched, above the tabs,
exactly where R-571 puts it.
Tests: TestAppPage_OneColumnLayout (one column, one aria-current, no card-shaped section, no
success banner), TestAppPage_AutoUpdateSuccessIsMetaNotBanner, TestAppPage_CalloutsOnlyForAskAndWarn
(one blue callout on a waiting app and it comes first; one amber on a same-disk backup; none on the
good case). Four red-proofs recorded in REPORT.
app_row_dedup_gate convicted `.app-row`, correctly: that class already means "a row in the app
list". The app page's label/value row is `.app-field-row`. Restoring the list's own rule after an
over-broad rename was part of the fix.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_0117kRTSgs3rJWUFGxyoWN6Y
This commit is contained in:
@@ -1,5 +1,6 @@
|
||||
{{define "app_settings"}}
|
||||
{{template "layout_start" .}}
|
||||
<div class="app-page">
|
||||
{{template "app_shell_start" .}}
|
||||
|
||||
{{/* „BEALLITASOK" — the tab an installed app opens on.
|
||||
@@ -20,10 +21,33 @@
|
||||
{{if .FlashSuccess}}<div class="flash flash-success">{{.FlashSuccess}}</div>{{end}}
|
||||
{{if .FlashError}}<div class="flash flash-error">{{.FlashError}}</div>{{end}}
|
||||
|
||||
{{/* 1. MUKODES. Stop asks first — it takes the app away from everyone in the house, and the
|
||||
{{/* 1. WHAT THE APP IS WAITING FOR — the generic after-start card (Part 4, D2 = A).
|
||||
FIRST on the tab (v0.316.0): a household opening a Plex that wants its claim code should
|
||||
meet the code box, not a Restart button. It is the page's one BLUE callout — a request,
|
||||
never a fault, so never amber.
|
||||
The catalog says a value is asked after the The catalog says a value is asked after the
|
||||
app starts and supplies its label; the ACTION is Go code in after_start.go, keyed by slug
|
||||
and env var. A field with no registered action renders nothing and POSTs 404 — the catalog
|
||||
cannot make the box run anything. */}}
|
||||
{{- range .AfterStartFields}}
|
||||
<div class="app-section app-callout app-callout-ask" data-afterstart="{{.EnvVar}}">
|
||||
<h3>{{T "app_page.after_start_title"}}</h3>
|
||||
{{if .Description}}<p>{{.Description}}</p>{{end}}
|
||||
<div class="input-with-button">
|
||||
<input type="text" id="after-start-{{.EnvVar}}" class="form-control"
|
||||
placeholder="{{.Placeholder}}" autocomplete="off" spellcheck="false"
|
||||
aria-label="{{.Label}}">
|
||||
<button type="button" class="btn btn-sm btn-primary"
|
||||
onclick="appAfterStart(this, '{{$.Meta.Slug}}', '{{.EnvVar}}')">{{T "app_page.after_start_btn"}}</button>
|
||||
</div>
|
||||
<span class="form-hint app-press-err" style="display:none;color:var(--red)"></span>
|
||||
</div>
|
||||
{{- end}}
|
||||
|
||||
{{/* 2. MUKODES. Stop asks first — it takes the app away from everyone in the house, and the
|
||||
protected stacks refuse it server-side regardless (traefik, cloudflared, the controller
|
||||
itself and always samba). */}}
|
||||
<div class="app-info-card" id="app-run-card" data-run-card="1">
|
||||
<div class="app-section" id="app-run-card" data-run-card="1">
|
||||
<h3>{{T "app_page.mukodes"}}</h3>
|
||||
<p class="form-hint" data-run-state="{{.Stack.State}}">{{stateLabel .Stack.State}}</p>
|
||||
<div style="display:flex;gap:.5rem;flex-wrap:wrap;margin-top:.5rem">
|
||||
@@ -36,15 +60,15 @@
|
||||
</div>
|
||||
</div>
|
||||
|
||||
{{/* 2. WHAT THE APP STILL WANTS FROM THE HOUSEHOLD. */}}
|
||||
{{/* 3. THE REST OF WHAT THE APP WANTS FROM THE HOUSEHOLD. */}}
|
||||
{{- if .InstallHoldClosed}}
|
||||
<div class="app-info-card" style="margin-top:1rem" id="install-hold-card">
|
||||
<div class="app-section" style="margin-top:1rem" id="install-hold-card">
|
||||
<h3>{{T "app_info.install_hold_title"}}</h3>
|
||||
<p>{{T "app_info.install_hold_closed"}}</p>
|
||||
</div>
|
||||
{{- end}}
|
||||
{{- if .SetupGateClosed}}
|
||||
<div class="app-info-card" style="margin-top:1rem" id="setup-gate-card">
|
||||
<div class="app-section" style="margin-top:1rem" id="setup-gate-card">
|
||||
<h3>{{T "app_info.setup_gate_title"}}</h3>
|
||||
<p>{{T "app_info.setup_gate_closed"}}</p>{{- if .SignupNative}}
|
||||
<p class="form-hint" data-restarts-once="true">{{T "app_info.restarts_once"}}</p>{{- end}}
|
||||
@@ -59,26 +83,8 @@
|
||||
</div>
|
||||
{{- end}}
|
||||
|
||||
{{/* The generic after-start card (Part 4, D2 = A). The catalog says a value is asked after the
|
||||
app starts and supplies its label; the ACTION is Go code in after_start.go, keyed by slug and
|
||||
env var. A field with no registered action renders nothing and POSTs 404 — the catalog
|
||||
cannot make the box run anything. */}}
|
||||
{{- range .AfterStartFields}}
|
||||
<div class="app-info-card after-start-card" data-afterstart="{{.EnvVar}}">
|
||||
<h3>{{T "app_page.after_start_title"}}</h3>
|
||||
{{if .Description}}<p>{{.Description}}</p>{{end}}
|
||||
<div class="input-with-button">
|
||||
<input type="text" id="after-start-{{.EnvVar}}" class="form-control"
|
||||
placeholder="{{.Placeholder}}" autocomplete="off" spellcheck="false"
|
||||
aria-label="{{.Label}}">
|
||||
<button type="button" class="btn btn-sm btn-primary"
|
||||
onclick="appAfterStart(this, '{{$.Meta.Slug}}', '{{.EnvVar}}')">{{T "app_page.after_start_btn"}}</button>
|
||||
</div>
|
||||
<span class="form-hint app-press-err" style="display:none;color:var(--red)"></span>
|
||||
</div>
|
||||
{{- end}}
|
||||
{{- if .CloseSignupOffered}}
|
||||
<div class="app-info-card" style="margin-top:1rem" id="close-signup-card">
|
||||
<div class="app-section" style="margin-top:1rem" id="close-signup-card">
|
||||
<h3>{{T "app_info.signup_title"}}</h3>
|
||||
<p>{{T "app_info.close_signup_text"}}</p>{{- if .SignupNative}}
|
||||
<p class="form-hint" data-restarts-once="true">{{T "app_info.restarts_once"}}</p>{{- end}}
|
||||
@@ -87,7 +93,7 @@
|
||||
</div>
|
||||
{{- end}}
|
||||
{{- if or .SignupClosed .SignupOpenUntil}}
|
||||
<div class="app-info-card" style="margin-top:1rem" id="signup-card">
|
||||
<div class="app-section" style="margin-top:1rem" id="signup-card">
|
||||
<h3>{{T "app_info.signup_title"}}</h3>
|
||||
{{- if .SignupOpenUntil}}
|
||||
<p>{{T "app_info.signup_open_until"}} {{.SignupOpenUntil}}</p>
|
||||
@@ -114,9 +120,9 @@
|
||||
{{- end}}
|
||||
|
||||
{{/* The logins, each already its own guarded card on the details page. */}}
|
||||
<div class="app-info-grid">
|
||||
<div class="app-sections">
|
||||
{{if .InitialCreds}}
|
||||
<div class="app-info-card">
|
||||
<div class="app-section">
|
||||
<h3>{{T "app_info.kezdeti_belepesi_adatok"}}</h3>
|
||||
<table class="initcred-table">
|
||||
{{if .InitialCreds.Username}}
|
||||
@@ -151,7 +157,7 @@
|
||||
{{end}}
|
||||
|
||||
{{if and .AppInfo.DefaultCreds (not .DefaultLoginReplaced)}}
|
||||
<div class="app-info-card">
|
||||
<div class="app-section">
|
||||
<h3>{{T "app_info.alapertelmezett_belepes"}}</h3>
|
||||
<p class="app-info-creds">{{.AppInfo.DefaultCreds}}</p>
|
||||
{{if .KnownLoginLine}}<p class="app-info-creds-warn" id="known-login-line">{{.KnownLoginLine}}</p>{{else}}<p class="app-info-creds-warn">{{T "app_info.az_elso_bejelentkezes_utan_azonnal_2"}}</p>{{end}}
|
||||
@@ -162,10 +168,10 @@
|
||||
</div>
|
||||
{{end}}</div>
|
||||
|
||||
{{/* 3. THE SETTINGS. Everything below came from the install page's deployed mode, unchanged. */}}
|
||||
<div class="alert alert-info">
|
||||
{{T "deploy.ez_az_alkalmazas_mar_telepitve"}}
|
||||
</div>
|
||||
{{/* 3. THE SETTINGS. v0.316.0: the „this app is already installed, the settings below are
|
||||
read-only" BANNER is gone — it was a box saying what a one-line hint says, on a tab the
|
||||
household reached by pressing „Beallitasok" on an installed app. The hint lives with the
|
||||
fields it is about, at the bottom of this tab. */}}
|
||||
{{if .StorageInfo}}
|
||||
<div class="deploy-storage-info">
|
||||
<h4>{{T "deploy.adattarolas"}}</h4>
|
||||
@@ -536,9 +542,19 @@
|
||||
</form>
|
||||
</div>
|
||||
{{end}}
|
||||
<form id="deploy-form" class="deploy-form">
|
||||
<div class="app-section">
|
||||
<h3>{{T "app_page.address_and_keys"}}</h3>
|
||||
{{if .EffectiveSubdomain}}
|
||||
<div class="app-field-row">
|
||||
<div class="app-field-label">{{T "app_page.address"}}</div>
|
||||
<div class="app-field-value" data-app-address-row="1">{{.EffectiveSubdomain}}.{{.Domain}}</div>
|
||||
</div>
|
||||
{{end}}
|
||||
<form id="deploy-form" class="deploy-form">
|
||||
{{template "app_deploy_fields" .}}
|
||||
</form>
|
||||
</form>
|
||||
<p class="app-field-hint" data-readonly-hint="1">{{T "app_page.installed_readonly"}}</p>
|
||||
</div>
|
||||
</div>
|
||||
|
||||
{{if .InitialCreds}}
|
||||
@@ -711,5 +727,6 @@ function deleteStaleDataRun(stackName, stalePath, btn) {
|
||||
|
||||
</script>
|
||||
|
||||
</div>{{/* .app-page */}}
|
||||
{{template "layout_end" .}}
|
||||
{{end}}
|
||||
|
||||
Reference in New Issue
Block a user