admin/felhom-controller
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

test: io.Discard logger in fix-3 tests

Browse Source
This commit is contained in:
authentik Default Admin
2026-07-12 10:08:39 +02:00
parent d8f6069b46
commit 6ab8f943af
2 changed files with 7 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
controller/internal/notify/deadapp_test.go
+4 -3
View File
@@ -1,6 +1,7 @@
package notify package notify
import ( import (
"io"
"log" "log"
"testing" "testing"
) )
@@ -8,7 +9,7 @@ import (
// fix-3: app_start_failed fires ONCE per running→down transition. down→down cycles are silent (the // fix-3: app_start_failed fires ONCE per running→down transition. down→down cycles are silent (the
// anti-spam guarantee); down→running clears the tracker so a later re-failure re-notifies. // anti-spam guarantee); down→running clears the tracker so a later re-failure re-notifies.
func TestNotifyAppStartFailures_OneEventPerTransition(t *testing.T) { func TestNotifyAppStartFailures_OneEventPerTransition(t *testing.T) {
n := New("http://hub", "key", "cust", nil, log.New(nil, "", 0), false) n := New("http://hub", "key", "cust", nil, log.New(io.Discard, "", 0), false)
var events []string var events []string
n.pushFn = func(eventType, _, msg string, _ interface{}) { n.pushFn = func(eventType, _, msg string, _ interface{}) {
if eventType == "app_start_failed" { if eventType == "app_start_failed" {
@@ -42,7 +43,7 @@ func TestNotifyAppStartFailures_OneEventPerTransition(t *testing.T) {
// An app that is down on the FIRST evaluation (the F11 dead-at-boot case, after the boot grace) still // An app that is down on the FIRST evaluation (the F11 dead-at-boot case, after the boot grace) still
// fires — it is a running→down transition from the tracker's empty initial state. // fires — it is a running→down transition from the tracker's empty initial state.
func TestNotifyAppStartFailures_FirstSeenDownFires(t *testing.T) { func TestNotifyAppStartFailures_FirstSeenDownFires(t *testing.T) {
n := New("http://hub", "key", "cust", nil, log.New(nil, "", 0), false) n := New("http://hub", "key", "cust", nil, log.New(io.Discard, "", 0), false)
var count int var count int
n.pushFn = func(eventType, _, _ string, _ interface{}) { n.pushFn = func(eventType, _, _ string, _ interface{}) {
if eventType == "app_start_failed" { if eventType == "app_start_failed" {
@@ -57,7 +58,7 @@ func TestNotifyAppStartFailures_FirstSeenDownFires(t *testing.T) {
// A deployed app that is up never fires. // A deployed app that is up never fires.
func TestNotifyAppStartFailures_HealthyNeverFires(t *testing.T) { func TestNotifyAppStartFailures_HealthyNeverFires(t *testing.T) {
n := New("http://hub", "key", "cust", nil, log.New(nil, "", 0), false) n := New("http://hub", "key", "cust", nil, log.New(io.Discard, "", 0), false)
var count int var count int
n.pushFn = func(string, string, string, interface{}) { count++ } n.pushFn = func(string, string, string, interface{}) { count++ }
n.NotifyAppStartFailures([]AppRunState{{Name: "radarr", Down: false}}) n.NotifyAppStartFailures([]AppRunState{{Name: "radarr", Down: false}})
controller/internal/web/deadapp_alert_test.go
+3 -2
View File
@@ -1,6 +1,7 @@
package web package web
import ( import (
"io"
"log" "log"
"strings" "strings"
"testing" "testing"
@@ -10,7 +11,7 @@ import (
// clears it. COMPANION red-proof: skip SetDeadAppAlerts entirely (the pre-fix-3 silence) → GetAlerts // clears it. COMPANION red-proof: skip SetDeadAppAlerts entirely (the pre-fix-3 silence) → GetAlerts
// has no dead-app banner → the "not fut" assertion fails. // has no dead-app banner → the "not fut" assertion fails.
func TestDeadAppAlerts_PresentAndSelfClearing(t *testing.T) { func TestDeadAppAlerts_PresentAndSelfClearing(t *testing.T) {
am := NewAlertManager(log.New(nil, "", 0)) am := NewAlertManager(log.New(io.Discard, "", 0))
am.SetDeadAppAlerts([]DeadApp{{Name: "cwa", DisplayName: "Calibre-Web", State: "stopped"}}) am.SetDeadAppAlerts([]DeadApp{{Name: "cwa", DisplayName: "Calibre-Web", State: "stopped"}})
got := am.GetAlerts() got := am.GetAlerts()
@@ -31,7 +32,7 @@ func TestDeadAppAlerts_PresentAndSelfClearing(t *testing.T) {
// Above the group threshold, many dead apps collapse to ONE grouped banner (a reboot storm must not // Above the group threshold, many dead apps collapse to ONE grouped banner (a reboot storm must not
// paper the dashboard). // paper the dashboard).
func TestDeadAppAlerts_GroupedAboveThreshold(t *testing.T) { func TestDeadAppAlerts_GroupedAboveThreshold(t *testing.T) {
am := NewAlertManager(log.New(nil, "", 0)) am := NewAlertManager(log.New(io.Discard, "", 0))
var many []DeadApp var many []DeadApp
for _, n := range []string{"radarr", "jellyfin", "navidrome", "calibre", "seerr"} { for _, n := range []string{"radarr", "jellyfin", "navidrome", "calibre", "seerr"} {
many = append(many, DeadApp{Name: n, DisplayName: n, State: "stopped"}) many = append(many, DeadApp{Name: n, DisplayName: n, State: "stopped"})