v0.263.1: the undo asks the old probe even on an app marked unhealthy (R-637)

Found live on 9202: the periodic probe (current .felhom.yml, new port) flips the app to unhealthy, and the update's health wait probed only 'running' apps - so the undo's old probe was never asked and a serving old version was judged "did not start". With the undo's override, an unhealthy app is probed and the old check decides; never settled on container state. New seam probeRunFn; the test drives the real wait loop and reproduces the live message when the fix is switched off. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0159rPz1ZhFKsS53msqPYxtS
2026-09-23 11:35:25 +02:00
parent 8fc2b4a1a9
commit 5d38573a1a
4 changed files with 109 additions and 3 deletions
@@ -242,6 +242,7 @@ type Manager struct {
 	// which receives the probe it must use (nil ⇒ waitUpdateHealthyMeta).
 	undoCopier         volumeCopier
 	updateUndoHealthFn func(ctx context.Context, name string, timeout time.Duration, meta *Metadata) (bool, string)
+	probeRunFn         func(t probeTarget) *HealthProbeResult // the health wait's network probe; nil ⇒ runChecks
 	updateMemoryFn     func(newReqMB, newLimitMB, releasedReqMB, releasedLimitMB int) (refusal error, warning string)
 	updateDiskFreeFn   func() (freeGiB float64, ok bool)
 	updateNowFn        func() time.Time