Review fix 2: a take-back or an install during the clean-up window keeps the copies (D72)

The due end records and the candidates were read once, before the hub was
asked, and never again before the forget. A „Mégis megtartom” or an install
while the hub answered still deleted the copies.

The window now reads the records again immediately before the forget and takes
out every id whose record is gone, changed or no longer due. From that look
until the forget has ended, a take-back is answered „not marked, or already
deleted”, never „kept”. Not covered: an install during the forget itself.

Tests seen red on f628cb5, then green; mutations in felhom.eu
documentation/audits/build-release-4-2026-11-15/A/redproof-review-2.txt.

Claude-Session: https://claude.ai/code/session_0159rPz1ZhFKsS53msqPYxtS
This commit is contained in:
admin committed 2026-11-15 14:27:09 +01:00
1 parent f628cb5082
commit 3928c3db28
5 files changed
+221 -1

No files matched your search

+4
View File
@@ -132,6 +132,10 @@ type Manager struct {
// offsiteEndNotify (D84) tells the household ONCE per press that an app's off-site copies are marked for
// deletion. Wired in main.go to the notifier; nil-safe. Called only when a record was really written.
offsiteEndNotify func(rec settings.OffsiteEnd)
// offsiteEndMu guards offsiteEndRemoving: the apps whose off-site copies a clean-up window is removing RIGHT NOW
// (from its last look at the records until its forget has ended). A take-back for such an app is not „kept”.
offsiteEndMu sync.Mutex
offsiteEndRemoving map[string]bool
// offsiteAbandon (v0.290.0, decision 74) hands a due set-aside deletion to the hub.
offsiteAbandon OffsiteAbandonClient