night 2026-10-23 docs: CONTEXT (0.340.0 candidate), REPORT (both review rounds, rc.8 re-proof), the OffsiteStateAwaitingRecoveryKey comment corrected (its hub claim was measured false: felhom.eu R-1230); no behaviour change

2026-10-23 00:05:34 +02:00
parent 1babfe94f6
commit 23f77f93ba
3 changed files with 31 additions and 3 deletions
@@ -1742,8 +1742,10 @@ const OffsiteStateNeedsCredential = "needs_credential"
 //     so it will not re-stage a credential this box already has;
 //   - `monitor.OffsiteChecker.isStale` returns false unless `Enabled && EscrowState == "escrowed"`,
 //     and this object carries Enabled=false;
-//   - `monitor/offsite_delivery.go` keys on the delivery shape, which is `applied` here (the secret
-//     WAS consumed), and that branch is skipped;
+//   - `monitor/offsite_delivery.go`: this comment once said the branch is skipped (`applied`). MEASURED FALSE on
+//     2026-10-23 (test night, Tester4): the held box carries no offbox target, so the hub read „consumed, never
+//     applied" → a false `offsite_delivery_stuck` mail and a re-issue after one hour. Fixed in the hub (R-1230,
+//     hub 0.167.0 source: this state stands the checker down), pinned by the hub's TestR1230_AHeldBoxIsNotStuck;
 //   - an unknown `state` string is ignored by encoding/json on an older hub.
 //
 // So this needs NO hub change to be safe. It does mean a held box raises no alarm — which is R-243,