felhom-agent/internal/guesthook/netreassert_test.go

package guesthook

import (
	"context"
	"testing"

	"gitea.dooplex.hu/admin/felhom-agent/internal/storage"
)

type fakeReasserter struct {
	invoked int
	results []storage.NetReassertResult
}

func (f *fakeReasserter) ReassertNetworkAutomounts(context.Context) []storage.NetReassertResult {
	f.invoked++
	return f.results
}

// The post-start core must run the reassert pass and verify guest visibility for every share the
// pass acted on (or found actively mounted) — and never for foreign/errored rows.
func TestPostStartNetworkReassert_Core(t *testing.T) {
	ops := &fakeReasserter{results: []storage.NetReassertResult{
		{Name: "media", Where: "/mnt/felhom-drives/media", Action: storage.NetReassertRearmed},
		{Name: "active", Where: "/mnt/felhom-drives/active", Action: storage.NetReassertSkipActive},
		{Name: "foreign", Where: "/mnt/felhom-drives/foreign", Action: storage.NetReassertSkipForeign},
	}}
	var verified []string
	postStartNetworkReassert(context.Background(), "9201", ops, func(_ context.Context, vmid, path string) bool {
		if vmid != "9201" {
			t.Errorf("verify called with vmid %q, want 9201", vmid)
		}
		verified = append(verified, path)
		return true
	})
	if ops.invoked != 1 {
		t.Fatalf("reassert pass invoked %d times, want 1", ops.invoked)
	}
	if len(verified) != 2 || verified[0] != "/mnt/felhom-drives/media" || verified[1] != "/mnt/felhom-drives/active" {
		t.Fatalf("verify must cover rearmed + skip-active only, got %v", verified)
	}
}

// A failed verify must be non-fatal: the core returns normally (the hook exits 0 regardless).
func TestPostStartNetworkReassert_VerifyFailureNonFatal(t *testing.T) {
	ops := &fakeReasserter{results: []storage.NetReassertResult{
		{Name: "media", Where: "/mnt/felhom-drives/media", Action: storage.NetReassertRearmed},
	}}
	// Must not panic or abort; the WARNING goes to stderr (PVE task log).
	postStartNetworkReassert(context.Background(), "9201", ops, func(context.Context, string, string) bool {
		return false
	})
	if ops.invoked != 1 {
		t.Fatalf("reassert pass invoked %d times, want 1", ops.invoked)
	}
}