From 6c1762141a38e71982539f477fd8862045026264 Mon Sep 17 00:00:00 2001 From: kisfenyo Date: Wed, 18 Feb 2026 10:38:51 +0100 Subject: [PATCH] v0.12.7: mandatory HDD backup, pre-dump, restore for all apps MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Fix 1: HDD data backup is now mandatory for all deployed apps. resolveAppBackupPaths() iterates ListDeployedStacks() directly — no longer reads GetAppBackupMap() or checks the Enabled flag. DiscoverAppData() drops backupPrefs parameter; BackupEnabled is set from HasHDDData. Five dead settings methods removed: IsAppBackupEnabled, SetAppBackup, GetAppBackupMap, SetAppBackupBulk, GetAppBackupPrefs. Fix 2: Cross-drive backup now triggers a fresh DB dump (DumpStackDB) before running. DBDumper interface added to crossdrive.go; Manager implements it; SetDBDumper wired in main.go. Non-fatal — proceeds with user data backup even if DB dump fails. Fix 3: Restore dropdown shows ALL deployed apps (not just HDD+enabled). restore.go rewritten: always restores config+DB, adds user data if hasHDD. UI shows restore type banner (full / config+DB / config only) with color-coded styling. Snapshot API clarified for non-HDD apps. Fix 4: "Docker kötetek" → "Konfiguráció" — named volumes are not in the restic backup paths; compose files + app.yaml are what's backed up. Co-Authored-By: Claude Sonnet 4.6 --- CHANGELOG.md | 30 ++++++++ controller/README.md | 38 ++++++---- controller/cmd/controller/main.go | 5 ++ controller/internal/api/router.go | 3 + controller/internal/backup/appdata.go | 6 +- controller/internal/backup/backup.go | 68 ++++++++++++++---- controller/internal/backup/crossdrive.go | 20 ++++++ controller/internal/backup/restore.go | 72 ++++++++++++------- controller/internal/settings/settings.go | 65 ----------------- .../internal/web/templates/backups.html | 27 +++++-- controller/internal/web/templates/style.css | 15 ++++ 11 files changed, 225 insertions(+), 124 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index c05009e..90e740e 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,5 +1,35 @@ ## Changelog +### What was just completed (2026-02-18 session 43) +- **v0.12.7 — Backup Architecture Overhaul (mandatory HDD backup, pre-dump, restore for all apps):** + + **Fix 1: HDD data backup now mandatory (`backup.go`, `appdata.go`, `settings.go`)** + - `resolveAppBackupPaths()` rewrote to iterate ALL deployed stacks via `ListDeployedStacks()` — no longer reads `GetAppBackupMap()` or checks `Enabled` flag + - `DiscoverAppData()` signature simplified: dropped `backupPrefs map[string]bool` parameter; `BackupEnabled` is now derived from `HasHDDData` (if app has HDD data, it's always backed up) + - `RefreshCache()` updated to call new `DiscoverAppData(m.stackProvider, status.DiscoveredDBs)` signature + - 5 dead settings methods deleted: `IsAppBackupEnabled`, `SetAppBackup`, `GetAppBackupMap`, `SetAppBackupBulk`, `GetAppBackupPrefs` — `AppBackupPrefs.Enabled` field kept in struct for backward-compat JSON loading + + **Fix 2: Cross-drive backup triggers fresh DB dump first (`crossdrive.go`, `backup.go`, `main.go`)** + - New `DBDumper` interface with `DumpStackDB(ctx, stackName)` in `crossdrive.go` + - `CrossDriveRunner` gets `dbDumper` field + `SetDBDumper(d DBDumper)` setter + - `Manager.DumpStackDB()` discovers containers for that stack via `DiscoverDatabases()`, runs `DumpAll()`, persists validation cache — same logic as nightly dump but scoped to one stack + - `RunAppBackup()` calls `DumpStackDB()` before `ValidateDestination()` — non-fatal on failure (logs warn, proceeds with user data) + - `main.go` wires `crossDriveRunner.SetDBDumper(backupMgr)` after both are initialized + + **Fix 3: Restore dropdown shows ALL deployed apps (`backups.html`, `restore.go`, `router.go`)** + - `restore.go` rewritten: no `IsAppBackupEnabled()` check; resolves `GetStackComposePath` + `DBDumpDir` + HDD mounts; always restores config+DB, adds user data if `hasHDD`; logs restore type (`config+DB` vs `full (config+DB+userdata)`) + - Restore dropdown template: removed `{{if and .HasHDDData .BackupEnabled}}` filter; every app gets an `