From 36afd828a1ca507eca7d8a3e998da78dc81606d4 Mon Sep 17 00:00:00 2001 From: kisfenyo Date: Fri, 27 Feb 2026 18:51:59 +0100 Subject: [PATCH] fix: FileBrowser reads stale config on fresh deployments The gtstef/filebrowser image bakes FILEBROWSER_CONFIG=/home/filebrowser/data/config.yaml, but controller mounts config at /home/filebrowser/config.yaml. Override the env var in both generateFileBrowserCompose() and docker-setup.sh so FileBrowser reads the controller-managed config with proper sources and database path. Co-Authored-By: Claude Opus 4.6 --- CHANGELOG.md | 8 ++++++++ CLAUDE.md | 2 +- CONTEXT.md | 2 +- controller/README.md | 2 +- controller/internal/web/handlers.go | 1 + scripts/docker-setup.sh | 1 + 6 files changed, 13 insertions(+), 3 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index cc3afdb..eba34d8 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,5 +1,13 @@ ## Changelog +### v0.32.7 — Fix FileBrowser config not being read on fresh deployments (2026-02-27) + +#### Fixed +- **web/handlers.go**: `generateFileBrowserCompose()` now sets `FILEBROWSER_CONFIG=/home/filebrowser/config.yaml` environment variable — the `gtstef/filebrowser` image bakes in `FILEBROWSER_CONFIG=/home/filebrowser/data/config.yaml` which reads a stale initial config from the data volume instead of the controller-managed bind mount. This caused fresh deployments to show only a single "srv" source, ignore per-drive sidebar entries, and create the database outside the persistent volume (triggering the "new database was created" warning on every container recreation) + +#### Changed +- **scripts/docker-setup.sh**: Initial FileBrowser compose template also includes the `FILEBROWSER_CONFIG` override for consistency + ### v0.32.6 — Format empty partitions on system disk (2026-02-27) #### Added diff --git a/CLAUDE.md b/CLAUDE.md index 41fe5d3..3a78103 100644 --- a/CLAUDE.md +++ b/CLAUDE.md @@ -109,7 +109,7 @@ substitute the full path manually. | Node | OS | Hardware | Domain | IP | Notes | |------|-----|----------|--------|----|-------| | demo-felhom | Debian 13 | Acemagic N100, 16G RAM, 512G SSD + 1TB HDD | demo-felhom.eu | 192.168.0.162 | Primary test node, Cloudflare Tunnel | -| felhotest | Debian 13 | Remote VPS, 200G + 100G disk | — | router.abonet.hu:33022 | Remote test node | +| felhotest | Debian 13 | Proxmox VM (4-16G RAM, 8 vCPU, 200G + 100G SCSI) | — | router.abonet.hu:33022 | Remote test node | | pi-customer-1 | Debian 13 | Raspberry Pi 3B+, 1G RAM, 32G SD | pi-customer-1.local | 192.168.0.161 | Secondary test, not yet active | - Pi-hole DNS on local network forwards `*.demo-felhom.eu` → 192.168.0.162 diff --git a/CONTEXT.md b/CONTEXT.md index a07e6e4..a5c8594 100644 --- a/CONTEXT.md +++ b/CONTEXT.md @@ -40,7 +40,7 @@ Last updated: 2026-02-19 (session 59) - **v0.11.8:** ✅ COMPLETE — Per-App Cross-Drive Backup (3-2-1 rule): rsync/restic to secondary drive, deploy page UI, backup page summary, scheduler jobs, API endpoints - **v0.11.9:** ✅ COMPLETE — UI Polish Fixes: spacing, tooltip on "Módszer", status dot instead of disabled checkbox, progressive disclosure, emoji cleanup - **First app deployed:** Paperless-ngx on demo-felhom.eu (2026-02-13) -- **Running on:** demo-felhom (N100 mini PC) at 192.168.0.162:8080, felhotest (remote VPS) at router.abonet.hu:33022 +- **Running on:** demo-felhom (N100 mini PC) at 192.168.0.162:8080, felhotest (Proxmox VM) at router.abonet.hu:33022 - **All Phase 1-5 features working:** deploy, start/stop/restart/update, logs, health-aware states, auth, monitoring, backups, backup detail page, system monitoring page, settings page ## Architecture decisions diff --git a/controller/README.md b/controller/README.md index 531615a..1aee87f 100644 --- a/controller/README.md +++ b/controller/README.md @@ -1788,7 +1788,7 @@ See `docker-compose.yml` for the full volume configuration. | Node | Hardware | Domain | Status | |------|----------|--------|--------| | demo-felhom | Acemagic GK3PLUS N100, 16G RAM, 512G SSD + 1TB HDD | demo-felhom.eu | Active | -| felhotest | Remote VPS, 200G + 100G disk | router.abonet.hu:33022 | Active | +| felhotest | Proxmox VM (4-16G RAM, 8 vCPU, 200G + 100G SCSI) | router.abonet.hu:33022 | Active | | pi-customer-1 | Raspberry Pi 3B+, 1G RAM, 32G SD | pi-customer-1.local | Not yet tested | ## Related Repositories diff --git a/controller/internal/web/handlers.go b/controller/internal/web/handlers.go index dc7109b..78da3cd 100644 --- a/controller/internal/web/handlers.go +++ b/controller/internal/web/handlers.go @@ -1774,6 +1774,7 @@ services: restart: unless-stopped environment: - TZ=Europe/Budapest + - FILEBROWSER_CONFIG=/home/filebrowser/config.yaml volumes: - filebrowser_data:/home/filebrowser/data - ./config.yaml:/home/filebrowser/config.yaml:ro%s diff --git a/scripts/docker-setup.sh b/scripts/docker-setup.sh index 2f0d2e0..da27307 100644 --- a/scripts/docker-setup.sh +++ b/scripts/docker-setup.sh @@ -1304,6 +1304,7 @@ services: restart: unless-stopped environment: - TZ=Europe/Budapest + - FILEBROWSER_CONFIG=/home/filebrowser/config.yaml volumes: - filebrowser_data:/home/filebrowser/data - ./config.yaml:/home/filebrowser/config.yaml:ro