From 6e4b1bb0543cfcd2d392b599b8510d9882a7c7ed Mon Sep 17 00:00:00 2001 From: kisfenyo Date: Thu, 1 Oct 2026 21:03:05 +0200 Subject: [PATCH] rallly: remove the client-written X-Forwarded-For chain on its router (R-753) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit leftmost XFF for its /api/event per-IP limit. Once traefik trusts the tunnel's fixed address (controller v0.286.0), the leftmost entry is what a stranger writes; with the chain removed the app reads traefik's X-Real-Ip or its peer, as before — never forgeable. Measured on 9202: a router with this middleware receives no X-Forwarded-For (felhom.eu audits/visitors-2026-10-01/A/P1). Co-Authored-By: Claude Opus 5.5 (1M context) Claude-Session: https://claude.ai/code/session_0159rPz1ZhFKsS53msqPYxtS --- templates/rallly/docker-compose.yml | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/templates/rallly/docker-compose.yml b/templates/rallly/docker-compose.yml index 9ff77b7..c377b1b 100644 --- a/templates/rallly/docker-compose.yml +++ b/templates/rallly/docker-compose.yml @@ -54,6 +54,10 @@ services: labels: - "traefik.enable=true" - "traefik.http.routers.rallly.rule=Host(`${SUBDOMAIN}.${DOMAIN}`)" + # R-753: this app reads the LEFTMOST X-Forwarded-For entry, which a stranger writes once traefik keeps the + # tunnel's chain — so its chain is removed here (it then reads traefik's X-Real-Ip or peer; never forgeable). + - "traefik.http.middlewares.rallly-xff.headers.customrequestheaders.X-Forwarded-For=" + - "traefik.http.routers.rallly.middlewares=rallly-xff" - "traefik.http.routers.rallly.entrypoints=websecure" - "traefik.http.routers.rallly.tls=true" - "traefik.http.routers.rallly.tls.certresolver=letsencrypt"